Re: [PATCH 2/2] mtd: spi-nor: macronix: Add support for Macronix NOR Flash

Cheng Ming Lin
2025-02-10T06:19:20Z

Hi Michael,

Michael Walle <mwalle@kernel.org> 於 2025年2月7日 週五 下午4:39寫道：
>
> Hi Cheng,
>
> > From: Cheng Ming Lin <chengminglin@mxic.com.tw>
> >
> > Due to incorrect values in the 4-BAIT table for these two flash IDs,
> > it is necessary to add these two flash IDs with fixups.
>
> What's the part number of these flashes?
>
> > --- a/drivers/mtd/spi-nor/macronix.c
> > +++ b/drivers/mtd/spi-nor/macronix.c
> > @@ -127,6 +127,9 @@ static const struct flash_info macronix_nor_parts[]
> > = {
> > .size = SZ_128M,
> > .no_sfdp_flags = SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ,
> > .fixups = &macronix_qpp4b_fixups,
> > + }, {
>
> Although we don't have .name anymore, a comment like
>
> /* <partname> */
>
> is recommended.

Got it. I'll add the partname comment in v2 and will follow this rule
going forward.

>
> > + .id = SNOR_ID(0xc2, 0x20, 0x1c),
> > + .fixups = &macronix_qpp4b_fixups,
> > }, {
> > .id = SNOR_ID(0xc2, 0x23, 0x14),
> > .name = "mx25v8035f",
> > @@ -182,6 +185,9 @@ static const struct flash_info macronix_nor_parts[]
> > = {
> > .no_sfdp_flags = SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ,
> > .fixup_flags = SPI_NOR_4B_OPCODES,
> > .fixups = &macronix_qpp4b_fixups,
> > + }, {
>
> same same
>
> > + .id = SNOR_ID(0xc2, 0x25, 0x3b),
> > + .fixups = &macronix_qpp4b_fixups,
> > }, {
> > .id = SNOR_ID(0xc2, 0x25, 0x3c),
> > .name = "mx66u2g45g",
>
> Thanks,
> -michael

Thanks,
Cheng Ming Lin