From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932286AbbLNVBk (ORCPT ); Mon, 14 Dec 2015 16:01:40 -0500 Received: from v094114.home.net.pl ([79.96.170.134]:59115 "HELO v094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1753285AbbLNVBi (ORCPT ); Mon, 14 Dec 2015 16:01:38 -0500 From: "Rafael J. Wysocki" To: Paul Gortmaker Cc: linux-kernel@vger.kernel.org, Alexander Shiyan , Bartlomiej Zolnierkiewicz , Daniel Lezcano , Krzysztof Kozlowski , Kukjin Kim , linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org Subject: Re: [PATCH 0/3] cpuidle: avoid module usage in non-modular code Date: Mon, 14 Dec 2015 22:31:44 +0100 Message-ID: <8909604.csvS2fCWyS@vostro.rjw.lan> User-Agent: KMail/4.11.5 (Linux/4.1.0-rc5+; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1450051032-32329-1-git-send-email-paul.gortmaker@windriver.com> References: <1450051032-32329-1-git-send-email-paul.gortmaker@windriver.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sunday, December 13, 2015 06:57:09 PM Paul Gortmaker wrote: > This series of commits is a part of a larger project to ensure > people don't reference modular support functions in non-modular > code. Overall there was roughly 5k lines of dead code in the > kernel due to this. So far we've fixed several areas, like tty, > x86, net, ... and we continue to work on other areas. > > There are several reasons to not use module support for code that > can never be built as a module, but the big ones are: > > (1) it is easy to accidentally code up unused module_exit and remove code > (2) it can be misleading when reading the source, thinking it can be > modular when the Makefile and/or Kconfig prohibit it > (3) it requires the include of the module.h header file which in turn > includes nearly everything else. > > Fortunately for cpuidle, the changes are largely trivial and change > zero runtime. All the changes here just remap the modular functions > onto the non-modular ones that they would be remapped onto anyway. > > Changes are against linux-next and compile tested on ARM allmodconfig. > I've Cc'd ARM list because all of these are used on ARM, but I'm > thinking these probably can go in via the PM tree. If no one objects, I can queue up this series for 4.5 unless you have other plans with respect to it. Thanks, Rafael