From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oo1-f98.google.com (mail-oo1-f98.google.com [209.85.161.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7DB363396E6 for ; Wed, 7 Jan 2026 20:19:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.98 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767817172; cv=none; b=tFSW4eSsEfSPrvkC+jBBRp/oCXsxPSyVm8tIO9sH/mVtc+nduk9hxD96J11i2B0SuLtEf9ibL8XhU4OzglobK8Y899EZmhALVbvwSwtt4rkwIZQ+/Koeh0Xpku/j6256k6f6dSJMLoq/PJuo356ig1NfW68whtXoviNleOfT0R4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767817172; c=relaxed/simple; bh=WgO72s1ynGcwkNsytWGBOWu6FCETUWC+LF6+sDMT2sg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Bkct0U3hLBH2X1lrB0vG0QI5WJYfAbjk3Wz7wsTpDpFrV62AeUD3UI0owkm+6ItIrjbAgaPzh8vpc1vHp/6xGNultS2soch0JzNNdO0rDpp7FGN4RyfVjX7YhZVdK5bRyvOrObm5tEW8s39Rgzu6oBDZgeSQvmSrK67FkF0SGho= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=UZr7d1vK; arc=none smtp.client-ip=209.85.161.98 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="UZr7d1vK" Received: by mail-oo1-f98.google.com with SMTP id 006d021491bc7-65d132240b5so1411106eaf.2 for ; Wed, 07 Jan 2026 12:19:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767817166; x=1768421966; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:dkim-signature:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=z+D0U0I/QMaRvqdVI4kOajEvXFaO+vpLvikp7KFwDvI=; b=Oi+c7PPD2itaRS4IAdWVtpe4B3wtGhHgpd9smFydYb3sZRhvLqSACE68LPm73A8a20 ok7CN/rdVMESwLehoEBhziyVWPbDooRf4zlz4S6K4+DoIKEc/O20gQrTXoKz6rL4CoNu j42dN2K3ZjsqCBuOTYip46duALidlEDvX6IoghpjZwUrowfapBLxI5ciWrlx+y0LSda0 /OXK0ms1c+d/RupIPVfP2LFJiIIpMUvC0KxOVvYP/GPBEFr8pxob7aBSkobG/sNBzfpA BbS12YEUtXYLs14WVHueBf1E6X/DR+NdqurpxP0wUygY9tp26IB7bssrbIRggihIb4qH Dauw== X-Forwarded-Encrypted: i=1; AJvYcCXwFcBlbcnSCuiQvfDRixDIXH8tJZXbMQdYvAmGb87KjNFelkpAMaOtsyYtyQ8GYDcfeYqsVj7kIJkKcGI=@vger.kernel.org X-Gm-Message-State: AOJu0YwkSeSoeED70hlOIjr/FPCSI4Dam+I0pnDy6cG+ok8uneuNgIQ1 46X7/YAvFwF3elWl5kvIFG1Y/3IndcwB3awCMuy0iq3pJ4VBTT/mrXeSDRzSmhV/FCqD9XS0J5v jWFEiCIpTxzlLCnyorHpBDbEvkU8KZ8NRatGBW8nfghvhk/luhiPc6X3VTcBrWcCiceA/BMD/A9 Tl4zwIbp4RKgQsHM5sRGeTjbl/O2WvV7oa4aEDok0BV7N9QhtkCJZYuKG/UPbqx42nSsAX4GHFq fjz1FNWhr+VlIM7wF2C8pw= X-Gm-Gg: AY/fxX6MDBz//5fe7AYKLfqJ5AmmLF/krcSHaJWXsx/hjTP506E4twIlO2D4Wim6yvO Wd4IEksaxuZ2k90cECvAKJ1yOUEPnBOWCjb13Ss3MGz+goiLpxh37qtQnwo8n31nYU2nTsZzGd/ 0DYpr+Pt/kMimpLMDzmL3QW0AoC7pK05OV97AizsZ7jdNoPrkns27ibl+XGpko94QIyDNkPHLVJ bKOBb1nlCvsWBU1hsD/nhFJnw+FlMYF5zQbrbpC8f2MiderLo1VHBTOGpdwNeH+afaWML54nGIP DPjnW2yu7yf6Qr0yohAgmcxDazGyolmWq3kCVoyJ4JM1NU0spzku4ucqQHywLo/QvBo7hOfhbKh xyS43BF2s268Rixaf6YOAYPiEhhXhM9ljCHVOHpguOyomkb0gh518VPG+VN1NqtZbnYnbbH2E8y XTVcILWWxvqV0nUiRGNrbobABwIihPMBRJmlsnrT4f6fawPQ== X-Google-Smtp-Source: AGHT+IFUN+q/8TsKuaj7+2RwyJYVrrwG8fxeKq9daQNiKEoxs69CzZl3tk7HErGDTht4zJ7Z7kHJavyqzod5 X-Received: by 2002:a4a:da56:0:b0:65c:f583:d3e3 with SMTP id 006d021491bc7-65f54f74c3dmr1221562eaf.57.1767817166084; Wed, 07 Jan 2026 12:19:26 -0800 (PST) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-1.dlp.protect.broadcom.com. [144.49.247.1]) by smtp-relay.gmail.com with ESMTPS id 586e51a60fabf-3ffa500ac9dsm662319fac.11.2026.01.07.12.19.25 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 07 Jan 2026 12:19:26 -0800 (PST) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-dy1-f197.google.com with SMTP id 5a478bee46e88-2ae32686ed0so7026556eec.0 for ; Wed, 07 Jan 2026 12:19:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1767817163; x=1768421963; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=z+D0U0I/QMaRvqdVI4kOajEvXFaO+vpLvikp7KFwDvI=; b=UZr7d1vKkUcAkukEM1N9M4comNduYMnEgCcJAn4I0p5FVkYRIX/c8KxqHXhcZGtdT6 uN/+2tvyTg9IuwcWtkjFCJQlAC7pi543KyWmrooSwT8eVLs1XcjN/EZk9S9jpQIIaNED 2a1aHbspEvKJnRg8pfxvbQRHtLTDuge7BhoF8= X-Forwarded-Encrypted: i=1; AJvYcCUMeUbj8UTSZNy585NfFJIgqJuARXTVuO3FVEXxbbxddBwAmqBhONytxHQFn2a4x/urUWgo9+cc1Qu5p3Q=@vger.kernel.org X-Received: by 2002:a05:693c:6085:b0:2ae:5020:afe1 with SMTP id 5a478bee46e88-2b17d2080bdmr2430473eec.14.1767817163229; Wed, 07 Jan 2026 12:19:23 -0800 (PST) X-Received: by 2002:a05:693c:6085:b0:2ae:5020:afe1 with SMTP id 5a478bee46e88-2b17d2080bdmr2430455eec.14.1767817162698; Wed, 07 Jan 2026 12:19:22 -0800 (PST) Received: from [10.66.193.70] ([192.19.161.250]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2b1707d57aasm6888830eec.30.2026.01.07.12.19.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 07 Jan 2026 12:19:22 -0800 (PST) Message-ID: <89115e05-16ac-4520-afbb-b9b2c86bd6a7@broadcom.com> Date: Wed, 7 Jan 2026 12:19:19 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RESEND 1/2] x86/paravirt: Remove trailing semicolons from alternative asm templates To: Uros Bizjak , bcm-kernel-feedback-list@broadcom.com, virtualization@lists.linux.dev, x86@kernel.org, linux-kernel@vger.kernel.org Cc: Juergen Gross , Ajay Kaher , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" References: <20260105093944.52387-1-ubizjak@gmail.com> Content-Language: en-US From: Alexey Makhalov Autocrypt: addr=alexey.makhalov@broadcom.com; keydata= xsFNBGVo9lkBEACeouRIm6Q3QTvjcnPczfBqgLffURstVJz5nqjnrNR4T+8dwNrZB8PTgOWA QdGV4bIyqtNG7UHQuZ7sVKr2tx0gYJyQ5uZgncEHB5YIuhQ/CyAHrVmO+5/0/xWCLI0g44rF ZJqsYw2JQ2+vayTWbR65rkOiKL8GOVFNZanDg80BRh6qCmCEMXd/tymxvgnvWpHtxMgukexk 4vV9nV4XhxRVYdpLk8mBxsh+AEbHE+nbWgIuJDrmrZDGI2Dha7JFoB0Mi6hbbYd9BdkcHKQ7 6c+S1xOrZL3jX7OIFhb4NNnEOhh8/+BDlyby478p6YsimNa7TgAUbrygGyfVG8usrZy8SvO+ vUbVQwqjcJaCK1xazK12dfuZm2kSMJUrJqa9ng6OMjkE2/WrtnK8ruFNSCdytzbuheT0nYUJ Uwy84cU4p2K/N2C4vYjcn+IT+l1BFr5FViKYruoRLVH6zK/WOoZjA+Fc6tdM5nC1pgSB9c7h XLQqDSzYPzk3nqeHWG1qJ0Hu7pscIrjxyNTIZ5le0TlpblJdoRcL5maDNw22yle8m4D18ERF VrqNoqwW8fObMCHbd6C3m75lzerq1HhrSvLyU4UfprEyAcjOI1C0319SXfYlXDjKXRQyaDZP wxln8uShSitSSnx0AsSAjcUa8Cc7km81+G2WSK3S2wVIAN11awARAQABzS5BbGV4ZXkgTWFr aGFsb3YgPGFsZXhleS5tYWtoYWxvdkBicm9hZGNvbS5jb20+wsGNBBMBCAA3FiEEjLzRtST/ a5u42vOKbM7yHr5SJ3cFAmVo9lwFCQ0oaIACGwMECwkIBwUVCAkKCwUWAgMBAAAKCRBszvIe vlInd0jTD/9bZtjehewLRrW3dRDAbLG/+J5g1K4X5qQPfAo42NrhZQlOTibL7ixwq7NSXynZ V4Iu9jHAW++KXjxJzkg7zjBf9OOvvgCpqZGKYgWNvHHnX4eIVh8Ikp5JtvGPMBcRv7lJA5co kb+RHo9iRrB1dvRIOsP1SlGS85SiNA0yvmgqwbigLDmDRSWtvvt9XPwU1iqF+1OopT3UE10i /z+qE2ogcw2ADveBovq2W4JeQEBvlETwDKOdh8Q3UBHOqrZUrL7YjpUxgmb89FcjdDzUU95I fCB5YxF0hUctxFH5Uujh2F4qk0m2rp7+aOGtxWCJUqkHXjgpOoxyn0FPZiZlDkst84NO5OSI 5ZFPwaFqxUrFF+cFCY2O/UE2gpoK9Lt3gYNK6o2WIAtufuiYVdK6lANMkBgZ+t2fDLIN147a 172zu8XnyJMTo+tVfUjxwqynoR/NSWpVPs0Ck3K0LGjQE0tJ6HZrH0vudXk3YaiqW+D4CtGh I17Pk0h6x8LCdjmWmuDXoc99ezOEFSyWuTHjAYxx3cmgSUyIhdHtimuf0CVLTcFoBErb/5pJ zjb11Cj0HP87FMH57bnD3qyfkBMOB6tztfdt3vkCBaWkxaiTGXNhwr4IiLUoi90yIdXDMcTj /gvnjXgN+31iYgPWgTOdUEQud0DwDwuDwkzx/0x4sF1Dfc7BTQRlaPZcARAAuGkoYKWcrCh8 5RffedM6uBZ4p5Z4+RVj05uq7hlAwhHUpLP/XGbgNzhJP375Lonmnuyg2x7oHxfiwOohuuiA MnhSeEXn2qWZJuHosrYxs9y2zyiE/GTUAcqKiYBFa/96zOaZjHpNuQ5qSHYL64WhqvtmCQYg fL+jes2Z4IXl2R7MrN9OE+G3A3pOAo8TZKUEmlUV85fSmgopIX+hCiSQmRNRtp2jK6hd2+38 YAXc+eRxYgXKaWX5zeBgNrfM7Oxeh/0iWRZPWstTvVH2xMlzywOB3e/fqg+Q3NlPGDrTyHoc L86ZELSLcMTFn+RXw8lX8oVjTcQA0M8sQHB5g0JEWtMsFjnQZkJGCfeh0Odbn/F8nZ6LQQtu +fjc/4n9vRun+PZjdhd3W9ZM9D87W9XJg9txIaYnoUXBLLpHK/OirFfr5cJTUf4svtE3EVXb x6P9vr7zqUbE0f76h1eDPmyMwFAuibIXhNoEoKQtEjLX9aKgKYny3hczRiuQpA+6U4oTNn4S /CEqphLPT53aMH0w4x0CebMPozf24ZE9YphdX8ECclLBlDL1/zx2xKrJNw8v6wdXMSfsybBW 98b5b1eVBk1uc1UMlpDl7AIHyCMTjL9Ha85eoya/Hk9l93aVHgK04hOBY2ED1/ZRpj0M5P5m tNX1JqZunpyvKooT1PrJr4UAEQEAAcLBfAQYAQgAJhYhBIy80bUk/2ubuNrzimzO8h6+Uid3 BQJlaPZeBQkNKGiAAhsMAAoJEGzO8h6+Uid3SDoQAI3XXqsehWKvyAVeGXPxmkk+Suos/nJC xZWjp4U2xbbegBnNWladZoNdlVW/WV+FSFsN5IWztxQTWBMI12A0dx+Ooi9PSIANnlN+gQsA 9WeQ5iDNveEHZyK1GmuqZ3M3YZ1r3T2KyzTnPPZQ1B8gMQ442bOBWe077MqtLaC0J1jHyWHU j6BbUCAyR2/OCV/n1bH4wYIm2lgrOd2WuzoAGvju+j2g7hMRxw/xeHeu8S0czHuEZ0dC6fR1 ZKUOw03+mM/xRzL1be6RVS9AF7R5oDd11RrTOb7k14z0inFqSRrRwzOPKcuMxrApcquar336 3FQuLcJLjBo/SAOh2JatOkkwkw5PZseqdwcAk5+wcCbdYy8J8ttR04iV1FzrdQp8HbVxGNo7 AlDn1qtoHzvJHSQG51tbXWfLIi1ek3tpwJWj08+Zo+M47X6B65g7wdrwCiiFfclhXhI1eJNy fqqZgi3rxgu4sc5lmR846emZ/Tx85/nizqWCv7xUBxQwmhRPZRW+37vS2OLpyrTtBj3/tEM9 m9GMmTZqaJFeK7WCpprJV4jNHpWZuNAsQrdK1MrceIxb0/6wYe0xK79lScxms+zs9pGTrO4U 5RoS4gXK65ECcBH8/mumV6oBmLrNxKUrzTczdo9PnkmRyZcAa6AndbjmQDznwxvTZu2LjMPC EuY0 In-Reply-To: <20260105093944.52387-1-ubizjak@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e On 1/5/26 1:39 AM, Uros Bizjak wrote: > GCC inline asm treats semicolons as instruction separators, so a > semicolon after the last instruction is not required. > > Signed-off-by: Uros Bizjak > Reviewed-by: Juergen Gross > Cc: Ajay Kaher > Cc: Alexey Makhalov > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: Borislav Petkov > Cc: Dave Hansen > Cc: "H. Peter Anvin" > --- > arch/x86/include/asm/paravirt.h | 20 ++++++++++---------- > arch/x86/include/asm/paravirt_types.h | 2 +- > 2 files changed, 11 insertions(+), 11 deletions(-) > > diff --git a/arch/x86/include/asm/paravirt.h b/arch/x86/include/asm/paravirt.h > index b5e59a7ba0d0..4f6ec60b4cb3 100644 > --- a/arch/x86/include/asm/paravirt.h > +++ b/arch/x86/include/asm/paravirt.h > @@ -151,7 +151,7 @@ static inline void write_cr0(unsigned long x) > static __always_inline unsigned long read_cr2(void) > { > return PVOP_ALT_CALLEE0(unsigned long, mmu.read_cr2, > - "mov %%cr2, %%rax;", ALT_NOT_XEN); > + "mov %%cr2, %%rax", ALT_NOT_XEN); > } > > static __always_inline void write_cr2(unsigned long x) > @@ -162,7 +162,7 @@ static __always_inline void write_cr2(unsigned long x) > static inline unsigned long __read_cr3(void) > { > return PVOP_ALT_CALL0(unsigned long, mmu.read_cr3, > - "mov %%cr3, %%rax;", ALT_NOT_XEN); > + "mov %%cr3, %%rax", ALT_NOT_XEN); > } > > static inline void write_cr3(unsigned long x) > @@ -560,7 +560,7 @@ static __always_inline void pv_queued_spin_lock_slowpath(struct qspinlock *lock, > static __always_inline void pv_queued_spin_unlock(struct qspinlock *lock) > { > PVOP_ALT_VCALLEE1(lock.queued_spin_unlock, lock, > - "movb $0, (%%" _ASM_ARG1 ");", > + "movb $0, (%%" _ASM_ARG1 ")", > ALT_NOT(X86_FEATURE_PVUNLOCK)); > } > > @@ -577,7 +577,7 @@ static __always_inline void pv_kick(int cpu) > static __always_inline bool pv_vcpu_is_preempted(long cpu) > { > return PVOP_ALT_CALLEE1(bool, lock.vcpu_is_preempted, cpu, > - "xor %%" _ASM_AX ", %%" _ASM_AX ";", > + "xor %%" _ASM_AX ", %%" _ASM_AX, > ALT_NOT(X86_FEATURE_VCPUPREEMPT)); > } > > @@ -657,18 +657,18 @@ bool __raw_callee_save___native_vcpu_is_preempted(long cpu); > #ifdef CONFIG_PARAVIRT_XXL > static __always_inline unsigned long arch_local_save_flags(void) > { > - return PVOP_ALT_CALLEE0(unsigned long, irq.save_fl, "pushf; pop %%rax;", > + return PVOP_ALT_CALLEE0(unsigned long, irq.save_fl, "pushf; pop %%rax", > ALT_NOT_XEN); > } > > static __always_inline void arch_local_irq_disable(void) > { > - PVOP_ALT_VCALLEE0(irq.irq_disable, "cli;", ALT_NOT_XEN); > + PVOP_ALT_VCALLEE0(irq.irq_disable, "cli", ALT_NOT_XEN); > } > > static __always_inline void arch_local_irq_enable(void) > { > - PVOP_ALT_VCALLEE0(irq.irq_enable, "sti;", ALT_NOT_XEN); > + PVOP_ALT_VCALLEE0(irq.irq_enable, "sti", ALT_NOT_XEN); > } > > static __always_inline unsigned long arch_local_irq_save(void) > @@ -713,9 +713,9 @@ void native_pv_lock_init(void) __init; > call PARA_INDIRECT(pv_ops+PV_IRQ_save_fl); > .endm > > -#define SAVE_FLAGS ALTERNATIVE_2 "PARA_IRQ_save_fl;", \ > - "ALT_CALL_INSTR;", ALT_CALL_ALWAYS, \ > - "pushf; pop %rax;", ALT_NOT_XEN > +#define SAVE_FLAGS ALTERNATIVE_2 "PARA_IRQ_save_fl", \ > + "ALT_CALL_INSTR", ALT_CALL_ALWAYS, \ > + "pushf; pop %rax", ALT_NOT_XEN > #endif > #endif /* CONFIG_PARAVIRT_XXL */ > #endif /* CONFIG_X86_64 */ > diff --git a/arch/x86/include/asm/paravirt_types.h b/arch/x86/include/asm/paravirt_types.h > index 3502939415ad..e82dba084198 100644 > --- a/arch/x86/include/asm/paravirt_types.h > +++ b/arch/x86/include/asm/paravirt_types.h > @@ -250,7 +250,7 @@ extern struct paravirt_patch_template pv_ops; > */ > #define PARAVIRT_CALL \ > ANNOTATE_RETPOLINE_SAFE "\n\t" \ > - "call *%[paravirt_opptr];" > + "call *%[paravirt_opptr]" > > /* > * These macros are intended to wrap calls through one of the paravirt Acked-by: Alexey Makhalov