From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753026AbdLDCo4 (ORCPT <rfc822;w@1wt.eu>);
        Sun, 3 Dec 2017 21:44:56 -0500
Received: from mga04.intel.com ([192.55.52.120]:10515 "EHLO mga04.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752821AbdLDCoz (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 3 Dec 2017 21:44:55 -0500
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.45,357,1508828400"; 
   d="scan'208";a="183609387"
Subject: Re: [alsa-devel] [PATCH v4 03/15] soundwire: Add Master registration
To: Vinod Koul <vinod.koul@intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        ALSA <alsa-devel@alsa-project.org>,
        Charles Keepax <ckeepax@opensource.cirrus.com>,
        Sudheer Papothi <spapothi@codeaurora.org>, Takashi <tiwai@suse.de>,
        plai@codeaurora.org, LKML <linux-kernel@vger.kernel.org>,
        patches.audio@intel.com, Mark <broonie@kernel.org>,
        srinivas.kandagatla@linaro.org, Sagar Dharia <sdharia@codeaurora.org>,
        alan@linux.intel.com
References: <1512122177-2889-1-git-send-email-vinod.koul@intel.com>
 <1512122177-2889-4-git-send-email-vinod.koul@intel.com>
 <435d9db4-eb3c-f4b4-d978-e5d10b921f71@linux.intel.com>
 <20171203164119.GL32417@localhost>
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Message-ID: <8920a633-4635-afbb-18c4-2a826facd2eb@linux.intel.com>
Date: Sun, 3 Dec 2017 20:44:58 -0600
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:52.0)
 Gecko/20100101 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <20171203164119.GL32417@localhost>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


>>> +/* SDW Enumeration Device Number */
>>> +#define SDW_ENUM_DEV_NUM		0
>>
>> add
>> SDW_GROUP12_DEV_NUM		12
>> SDW_GROUP12_DEV_NUM		13
> 
> you mean SDW_GROUP13_DEV_NUM :D
> 
>> SDW_MASTER_DEV_NUM		14 /* not supported in these patches */
> 
> These dont help now as we dont support, so kind of dead code.
> Lets add them when we really support it

It was a way to explain why device 14 is never allocated.