From: Youling Tang <youling.tang@linux.dev>
To: Markus Elfring <Markus.Elfring@web.de>,
Kent Overstreet <kent.overstreet@linux.dev>,
Youling Tang <tangyouling@kylinos.cn>,
linux-bcachefs@vger.kernel.org
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: Re: bcachefs: Fix error path of bch2_link_trans()
Date: Tue, 30 Apr 2024 17:29:54 +0800 [thread overview]
Message-ID: <89354794-c53a-4935-a961-818710ba2fd3@linux.dev> (raw)
In-Reply-To: <7d4a29a1-26d2-4b22-8823-ce8e7f9ac534@web.de>
Hi, Kent
On 30/04/2024 17:18, Markus Elfring wrote:
>>> In bch2_link_trans(), if bch2_inode_nlink_inc() fails, it needs to
>>> call bch2_trans_iter_exit() in the error path.
>> Thanks - applied.
> https://evilpiepirate.org/git/bcachefs.git/commit/?id=d04db1c7653dee5ee5f918ce951c05eefddad7eb
>
> Would it have been nice to add the tag “Fixes” (besides an imperative wording) accordingly?
The following labels can be added:
Fixes: 962ad1a7666 ("bcachefs: Don't BUG_ON() inode link count underflow")
Thanks,
Youling.
next prev parent reply other threads:[~2024-04-30 9:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-30 3:28 [PATCH] bcachefs: Fix error path of bch2_link_trans() Youling Tang
2024-04-30 3:31 ` Kent Overstreet
2024-04-30 9:18 ` Markus Elfring
2024-04-30 9:29 ` Youling Tang [this message]
2024-04-30 10:55 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89354794-c53a-4935-a961-818710ba2fd3@linux.dev \
--to=youling.tang@linux.dev \
--cc=Markus.Elfring@web.de \
--cc=kent.overstreet@linux.dev \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-bcachefs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tangyouling@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox