From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A96ED30C364 for ; Wed, 12 Nov 2025 11:28:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762946891; cv=none; b=e9379rvxGmcWK7SSz/xY7A0by4FBme8zyc+5vNGLAS1HW3v2charCGAGj9WuAPc1zO2YOmP2PiP+StjSuKECvt1pe30PBF8Idi5CmqkfVPz4FdG+Pc6OuokO5Y91cn0LshI85tbUQC/1iWxDBi0qMMdbI/Kcc9jeKBRie+T3XEs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762946891; c=relaxed/simple; bh=3yZy0mK7fi7h6dEgV7OqbQEEpOmuSBi+BOgpbLpu8Xo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=dChLA3tP54STOHI+HuEsv9GonQRAaVoBDIt9DYTHvOcqAqaGymYwRG6966GqJ65iMnwrdoiAGVDCmycyfRm3hqfhib0dyHMd0SvnOU4ehPHHQrPba7rkPcfnusVGb3/d9OH/VkmPndBuXVGsiyw1t8DyBYpRE7CAhejP1yqHtuk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=InzW8DU0; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="InzW8DU0" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-4775ae5684fso3529895e9.1 for ; Wed, 12 Nov 2025 03:28:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1762946888; x=1763551688; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=mmJ4jMrcViTktpRfcYtKz9oOeK7QX8lRd9IhgtDkEoo=; b=InzW8DU0QLvbnIx8lXgh/SZICb/2z8/shpDpoGlryNAdfLGQzNTchwxoIYyC9Eg+j8 pk3+L/VUHgj8uz038kRnt/S0jKoE9PxNvpMegevwR52xijYY1ugkbo+s6uGygHrGgGSR wKWBa+o4JUqPOyk7MqM67EHj7Oxa1vDTF64X63A2sJkybiQ9lzRbx902Lyq7NUdZMa1r MK35WZ3ur901ELRLoepo+yDIatToXYLansuulph6pPIxm2R0dZ5n2c3e6F7vbQzlu30D j8Q+ZXSl226LpaNjVLkaf5e/Ao/p5F3Siup7e5KZseh/3MM5t6jnDOUg4KVOARtDWSji HueQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762946888; x=1763551688; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=mmJ4jMrcViTktpRfcYtKz9oOeK7QX8lRd9IhgtDkEoo=; b=TErzC/7/3A9ab8gbKmM04ecCURLMAvBBBqoZppKXAXoZbSeGClD/2MnEz+Vl6+ai8Z JPcC7PbPboVeHqkcbv3O9+b0mtB8KtIzDyxIIstXXN2APW9Qb8BKm9aLrFk6NBnXOoQp 01YcVeJ3/A1cllkOJqLYHiTRPJvc3Xek/xVvEJ3PItgfl9MmbG0Stje8KinQFQs9xcWz 7/enNSozCgOJHAxmR6E+iu0bSUtStl9YCAvHUnEhglRwX9qRJ+IZVNGzdGDXtMqYmjsG osTCyrvcfaKyoe/OZ9giclmi0l3HBUK1p1rGdUiPJ5mN8rqsvUZEYU1ZbYkVAfbM8m/W QUBQ== X-Forwarded-Encrypted: i=1; AJvYcCU8Z2x4OMUBlgqJI/z8EZtjuP5+qKLWcIr2rRoqOcvCc1aEOd5ltgA1bz8D3IPEoHtAttMl8RTjEU1ZflY=@vger.kernel.org X-Gm-Message-State: AOJu0YzjMb+R86Vkkzetql1CRTSByFE4K4DN/T0I5dl1iaZuwgAG7SF/ z/wIEcgiPuTj+lJ/OoN8F1T2FYPOZAvkaN4tmYjo6ccu/h7mhGELNSJ5 X-Gm-Gg: ASbGnctKKIO0B/XuYX1JoCd0mJJLZoIwCbewPgMjHsL0vxx0oWT2Ii7H/63Qg6qNyOv Hec/D+5KQ/E1CSVwC2R+bnsbyjVeRl37nKK67jyYTQxU4XfJEtbEOsDXyhOcwpDpYhCo24abFXn mgbMSIniMXWcyRauugKnMXffvbKHFcXof9pZq7kUo3XIqE4burJBA58lNm0xLjDTg5btR+VDhXY GvMUV1zLMCkNKVnVT7hGuaE1dGoPc+Las3lWgyc3Xv/yY+ydjIa3WzughR+dgEBgcAjfAsTc9c9 d/UAXw+pQMOAdPAkttOl79TZ6HTcCQ/h/XdDPYb5IwpBI9lAFan0VXGi1XZU5VzTFxOGfa+nSbz WAGDaIqLRuvpUhn3GiSNQ1ZDGQbBQMYTHXbXaWfEIxxvQRH98Er4k4+4UxRsOnoZWdTr91XT5h+ kD08bxaj8+DpA/e0oWYseKt/w= X-Google-Smtp-Source: AGHT+IHUkDj9skJWx5O8Mgj0/LeNZAj9+4nbV8r5lwtFtUHPHAFFww+gS/qpBq+lZu7XXIyqqV4v1w== X-Received: by 2002:a05:600c:4fd3:b0:46e:37a7:48d1 with SMTP id 5b1f17b1804b1-477871c588emr26721795e9.34.1762946887589; Wed, 12 Nov 2025 03:28:07 -0800 (PST) Received: from [10.125.200.88] ([165.85.126.46]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47787ea39ccsm29171795e9.15.2025.11.12.03.28.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Nov 2025 03:28:07 -0800 (PST) Message-ID: <893e8d23-121b-43ef-90a9-370a745d4341@gmail.com> Date: Wed, 12 Nov 2025 13:28:05 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next 6/6] net/mlx5e: Support XDP target xmit with dummy program To: =?UTF-8?Q?Toke_H=C3=B8iland-J=C3=B8rgensen?= , Tariq Toukan , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , "David S. Miller" Cc: Saeed Mahameed , Leon Romanovsky , Mark Bloch , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , netdev@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, Gal Pressman , Leon Romanovsky , Moshe Shemesh , William Tu , Dragos Tatulea , Nimrod Oren , Alex Lazar References: <1762939749-1165658-1-git-send-email-tariqt@nvidia.com> <1762939749-1165658-7-git-send-email-tariqt@nvidia.com> <877bvvlf19.fsf@toke.dk> Content-Language: en-US From: Tariq Toukan In-Reply-To: <877bvvlf19.fsf@toke.dk> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 12/11/2025 12:29, Toke Høiland-Jørgensen wrote: > Tariq Toukan writes: > >> Save per-channel resources in default. >> >> As no better API exist, make the XDP-redirect-target SQ available by >> loading a dummy XDP program. > > This is a user-visible change, though, no? I.e., after this patch > xdp_redirect mlx5 devices will no longer work as an xdp_redirect target > out of the box? > Right, we introduce an explicit behavior change here. Due to the lack of a standard control, we're aligning to other drivers and use the dummy program trick. Having the feature always on by default wastes HW and SW resources for users who are not interested in the feature (and cannot explicitly disable it), in addition to the significant extra latency it adds in configuration flow. > We have userspace code listing the driver support in various places > (e.g., here in xdp-tools: > https://github.com/xdp-project/xdp-tools/commit/1dad1d6e0ccb086b8a31496931f21a165b42b700); > I'm sure there will be other places. Since such code would up until now > assume that mlx5 just works, this will end up being a regression in such > cases, no? > > -Toke > > Yes, it is indeed a change in behavior. Now the feature can be turned off, and actually defaults to off. Now we should add "mlx5" to this list driver_pass_list[].