From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f52.google.com (mail-io1-f52.google.com [209.85.166.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 56F8C17BB2B for ; Tue, 10 Sep 2024 19:21:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725996097; cv=none; b=EvSmKieKncV56qvT9k4Z0/Djvufxwz4jDGrteqqNUrPKLlqxcXSxQz6M4HX5t93CyxDMT614ZLjBLGvLBfHpa0dLIYspgvxG4vQq3yX7OvUp4tM2AUuFMGmODuK0Gg219HOk9m1VnREdnC9tTBo9m1MzgS2u/lZU1WaTj7wN0lo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725996097; c=relaxed/simple; bh=o+isGT375rznUuyCnHiY488KhfVAUOC/5n5RbwrhNYM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=tcNyLTZzji0w3xV/4bpXyYeIeFiDHBfeNgk/HrMxWIAnkTtxWH44TGn9McMsJCYK8LOF3V10/iJAZzSsIRVKqmBeZleXOlYyFNca2Cr7CfEs5dQ6uM+l7pt99u7sSvTHFMTv9cvbXevPq/B9VlXRJuiQlXJRGWYsh2mzF7eHy5o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b=0rmjrA50; arc=none smtp.client-ip=209.85.166.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="0rmjrA50" Received: by mail-io1-f52.google.com with SMTP id ca18e2360f4ac-82ade877fbeso163218839f.0 for ; Tue, 10 Sep 2024 12:21:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1725996094; x=1726600894; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=mOWZEzCzgSPVAG028VLnVxHUP1ia+npqcWvvmw8LBvU=; b=0rmjrA50jFm6i8BEBLENQfoG6dgDxxZDFAbMwcVpkFemZRPDyeVK5ejVC9WzULeZ39 W6FLK2mB07y19E7jw8+OEVrDT4AyJSBSjY0sgGKEv5YAZKtAX59P6DKv822zFL1tYY3D fwzS2qUOnsJi4uHjpKTZuBEbo5b5B4umHjcElrZTEYojLGFSffifYH5z1GyTE4k7PbIF GBH6SvKoYyoHmF/s7xt0U4KKBd1RNqHrv5dT56KxsSFGWwRXh5fSH16SFq3M+HsXVHfm 4vd49dSvtK+vL43EEB/F3B15v2hkKGJhX4Oiik6KinCACGvVaaQjnGRhNaaIg4nI5grh oP9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725996094; x=1726600894; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mOWZEzCzgSPVAG028VLnVxHUP1ia+npqcWvvmw8LBvU=; b=Yu+tD6L1VpjDDxo0MLFywk84RZzM71DZZnivWKSbEweeekm0o6KigP/2Cp4yjpbYpf HUAhrXmCPDlP0HEkLVk+I/VioyPOk6RqZTe5aKxloYzT5B9ALGtyC7tnSsWrE6JL6rRY haWCzROJhiiryGUkX8LfU44qruz0gPVLc88lAxLmV4LCf753UQ8TWItpEZ2OWQQKP5va 7unp9J1lt2uTjNXjGvGWtL3ZBHAVtGg2BqxthhvoEh8FelURkgq6ukx3PkNMgCF5MVud gvLSeJhvfK/zFPxjAy40S/mHnm70w9MeGyBBsKnzKovN+uncWr+wxL0eVT/GQ+kxhOBA E8mA== X-Forwarded-Encrypted: i=1; AJvYcCWvFIpItiYhIxDyEf5ntiiZWR+cW7TTYhSG8qzoCf4rDrz3xg+Irr0wFRKo8NDVS5G5L6EDkJMtBua0kDU=@vger.kernel.org X-Gm-Message-State: AOJu0Yzimm+UpflU0mt3wyqS/e1pcAUnbKhq5LvLmCRYGWlHclHri3Ph FIgz8vpyJV6ynXc6Qbj1n716DBk0n0ciHzs/FhjQ523rkjUrv6gL4Idk8XN6bHY= X-Google-Smtp-Source: AGHT+IGx3wAHFaAGfb07EAu2FYC+9BjFVSNQk48DQLYU5QsBhA7VsAXe5CVDKV3R7lfPiN1V9lLjRg== X-Received: by 2002:a05:6602:6d84:b0:82c:fd75:813a with SMTP id ca18e2360f4ac-82cfd75832dmr363399439f.1.1725996094348; Tue, 10 Sep 2024 12:21:34 -0700 (PDT) Received: from [192.168.1.116] ([96.43.243.2]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4d09451dba8sm1766258173.16.2024.09.10.12.21.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Sep 2024 12:21:33 -0700 (PDT) Message-ID: <894a9361-d232-41c5-8090-89fd61fadb28@kernel.dk> Date: Tue, 10 Sep 2024 13:21:32 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Regression v6.11 booting cannot mount harddisks (xfs) To: Jesper Dangaard Brouer , Damien Le Moal , Linus Torvalds , LKML , Christoph Hellwig Cc: Netdev , linux-ide@vger.kernel.org, cassel@kernel.org, handan.babu@oracle.com, djwong@kernel.org, Linux-XFS , hdegoede@redhat.com, "David S. Miller" , Jakub Kicinski , kernel-team References: <0a43155c-b56d-4f85-bb46-dce2a4e5af59@kernel.org> <7fedb8c2-931f-406b-b46e-83bf3f452136@kernel.org> <0ad933b9-9df5-4acc-aa72-d291aa7d7f4d@kernel.org> Content-Language: en-US From: Jens Axboe In-Reply-To: <0ad933b9-9df5-4acc-aa72-d291aa7d7f4d@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 9/10/24 1:19 PM, Jesper Dangaard Brouer wrote: > > > On 10/09/2024 20.38, Jens Axboe wrote: >> On 9/10/24 11:53 AM, Jesper Dangaard Brouer wrote: >>> Hi Hellwig, >>> >>> I bisected my boot problem down to this commit: >>> >>> $ git bisect good >>> af2814149883e2c1851866ea2afcd8eadc040f79 is the first bad commit >>> commit af2814149883e2c1851866ea2afcd8eadc040f79 >>> Author: Christoph Hellwig >>> Date: Mon Jun 17 08:04:38 2024 +0200 >>> >>> block: freeze the queue in queue_attr_store >>> >>> queue_attr_store updates attributes used to control generating I/O, and >>> can cause malformed bios if changed with I/O in flight. Freeze the queue >>> in common code instead of adding it to almost every attribute. >>> >>> Signed-off-by: Christoph Hellwig >>> Reviewed-by: Bart Van Assche >>> Reviewed-by: Damien Le Moal >>> Reviewed-by: Hannes Reinecke >>> Reviewed-by: Chaitanya Kulkarni >>> Link: https://lore.kernel.org/r/20240617060532.127975-12-hch@lst.de >>> Signed-off-by: Jens Axboe >>> >>> block/blk-mq.c | 5 +++-- >>> block/blk-sysfs.c | 9 ++------- >>> 2 files changed, 5 insertions(+), 9 deletions(-) >>> >>> git describe --contains af2814149883e2c1851866ea2afcd8eadc040f79 >>> v6.11-rc1~80^2~66^2~15 >> >> Curious, does your init scripts attempt to load a modular scheduler >> for your root drive? > > I have no idea, this is just a standard Fedora 40. > >> >> Reference: https://git.kernel.dk/cgit/linux/commit/?h=for-6.12/block&id=3c031b721c0ee1d6237719a6a9d7487ef757487b > > The commit doesn't apply cleanly on top of af2814149883e2c185. > > $ patch --dry-run -p1 < ../block-jens/block-jens-bootfix.patch > checking file block/blk-sysfs.c > Hunk #1 FAILED at 23. > Hunk #2 succeeded at 469 (offset 56 lines). > Hunk #3 succeeded at 484 (offset 56 lines). > Hunk #4 succeeded at 723 with fuzz 1 (offset 45 lines). > 1 out of 4 hunks FAILED > checking file block/elevator.c > Hunk #1 FAILED at 698. > 1 out of 1 hunk FAILED > checking file block/elevator.h > Hunk #1 FAILED at 148. > 1 out of 1 hunk FAILED > > I will try to apply and adjust manually. Just apply it on top of current -git, doesn't have to be your bisection point. -- Jens Axboe