public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Segher Boessenkool <segher@kernel.crashing.org>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Muli Ben-Yehuda <muli@il.ibm.com>,
	Linux kernel mailing list <linux-kernel@vger.kernel.org>,
	"Robert P. J. Day" <rpjday@mindspring.com>,
	trivial@kernel.org
Subject: Re: [PATCH] Documentation: Explain a second alternative for multi-line macros.
Date: Mon, 1 Jan 2007 05:31:32 +0100	[thread overview]
Message-ID: <8952abefff5a73bf24a0c80936fe7091@kernel.crashing.org> (raw)
In-Reply-To: <45987EB0.1020505@oracle.com>

>>>   #define setcc(cc) ({ \
>>>     partial_status &= ~(SW_C0|SW_C1|SW_C2|SW_C3); \
>>>     partial_status |= (cc) & (SW_C0|SW_C1|SW_C2|SW_C3); })
>> This _does_ return a value though, bad example.
>
> Where does it return a value?

partial_status |=

> I don't see any uses of it

Ah, that's a separate thing -- it returns a value, it's just
never used.

> And with a small change to put it inside a do-while block
> instead of ({ ... }), it at least builds cleanly.

Well please replace it then, statement expressions should be
avoided where possible (to start with, they don't have well-
defined semantics).


Segher


  reply	other threads:[~2007-01-01  4:31 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-31 19:32 [PATCH] Documentation: Explain a second alternative for multi-line macros Robert P. J. Day
2006-12-31 19:45 ` Muli Ben-Yehuda
2006-12-31 19:49   ` Robert P. J. Day
2006-12-31 20:09     ` Muli Ben-Yehuda
2006-12-31 20:03       ` Randy Dunlap
2006-12-31 20:13       ` Robert P. J. Day
2007-01-01  2:40     ` Segher Boessenkool
2007-01-01  3:23       ` Randy Dunlap
2007-01-01  4:31         ` Segher Boessenkool [this message]
2007-01-01  4:30           ` Randy Dunlap
2007-01-01 15:37         ` Jan Engelhardt
2007-01-01 17:51           ` Segher Boessenkool
2007-01-01 19:11             ` Jan Engelhardt
2007-01-01  8:26       ` Robert P. J. Day
2007-01-01 14:20 ` Christoph Hellwig
2007-01-01 14:25   ` Robert P. J. Day
2007-01-01 16:14     ` Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8952abefff5a73bf24a0c80936fe7091@kernel.crashing.org \
    --to=segher@kernel.crashing.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=muli@il.ibm.com \
    --cc=randy.dunlap@oracle.com \
    --cc=rpjday@mindspring.com \
    --cc=trivial@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox