public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Diederik de Haas <didi.debian@cknow.org>
To: linux-i2c@vger.kernel.org, Jean Delvare <jdelvare@suse.de>
Cc: "Сергей Фёдоров" <serfyod0vr@yandex.ru>,
	linux-kernel@vger.kernel.org, "Wolfram Sang" <wsa@kernel.org>
Subject: Re: Systems with more than 4 memory slots not supported yet, not instantiating SPD
Date: Thu, 19 May 2022 19:20:45 +0200	[thread overview]
Message-ID: <8957561.CDJkKcVGEf@bagend> (raw)
In-Reply-To: <3837611652787835@vla1-3991b5027d7d.qloud-c.yandex.net>

[-- Attachment #1: Type: text/plain, Size: 2416 bytes --]

On Tuesday, 17 May 2022 13:43:55 CEST Сергей Фёдоров wrote:
> On the advice of Diederik de Haas (didi.debian@cknow.org ) on May 16 at
> 22:41 I am sending you my message in
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1001286

That bug report and https://bugs.debian.org/1001286 do contain the full
history, but it looks like the most interesting/actionable part of that
conversation wasn't shared with upstream.

I have no specific knowledge about this issue, but will try to summarize it.

/var/log/kern.log
[    1.341085] i801_smbus 0000:00:1f.3: SMBus using PCI interrupt
[    1.341467] i2c i2c-0: 8/8 memory slots populated (from DMI)
[    1.341470] i2c i2c-0: Systems with more than 4 memory slots not supported yet, not instantiating SPD

On Monday, 16 May 2022 20:55:20 CEST Сергей Фёдоров wrote:
> 1. Systems with more than 4 memory slots not supported yet, not
> instantiating SPD. Now I have made it so that the system sees 8 slots, as
> described below, but I do not see SPD.
> 
> 2. Kingston memory slots do not appear on the I2C bus, although I see them
> in the BIOS and can change their parameters. Nevertheless, Linux works
> fine.

> I rebuilt the kernel by changing to
> "./linux-source-5.17.6-1/drivers/i2c/i2c-smbus.c"
> 
> line 358:
>         if (slot_count > 4) {
>                 dev_warn(&adap->dev,
>                          "Systems with more than 4 memory slots not
> supported yet, not instantiating SPD\n"); return;
>         }
>
> and replace with
>
>         if (slot_count > 8) {
>                 dev_warn(&adap->dev,
>                          "Systems with more than 8 memory slots not
> supported yet, not instantiating SPD\n"); return;
>         }

To which I responded:

The 4 slot limit was specified in 5ace60859e84113b7a185c117fbf2c429d381b59
(upstream commit ID) and the secondary commit message had this:
"Start with just DDR2, DDR3 and DDR4 on x86 for now, and only for systems with
no more than 4 memory slots. These limitations may be lifted later."

That commit by Jean Delvare was from ~2 years ago and it appears that there
may now be a reason to lift/change that limit of 4 (to 8)

As such a change should be discussed (and possibly implemented) upstream,
I asked to forward the request there/here.

Hopefully you now do have the needed information.

Cheers,
  Diederik

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

      parent reply	other threads:[~2022-05-19 17:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <3837611652787835@vla1-3991b5027d7d.qloud-c.yandex.net>
2022-05-17 12:03 ` Systems with more than 4 memory slots not supported yet, not instantiating SPD Сергей Фёдоров
2022-05-19 17:20 ` Diederik de Haas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8957561.CDJkKcVGEf@bagend \
    --to=didi.debian@cknow.org \
    --cc=jdelvare@suse.de \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=serfyod0vr@yandex.ru \
    --cc=wsa@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox