From: Krzysztof Kozlowski <krzk@kernel.org>
To: Rakesh Kota <rakesh.kota@oss.qualcomm.com>,
Bryan O'Donoghue <bod@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Wesley Cheng <quic_wcheng@quicinc.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, jishnu.prakash@oss.qualcomm.com,
kamal.wadhwa@oss.qualcomm.com
Subject: Re: [PATCH v3 4/4] arm64: dts: qcom: Fix pm4125 vbus regulator compatible and constraints
Date: Tue, 7 Jul 2026 10:38:16 +0200 [thread overview]
Message-ID: <896a5d8e-e054-46e4-bb38-c943c916b857@kernel.org> (raw)
In-Reply-To: <20260707083319.rwtnt4l6so3kdduo@hu-kotarake-hyd.qualcomm.com>
On 07/07/2026 10:33, Rakesh Kota wrote:
> On Mon, Jul 06, 2026 at 02:49:33PM +0100, Bryan O'Donoghue wrote:
>> On 06/07/2026 13:31, Rakesh Kota wrote:
>>> Remove pm8150b fallback compatible from pm4125_vbus and fix regulator
>>> constraints in qrb2210 DTS files to use microvolt instead of
>>> microamp.
>>>
>>> Signed-off-by: Rakesh Kota <rakesh.kota@oss.qualcomm.com>
>> You should break this patch up at the "and"
>>
>> One to remove the fallabck, one to fixup your regulator stuff.
>>
> I understand the preference for splitting at the "and", however
> splitting this patch is not straightforward in this case. The PM4125
Yes. This is one logical change - fix the node to properly match
hardware and bindings. The compatible is tied to properties
(constraints). Splitting the patch would mean you want to keep old
compatible with new constraints which would be wrong.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-07-07 8:38 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-06 12:31 [PATCH v3 0/4] regulator: qcom_usb_vbus: add pm4125 VBUS regulator support Rakesh Kota
2026-07-06 12:31 ` [PATCH v3 1/4] dt-bindings: regulator: qcom,usb-vbus-regulator: add qcom,pm4125-vbus-reg Rakesh Kota
2026-07-06 17:24 ` Mark Brown
2026-07-06 12:31 ` [PATCH v3 2/4] regulator: qcom_usb_vbus: add register abstraction and PM8150B support Rakesh Kota
2026-07-06 13:45 ` Bryan O'Donoghue
2026-07-06 13:46 ` Mark Brown
2026-07-06 14:29 ` Dmitry Baryshkov
2026-07-06 12:31 ` [PATCH v3 3/4] regulator: qcom_usb_vbus: add support for qcom,pm4125-vbus-reg Rakesh Kota
2026-07-06 13:48 ` Bryan O'Donoghue
2026-07-06 14:29 ` Dmitry Baryshkov
2026-07-06 15:31 ` Konrad Dybcio
2026-07-06 12:31 ` [PATCH v3 4/4] arm64: dts: qcom: Fix pm4125 vbus regulator compatible and constraints Rakesh Kota
2026-07-06 13:08 ` Konrad Dybcio
2026-07-06 13:49 ` Bryan O'Donoghue
2026-07-07 8:33 ` Rakesh Kota
2026-07-07 8:38 ` Krzysztof Kozlowski [this message]
2026-07-07 9:25 ` Konrad Dybcio
2026-07-07 9:30 ` Bryan O'Donoghue
2026-07-06 14:30 ` Dmitry Baryshkov
2026-07-07 14:03 ` Krzysztof Kozlowski
2026-07-06 22:35 ` (subset) [PATCH v3 0/4] regulator: qcom_usb_vbus: add pm4125 VBUS regulator support Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=896a5d8e-e054-46e4-bb38-c943c916b857@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=bod@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jishnu.prakash@oss.qualcomm.com \
--cc=kamal.wadhwa@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_wcheng@quicinc.com \
--cc=rakesh.kota@oss.qualcomm.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox