From: Bean Huo <beanhuo@iokpp.de>
To: Hongjie Fang <hongjiefang@asrmicro.com>,
alim.akhtar@samsung.com, avri.altman@wdc.com,
bvanassche@acm.org, James.Bottomley@HansenPartnership.com,
martin.petersen@oracle.com
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5] scsi: ufs: core: call hibern8 notify when hibern8 cmd failed
Date: Tue, 05 May 2026 08:40:55 +0200 [thread overview]
Message-ID: <897db8bf4c82af97cd7bbb2b908bb9e2654b3103.camel@iokpp.de> (raw)
In-Reply-To: <20260502143012.2859480-1-hongjiefang@asrmicro.com>
On Sat, 2026-05-02 at 22:30 +0800, Hongjie Fang wrote:
> + default:
> + break;
> }
>
> return 0;
> diff --git a/include/ufs/ufshcd.h b/include/ufs/ufshcd.h
> index 8563b6648976..4f7c619db324 100644
> --- a/include/ufs/ufshcd.h
> +++ b/include/ufs/ufshcd.h
> @@ -270,6 +270,7 @@ struct ufs_clk_info {
> enum ufs_notify_change_status {
> PRE_CHANGE,
> POST_CHANGE,
> + ROLLBACK_CHANGE,
> };
>
> struct ufs_pa_layer_attr {
> --
> 2.25.1
Could you include the platform driver that actually handles ROLLBACK_CHANGE in
this series? Adding this new rollback_change without an usage makes it hard to
verify the design is correct.
Kind regards,
Bean
next prev parent reply other threads:[~2026-05-05 6:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-02 14:30 [PATCH v5] scsi: ufs: core: call hibern8 notify when hibern8 cmd failed Hongjie Fang
2026-05-04 2:30 ` Bart Van Assche
2026-05-05 6:40 ` Bean Huo [this message]
2026-05-06 3:29 ` Fang Hongjie(方洪杰)
2026-05-06 8:47 ` Bean Huo
2026-05-06 9:16 ` Bart Van Assche
2026-05-06 12:43 ` Bean Huo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=897db8bf4c82af97cd7bbb2b908bb9e2654b3103.camel@iokpp.de \
--to=beanhuo@iokpp.de \
--cc=James.Bottomley@HansenPartnership.com \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=bvanassche@acm.org \
--cc=hongjiefang@asrmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox