From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33C7CC54EBD for ; Fri, 13 Jan 2023 17:49:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230003AbjAMRtm (ORCPT ); Fri, 13 Jan 2023 12:49:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59814 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230202AbjAMRs6 (ORCPT ); Fri, 13 Jan 2023 12:48:58 -0500 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 3D8278B524; Fri, 13 Jan 2023 09:40:48 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DE592FEC; Fri, 13 Jan 2023 09:41:29 -0800 (PST) Received: from [10.57.76.81] (unknown [10.57.76.81]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D5B9B3F67D; Fri, 13 Jan 2023 09:40:44 -0800 (PST) Message-ID: <8984a6ee-9066-bd2e-761f-96a8dd7875b6@arm.com> Date: Fri, 13 Jan 2023 17:40:38 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v7 24/25] PCI: bt1: Set 64-bit DMA-mask Content-Language: en-GB To: Lorenzo Pieralisi , Serge Semin Cc: Gustavo Pimentel , Vinod Koul , Rob Herring , Bjorn Helgaas , Lorenzo Pieralisi , Cai Huoqing , Jingoo Han , Frank Li , Manivannan Sadhasivam , =?UTF-8?Q?Krzysztof_Wilczy=c5=84ski?= , Serge Semin , Alexey Malahov , Pavel Parkhomenko , caihuoqing , Yoshihiro Shimoda , linux-pci@vger.kernel.org, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221214235305.31744-1-Sergey.Semin@baikalelectronics.ru> <20221214235305.31744-25-Sergey.Semin@baikalelectronics.ru> From: Robin Murphy In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023-01-13 12:04, Lorenzo Pieralisi wrote: > On Thu, Dec 15, 2022 at 02:53:04AM +0300, Serge Semin wrote: >> The DW PCIe RC IP-core is synthesized with the 64-bits AXI address bus. >> Since the device is also equipped with the eDMA engine we need to >> explicitly set the device DMA-mask so the DMA-engine clients would be able >> to allocate the data buffers from the DMA-able memory space. >> >> Signed-off-by: Serge Semin >> >> --- >> >> Changelog v7: >> - This is a new patch added on v7 stage of the series. (@Robin) >> --- >> drivers/pci/controller/dwc/pcie-bt1.c | 4 ++++ >> 1 file changed, 4 insertions(+) > > Hi Robin, > > are you OK with this change ? I think that's the last (PCI) bit we > need to take the series. Yup, having gone and double-checked the context this seems fine too - I've slightly lost track of all the circles we've been round in by now, but it looks like the way things all end up after v8 (and now v9) should be uncontentious. Thanks, Robin. > > Thanks, > Lorenzo > >> diff --git a/drivers/pci/controller/dwc/pcie-bt1.c b/drivers/pci/controller/dwc/pcie-bt1.c >> index 8b6c7d544d9a..04aa58348aa5 100644 >> --- a/drivers/pci/controller/dwc/pcie-bt1.c >> +++ b/drivers/pci/controller/dwc/pcie-bt1.c >> @@ -583,6 +583,10 @@ static int bt1_pcie_add_port(struct bt1_pcie *btpci) >> struct device *dev = &btpci->pdev->dev; >> int ret; >> >> + ret = dma_set_mask_and_coherent(dev, DMA_BIT_MASK(64)); >> + if (ret) >> + return ret; >> + >> btpci->dw.version = DW_PCIE_VER_460A; >> btpci->dw.dev = dev; >> btpci->dw.ops = &bt1_pcie_ops; >> -- >> 2.38.1 >> >>