From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4AA44381AFF for ; Fri, 8 May 2026 10:24:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778235843; cv=none; b=BdhMpUR6fbpaI5a9ZKFtLRIzOnO+y+qy907Ip/Sw58ihemiybI9zoNmWUidAgPpOZJ8zlJS+Z93axIi0d9SGzpz/5whMnlxd1noxD1C6Bwkf/D7+eSWGyFM0sss/YvMZ6qolqGeyhGc3QU5rBXgt+ApxEL0Y+7ZHjANFBdPed+M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778235843; c=relaxed/simple; bh=V0S77WuEXUDfU2urKVEn7xkQzr0Ul1uEZMmvaVqcTQg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=CijZfDs3tZ6VSrl/7GIi20lOEA6SeaOggebspmIZFAIw9xPavfp8y3VvpmcB1sq7SBFY2VHtT4JRUQrtY9sSGkOFkMkpN35ZxCvhNSkgRgvyCeIZE7fnV0GSV2PBt8b7I2fIKSXXeBV8eKzS7ikgobLi2CvM+Vt5elht6zdPzBo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=G+jCa/sp; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=YGCrnwNc; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="G+jCa/sp"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="YGCrnwNc" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778235841; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/aqqvi31nG0cLuop8j70SGka90++tg12ySoiLhybgfc=; b=G+jCa/spgfaLDIeOPGn7qTbcG/YcVZIw7JTQfgSRhg9/fGeXk2S3MgPatZyquRVPzZA+5T AAw+OAAWt+ewSq0ZkyqYATufv7QE1VQ2uHse31aTX/PVNcydxleZZznQJyyPWGyYAtTbxo YfcleAg++UbEItzhIPO7yII1KXirnrw= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-520-kaPptT_nP0iTgjAgNUpwwQ-1; Fri, 08 May 2026 06:23:59 -0400 X-MC-Unique: kaPptT_nP0iTgjAgNUpwwQ-1 X-Mimecast-MFC-AGG-ID: kaPptT_nP0iTgjAgNUpwwQ_1778235838 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-44ffa15dc8cso1191675f8f.1 for ; Fri, 08 May 2026 03:23:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1778235838; x=1778840638; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/aqqvi31nG0cLuop8j70SGka90++tg12ySoiLhybgfc=; b=YGCrnwNcQIPLkUNcDxDOxd0wZHQrifVbPtJPvQDYo+TQ3p4A6/WdKkDroLrpjfYja5 cfAZk9BEFFUHQJFA4ozw/buMMtYYi+ZmUd2YPmnFwl0wdh0WENUFoqXFHb9iSZimubmv RRcXj6mvFupUmfee0Y4jHElvxD2teulnwZdtYKVy+27qng8qkEHC33vydROApOCcYsis RTecjwJ666wsrf9Yo/9nuXHzh+KVnPRuPpxc042hEsgezXW+NgBf5lPuDaT+k6Hbgv/J jvt0DBLGfzDHmV6vd7LTzSNXStKu7SsJe46SPaGYHOtNLpYuiPPTj162h9161QlvjBD0 kLfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778235838; x=1778840638; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/aqqvi31nG0cLuop8j70SGka90++tg12ySoiLhybgfc=; b=Y3rktDUKjr9SpB92AA/GV9wxj8+03ls32S2gi23LuCxtbbioxcsNp2Gjh3UpSlQgKP vW5syWtjjxg0IJVFd/m3ciZT6kfzwfSNyrLjqD8IU7Pfq/HX0UHPJtWuyz+jW7b19T2n NICeDqmYX/5D+WKXBHWNHLuJWjR/IvcAQl81Xpz53R7B8HK8jPUmxYu+MK/4OslQNt6e HBUttK5SYYUk4ZUCb5LuAOF8pdEADWIiIzZ68GzGNoZxWL944fPcYkz+8ArvmIwF1v9x JoHFPaxc7Nz1/V2HMYHGjePYvf6G/uCT6tWje1I9I+2DVgWSoSzk+kJGIa+XEXIArr1E iwKQ== X-Forwarded-Encrypted: i=1; AFNElJ+fDfjhLAhy798RNEfKAMXABqDZxk5L5L679f0kcE9zip0YXN8BWl6+mEmQwzohAl9GZoz3xuFLPiGYBFw=@vger.kernel.org X-Gm-Message-State: AOJu0YzkZDSoT7D/aL9yu4bm6UNJUwxhZ+VsQHfhJShLm7zscXXCH269 dh8hddIWLDZvCvlTvWv1pjyo9vl0C8qF+HnqpWaGZPQ8R9cEJtD47lnVcASiSAdTlSUulyXCxb7 f1xSdu5eXmdvLgliezFWffQEPK6t4hHYp41gAX/zRbO3idj0sF393zubdMyEnXCvoJw== X-Gm-Gg: Acq92OFwNGvkgpmQknFX/aXkcUqxtLfzWoRSW06tOshIF67ALL1SUZXzHxxBWv/zlQw 9Pi84yVI12P34UxQdY3/G6AEG5sNMf4KJk0P/K5CXP68Xax15oBqpysrBTQz3sdJIRwBNvmR700 uBo39rRv8TD2oSAS6ARK7txWJgfyLpPPxEkRG5c9ecLtnf47NLHECI/6PbJHIzNsBttaD5PeMul rNI3UThAivq0nCHYmOG31amo2e7kuChXW8m/ki7tRhLJwR2Y0d5Jjkm4Df/INQZlsmmPbVrN9BW AoYi9HL4ZT1YbqiexmK/dD/cCtz698yvFSf5+lxtHnpm0c9Xw44vTioMbuZvp/UHm7RMRZSZgrc FIJyj1pyfpDbVKnZmO+uLLJVao03+swECWucxfvQ6H56WY7Mjr9i0+ZECPA== X-Received: by 2002:a05:6000:420c:b0:43d:7a97:78a2 with SMTP id ffacd0b85a97d-4515c5752f7mr19940553f8f.28.1778235838500; Fri, 08 May 2026 03:23:58 -0700 (PDT) X-Received: by 2002:a05:6000:420c:b0:43d:7a97:78a2 with SMTP id ffacd0b85a97d-4515c5752f7mr19940485f8f.28.1778235837943; Fri, 08 May 2026 03:23:57 -0700 (PDT) Received: from [192.168.88.32] ([169.155.232.187]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4548ec6aea4sm3873533f8f.10.2026.05.08.03.23.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 08 May 2026 03:23:57 -0700 (PDT) Message-ID: <8988ea27-59ae-4ebf-ad7d-6e4ef3bf28ed@redhat.com> Date: Fri, 8 May 2026 12:23:55 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] mptcp: do not drop partial packets To: Shardul Bankar , matttbe@kernel.org, martineau@kernel.org Cc: geliang@kernel.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, horms@kernel.org, netdev@vger.kernel.org, mptcp@lists.linux.dev, linux-kernel@vger.kernel.org, janak@mpiric.us, kalpan.jani@mpiricsoftware.com, Shardul Bankar References: <20260422143931.43281-1-shardul.b@mpiricsoftware.com> From: Paolo Abeni Content-Language: en-US In-Reply-To: <20260422143931.43281-1-shardul.b@mpiricsoftware.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 4/22/26 4:39 PM, Shardul Bankar wrote: > When a packet arrives with map_seq < ack_seq < end_seq, the beginning > of the packet has already been acknowledged but the end contains new > data. Currently the entire packet is dropped as "old data," forcing > the sender to retransmit. > > Instead, skip the already-acked bytes by adjusting the skb offset and > enqueue only the new portion. Update bytes_received and ack_seq to > reflect the new data consumed. > > A previous attempt at this fix (commit 1d2ce718811a ("mptcp: do not > drop partial packets"), reverted in commit bf39160c4218 ("Revert > "mptcp: do not drop partial packets"")) also added a zero-window > check and changed rcv_wnd_sent initialization, which caused test > regressions. This version addresses only the partial packet handling > without modifying receive window accounting. > > Fixes: ab174ad8ef76 ("mptcp: move ooo skbs into msk out of order queue.") > Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/600 > Signed-off-by: Shardul Bankar It would be great if you could send a v3 addressing the AI comment. If you don't have time or capacity, please LMK, I can send v3 with your SoB and the needed editing. Thanks, Paolo