From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A7F48195FF0 for ; Tue, 10 Sep 2024 18:47:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725994079; cv=none; b=KFWtPwMuL6vVMF2tSrxupJfwf1HeSfQbKZwz/8ZgB+yRXTwXOf8z/RAtAo422KKZmRtUzxiijqGw4ABGrcq0k+1DcdewmLZw/Thsv12uJQnG+bVIclz1Tmu5yqiKDuLisQ962Sh7SJKO8F4K+8n6TrxZweTFn1ktuBejJbWvyDk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725994079; c=relaxed/simple; bh=+ky8oJg86wBPAINYFROJZlQQ78byoQ+FwPrYHQD8CTI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Jmc74b0xy7yqMQkL5h9XO9CdYXSdBrNJWLlbn0MYL8XKAHojKUdhmMCV4kJzNcQZCEqXExVXZpnIDQKanqcydnde8BxHWi3BLAUeK3NXwnZ553VVo69xONiy0nTPJzYw2EnHE5aNekhUdEZt7/M8zSO2Nq0R6VaUXj37wuP+GrA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LFUlfiCu; arc=none smtp.client-ip=209.85.218.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LFUlfiCu" Received: by mail-ej1-f45.google.com with SMTP id a640c23a62f3a-a8d6ac24a3bso21395166b.1 for ; Tue, 10 Sep 2024 11:47:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1725994076; x=1726598876; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=OWGrueiTQnytXcx9sWxLNLzaYhUD+bCBEfwG71GZFy0=; b=LFUlfiCu5Mz2zw0evNEBwNP/jEEEmfpreYGOiv/QTztIsaSRJCbqB0A1zF1oErJvGw pgBEbR8taJQZ0wUlAg7EVQxV46meREAq+2VuMvcYFxJlsfk6VhJ/galcdleqmnuTS0lQ 1PHQ+q1jG2BURW4A2Pe1G1Hi704PTDt1/dI9r8G32F6Nr9i+hnZTIqYvHyFGefJLzbAL gf01ux53k9KwzVz9oKYiDX0+io0QVgoAgxS/jm3Q6ZwcUdQD3jXtTtCDgsils3CZ0j3q nx7Bx2hlF3D3LwiNhK0PR4x2W3YiPgDfiIEDphwq3Aiui6vhHs6grrMLTBWvTMpjPhcQ 5b8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725994076; x=1726598876; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=OWGrueiTQnytXcx9sWxLNLzaYhUD+bCBEfwG71GZFy0=; b=lp+zdkEgV+8AXKrqVOcfxp/hcGuWyj07SOHzRI3mGxm1Mdm7nPGiM+qW8CmSkQyRKJ 4Mvw/xYFfKIZx1DRrm4olyhqPqeLyCqxMwnVw7jH+3zM1Tz/AA2HyM4ngFFadBE+Yoji ynMGT/xgFZGBwoymWZ1butDXWo4IycectqI6LSCQ4ThK+vnlq9Z181LIIRuW3l8RAmgg pPoKS77Lrz0X+kW0DzqnbXLvw8jyrFSiqBX4Dkew8PtvPPH8Hx22x6xjsjY/XM8r/1IW ALCA7aHK/h6m/uz4pV7Gl9uE9KqES7TS56rTEup1WNVVL1iEaZmWO6ToPR/iAhwt5bGU Br6g== X-Forwarded-Encrypted: i=1; AJvYcCXOu/e3Fz3I50bT/JheUdrfPK6X+L7mkY2rHdkMxSbc2Ni5laR5Q+XWQgPTAFMif+vTIf2BqaOUeBvsD18=@vger.kernel.org X-Gm-Message-State: AOJu0YxChHREDRdWQq6N76d4yNLR8BCSqEwubh1rgf+z/dsWCTt06H2o ucusUSNBW00uXO5+vM+ToJ6WgWV4OqggrkiPAcNITYZIBPxvZbyc X-Google-Smtp-Source: AGHT+IFWS8gI/VbRAttr3tgAmThSzcMd3ve9EQNQkfiz/cP1NeU6Y/LYX9gj578tRX74nG+je8aRVQ== X-Received: by 2002:a17:907:3f9b:b0:a86:8f9b:ef6e with SMTP id a640c23a62f3a-a8ffb212a62mr217542066b.13.1725994075635; Tue, 10 Sep 2024 11:47:55 -0700 (PDT) Received: from ?IPV6:2003:c7:8f2a:8583:6054:7e40:1de3:a91? (p200300c78f2a858360547e401de30a91.dip0.t-ipconnect.de. [2003:c7:8f2a:8583:6054:7e40:1de3:a91]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a8d25c727fcsm512200166b.119.2024.09.10.11.47.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Sep 2024 11:47:55 -0700 (PDT) Message-ID: <89893a22-5018-4ae0-b4f9-e473a36f09b6@gmail.com> Date: Tue, 10 Sep 2024 20:47:54 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] staging: rtl8723bs: Fix coding style issues in the hal_pwr_seq.h To: abid-sayyad , linux-staging@lists.linux.dev Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org References: <20240910121144.635348-1-sayyad.abid16@gmail.com> Content-Language: en-US From: Philipp Hortmann In-Reply-To: <20240910121144.635348-1-sayyad.abid16@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 9/10/24 14:11, abid-sayyad wrote: > Improving the code readability and coding style compliance of the code. > Running checkpatch.pl on the file raised coding style warnings: > -The comment block needs "*" on all lines of the block > from line 8 to 26 > -Use tabs for indent > on line 103 and 115 > > Applying the patch fixes these coding style issues and makes the code more > readable/developer friendly. > > Signed-off-by: abid-sayyad > --- Hi Abid, I cannot apply your patch. Are you using the right git repo? git remote show origin * remote origin Fetch URL: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git ... git branch -a my branch: staging-testing kernel@matrix-ESPRIMO-P710:~/Documents/git/kernels/staging$ mutt Applying: staging: rtl8723bs: Fix coding style issues in the hal_pwr_seq.h error: patch failed: drivers/staging/rtl8723bs/include/hal_pwr_seq.h:101 error: drivers/staging/rtl8723bs/include/hal_pwr_seq.h: patch does not apply Patch failed at 0001 staging: rtl8723bs: Fix coding style issues in the hal_pwr_seq.h Please also change your Description. Concentrate on why this patch makes sense. Do not describe the patch. What is changed can be seen below. Please also use the correct time. You can find accepted examples in the git repo. Thanks for your support. Bye Philipp > changes since v1: > v2: Fix the email body, amke it more informative > link to v1: > https://lore.kernel.org/all/ca1908f3-74aa-45e7-a389-3995aba2660c@gmail.com/ > .../staging/rtl8723bs/include/hal_pwr_seq.h | 46 +++++++++---------- > 1 file changed, 23 insertions(+), 23 deletions(-) > > diff --git a/drivers/staging/rtl8723bs/include/hal_pwr_seq.h b/drivers/staging/rtl8723bs/include/hal_pwr_seq.h > index 5e43cc89f535..10fef1b3f393 100644 > --- a/drivers/staging/rtl8723bs/include/hal_pwr_seq.h > +++ b/drivers/staging/rtl8723bs/include/hal_pwr_seq.h > @@ -5,26 +5,26 @@ > #include "HalPwrSeqCmd.h" > > /* > - Check document WM-20130815-JackieLau-RTL8723B_Power_Architecture v08.vsd > - There are 6 HW Power States: > - 0: POFF--Power Off > - 1: PDN--Power Down > - 2: CARDEMU--Card Emulation > - 3: ACT--Active Mode > - 4: LPS--Low Power State > - 5: SUS--Suspend > - > - The transition from different states are defined below > - TRANS_CARDEMU_TO_ACT > - TRANS_ACT_TO_CARDEMU > - TRANS_CARDEMU_TO_SUS > - TRANS_SUS_TO_CARDEMU > - TRANS_CARDEMU_TO_PDN > - TRANS_ACT_TO_LPS > - TRANS_LPS_TO_ACT > - > - TRANS_END > -*/ > + * Check document WM-20130815-JackieLau-RTL8723B_Power_Architecture v08.vsd > + * There are 6 HW Power States: > + * 0: POFF--Power Off > + * 1: PDN--Power Down > + * 2: CARDEMU--Card Emulation > + * 3: ACT--Active Mode > + * 4: LPS--Low Power State > + * 5: SUS--Suspend > + * > + * The transition from different states are defined below > + * TRANS_CARDEMU_TO_ACT > + * TRANS_ACT_TO_CARDEMU > + * TRANS_CARDEMU_TO_SUS > + * TRANS_SUS_TO_CARDEMU > + * TRANS_CARDEMU_TO_PDN > + * TRANS_ACT_TO_LPS > + * TRANS_LPS_TO_ACT > + * > + * TRANS_END > + */ > #define RTL8723B_TRANS_CARDEMU_TO_ACT_STEPS 26 > #define RTL8723B_TRANS_ACT_TO_CARDEMU_STEPS 15 > #define RTL8723B_TRANS_CARDEMU_TO_SUS_STEPS 15 > @@ -101,7 +101,7 @@ > {0x0007, PWR_CUT_ALL_MSK, PWR_FAB_ALL_MSK, PWR_INTF_SDIO_MSK, PWR_BASEADDR_MAC, PWR_CMD_WRITE, 0xFF, 0x20}, /*0x07 = 0x20 , SOP option to disable BG/MB*/ \ > {0x0005, PWR_CUT_ALL_MSK, PWR_FAB_ALL_MSK, PWR_INTF_USB_MSK|PWR_INTF_SDIO_MSK, PWR_BASEADDR_MAC, PWR_CMD_WRITE, BIT3|BIT4, BIT3}, /*0x04[12:11] = 2b'01 enable WL suspend*/ \ > {0x0005, PWR_CUT_ALL_MSK, PWR_FAB_ALL_MSK, PWR_INTF_PCI_MSK, PWR_BASEADDR_MAC, PWR_CMD_WRITE, BIT2, BIT2}, /*0x04[10] = 1, enable SW LPS*/ \ > - {0x004A, PWR_CUT_ALL_MSK, PWR_FAB_ALL_MSK, PWR_INTF_USB_MSK, PWR_BASEADDR_MAC, PWR_CMD_WRITE, BIT0, 1}, /*0x48[16] = 1 to enable GPIO9 as EXT WAKEUP*/ \ > + {0x004A, PWR_CUT_ALL_MSK, PWR_FAB_ALL_MSK, PWR_INTF_USB_MSK, PWR_BASEADDR_MAC, PWR_CMD_WRITE, BIT0, 1}, /*0x48[16] = 1 to enable GPIO9 as EXT WAKEUP*/ \ > {0x0023, PWR_CUT_ALL_MSK, PWR_FAB_ALL_MSK, PWR_INTF_SDIO_MSK, PWR_BASEADDR_MAC, PWR_CMD_WRITE, BIT4, BIT4}, /*0x23[4] = 1b'1 12H LDO enter sleep mode*/ \ > {0x0086, PWR_CUT_ALL_MSK, PWR_FAB_ALL_MSK, PWR_INTF_SDIO_MSK, PWR_BASEADDR_SDIO, PWR_CMD_WRITE, BIT0, BIT0}, /*Set SDIO suspend local register*/ \ > {0x0086, PWR_CUT_ALL_MSK, PWR_FAB_ALL_MSK, PWR_INTF_SDIO_MSK, PWR_BASEADDR_SDIO, PWR_CMD_POLLING, BIT1, 0}, /*wait power state to suspend*/ > @@ -112,7 +112,7 @@ > {0x0005, PWR_CUT_ALL_MSK, PWR_FAB_ALL_MSK, PWR_INTF_ALL_MSK, PWR_BASEADDR_MAC, PWR_CMD_WRITE, BIT3 | BIT7, 0}, /*clear suspend enable and power down enable*/ \ > {0x0086, PWR_CUT_ALL_MSK, PWR_FAB_ALL_MSK, PWR_INTF_SDIO_MSK, PWR_BASEADDR_SDIO, PWR_CMD_WRITE, BIT0, 0}, /*Set SDIO suspend local register*/ \ > {0x0086, PWR_CUT_ALL_MSK, PWR_FAB_ALL_MSK, PWR_INTF_SDIO_MSK, PWR_BASEADDR_SDIO, PWR_CMD_POLLING, BIT1, BIT1}, /*wait power state to suspend*/\ > - {0x004A, PWR_CUT_ALL_MSK, PWR_FAB_ALL_MSK, PWR_INTF_USB_MSK, PWR_BASEADDR_MAC, PWR_CMD_WRITE, BIT0, 0}, /*0x48[16] = 0 to disable GPIO9 as EXT WAKEUP*/ \ > + {0x004A, PWR_CUT_ALL_MSK, PWR_FAB_ALL_MSK, PWR_INTF_USB_MSK, PWR_BASEADDR_MAC, PWR_CMD_WRITE, BIT0, 0}, /*0x48[16] = 0 to disable GPIO9 as EXT WAKEUP*/ \ > {0x0005, PWR_CUT_ALL_MSK, PWR_FAB_ALL_MSK, PWR_INTF_ALL_MSK, PWR_BASEADDR_MAC, PWR_CMD_WRITE, BIT3|BIT4, 0}, /*0x04[12:11] = 2b'01enable WL suspend*/\ > {0x0023, PWR_CUT_ALL_MSK, PWR_FAB_ALL_MSK, PWR_INTF_SDIO_MSK, PWR_BASEADDR_MAC, PWR_CMD_WRITE, BIT4, 0}, /*0x23[4] = 1b'0 12H LDO enter normal mode*/ \ > {0x0301, PWR_CUT_ALL_MSK, PWR_FAB_ALL_MSK, PWR_INTF_PCI_MSK, PWR_BASEADDR_MAC, PWR_CMD_WRITE, 0xFF, 0},/*PCIe DMA start*/ > @@ -209,7 +209,7 @@ > #define RTL8723B_TRANS_END \ > /* format */ \ > /* { offset, cut_msk, fab_msk|interface_msk, base|cmd, msk, value }, comments here*/ \ > - {0xFFFF, PWR_CUT_ALL_MSK, PWR_FAB_ALL_MSK, PWR_INTF_ALL_MSK, 0, PWR_CMD_END, 0, 0}, > + {0xFFFF, PWR_CUT_ALL_MSK, PWR_FAB_ALL_MSK, PWR_INTF_ALL_MSK, 0, PWR_CMD_END, 0, 0}, > > > extern struct wlan_pwr_cfg rtl8723B_power_on_flow[RTL8723B_TRANS_CARDEMU_TO_ACT_STEPS+RTL8723B_TRANS_END_STEPS]; > -- > 2.39.2 >