From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2307AC18E5A for ; Wed, 11 Mar 2020 11:20:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 03C4A208E4 for ; Wed, 11 Mar 2020 11:20:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729121AbgCKLUY (ORCPT ); Wed, 11 Mar 2020 07:20:24 -0400 Received: from mx2.suse.de ([195.135.220.15]:39412 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725834AbgCKLUV (ORCPT ); Wed, 11 Mar 2020 07:20:21 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id B7121AED2; Wed, 11 Mar 2020 11:20:18 +0000 (UTC) Subject: Re: [PATCH v3] block: refactor duplicated macros To: Matteo Croce Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nvdimm@lists.01.org, linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org, linux-mmc@vger.kernel.org, xen-devel@lists.xenproject.org, linux-scsi@vger.kernel.org, linux-nfs@vger.kernel.org, Jens Axboe , "James E.J. Bottomley" , Ulf Hansson , Anna Schumaker , Dan Williams , Song Liu , Guoqing Jiang References: <20200311002254.121365-1-mcroce@redhat.com> From: Coly Li Organization: SUSE Labs Message-ID: <89925759-cbc1-e8f0-b9b3-23fd062ebbcd@suse.de> Date: Wed, 11 Mar 2020 19:20:11 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200311002254.121365-1-mcroce@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/3/11 8:22 上午, Matteo Croce wrote: > The macros PAGE_SECTORS, PAGE_SECTORS_SHIFT and SECTOR_MASK are defined > several times in different flavours across the whole tree. > Define them just once in a common header. > > While at it, replace replace "PAGE_SHIFT - 9" with "PAGE_SECTORS_SHIFT" too > and rename SECTOR_MASK to PAGE_SECTORS_MASK. > > Signed-off-by: Matteo Croce Hi Matteo, For the bcache part, it looks good to me. Acked-by: Coly Li > --- > v3: > As Guoqing Jiang suggested, replace "PAGE_SHIFT - 9" with "PAGE_SECTORS_SHIFT" > > v2: > As Dan Williams suggested: > > #define PAGE_SECTORS_MASK (~(PAGE_SECTORS - 1)) > > block/blk-lib.c | 2 +- > block/blk-settings.c | 4 ++-- > block/partition-generic.c | 2 +- > drivers/block/brd.c | 3 --- > drivers/block/null_blk_main.c | 14 +++++--------- > drivers/block/zram/zram_drv.c | 8 ++++---- > drivers/block/zram/zram_drv.h | 2 -- > drivers/dax/super.c | 2 +- > drivers/md/bcache/util.h | 2 -- > drivers/md/dm-bufio.c | 6 +++--- > drivers/md/dm-integrity.c | 10 +++++----- > drivers/md/dm-table.c | 2 +- > drivers/md/md.c | 4 ++-- > drivers/md/raid1.c | 2 +- > drivers/md/raid10.c | 2 +- > drivers/md/raid5-cache.c | 10 +++++----- > drivers/md/raid5.h | 2 +- > drivers/mmc/core/host.c | 3 ++- > drivers/nvme/host/fc.c | 2 +- > drivers/nvme/target/loop.c | 2 +- > drivers/scsi/xen-scsifront.c | 4 ++-- > fs/erofs/internal.h | 2 +- > fs/ext2/dir.c | 2 +- > fs/iomap/buffered-io.c | 2 +- > fs/libfs.c | 2 +- > fs/nfs/blocklayout/blocklayout.h | 2 -- > fs/nilfs2/dir.c | 2 +- > include/linux/blkdev.h | 4 ++++ > include/linux/device-mapper.h | 1 - > mm/page_io.c | 4 ++-- > mm/swapfile.c | 12 ++++++------ > 31 files changed, 56 insertions(+), 65 deletions(-) > [snipped] > diff --git a/drivers/md/bcache/util.h b/drivers/md/bcache/util.h > index c029f7443190..55196e0f37c3 100644 > --- a/drivers/md/bcache/util.h > +++ b/drivers/md/bcache/util.h > @@ -15,8 +15,6 @@ > > #include "closure.h" > > -#define PAGE_SECTORS (PAGE_SIZE / 512) > - > struct closure; > > #ifdef CONFIG_BCACHE_DEBUG [snipped] -- Coly Li