From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0255122D4C3 for ; Fri, 21 Mar 2025 16:31:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742574679; cv=none; b=QvZ2uCpV7FHhfHITmGyrP0wVhGIQtqjcmJPxTh/jN8rra9JQ2zOf5rVdLBnafACNkzruo2zet/lXOFi+y7ldanE/2yuP/7B8CyOllGPFheBoLS10LnA0X56BWLYUlievYEw37281yxKjxzvVH7ujdL/JAl4ouUVeo6aASTyADPY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742574679; c=relaxed/simple; bh=zojdPWtEGUjvrbgAMqva/TKdcj3Cxw4XjqxiaqiNiiM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=h771820tAMoQIVgeD0k8sBVsSfF8ajkqzxzRE6W8YG3jHCwZxSNFOUTTJX9PpgaSwS1o3g7BzXm8lnU/TFzNzUssEqD1+fOrj5Y3TKFS3EDWocmdGAIKyvwmik0kJKNhXoltqisP1nFVEKNTcTfjgbe3BjBS7220EZYOdCKQxDY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=LpQ8sILj; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="LpQ8sILj" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 52LAThOS003246 for ; Fri, 21 Mar 2025 16:31:17 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= UQ+EQ5JGQ/p3NSEWSaxtIU/HftXFPwlWY/6AZof8vvA=; b=LpQ8sILjllXrzXkB Ycfm98+ptIVH8dh0c5/x0khSiWKpeKQOftDjH1Sc2QVdINtGmdt02zndLn6KtTKj bsCwXjVIqM8Pny+qYwZGc1+UixIP7cw4WA+nEIvcfFUWBMKBNPZy15KVtfrm5krY jgXBW78KyDPMj1OjZuyuTcFOOxbr6C+Rqar+Lh8gCBMcjuupv42jFCaVLY9S4fmD /KMtgJiImCu1xE+qFa70ZIT77TQxWl+153rgLDYo5hh27l/XVkgy0+2H32uyW7xQ qc9TwaNKzebqs2l36TmE74LmqpzRICRl9pR5kI9CNfZsBh8TvedTSy58dmxzftiE tcIKBg== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 45h4p11c18-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 21 Mar 2025 16:31:16 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-300fefb8e25so3764740a91.3 for ; Fri, 21 Mar 2025 09:31:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742574676; x=1743179476; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UQ+EQ5JGQ/p3NSEWSaxtIU/HftXFPwlWY/6AZof8vvA=; b=M65HnmqP54wBCSq9gNbOk6IS7Uowj2cByvSssRLZGzIYF+eWjVaYq5AMmztkEJHhEc LEPnvKcm5JVt1F5Jt2nM9z8BV0QrAQaV9M7UQrnuMylH/kWrtNbvdSCm3ixK3XDUYPNr CXHN1akMMEZIlgepHO0LflglU1K+Z9T+jQbJb4gxAaA88o6drwaESSOFkm9E2ypG08ze 5iQyWSdhfzFYqHQuQwnHDSKJx4LAuZYZO8yGHe1SAVsHY+oKP83wyThIMcrTgpifS6aW LNzLqDjersyQorzYkuNZIChDOZKYTjuKrmb5o/UMkTDzTG+UZgbb/nN36sRBI4bGJo5Z Cisw== X-Forwarded-Encrypted: i=1; AJvYcCU+KRC0xbeGQJSaVOvuqmdCJs0hjjO+R3o9ywhWQsOzL5jzeFpn+sqHl9C+KhU6iSFZDeygNcB/W5wrU+0=@vger.kernel.org X-Gm-Message-State: AOJu0YyoR4vxM3S21sMwwBz1hHzum8/WcH3feXHbqluIH047rkfCJY+q YtanlnaCeIeRs8670ZI2Uwv1QxlnKTfJZepVIvojnj9sBpJDuLcb74kYuf02/2hqpmTZ2gqeeje Lk5Ie7Y15UIIRMrQMYtJ4+LPuAMp8jO6AO9kyfv1FzG9FD/kBCL0AxrWWuTZ67Cs= X-Gm-Gg: ASbGncuaKl30+qjnMkpnEvciEeWQrjKG8M5zWuIy8zU9rgxctwSWG3p8qxXWWfkuikE 6V2ljTZyuIXzuP7bRW+ZkWafMz+JE8I1ashlbhjhTTd8k7Q9xJQMzQrZHe3uKUuJLkzDmGDtaxT BXTP1FxEiWtwxTKv59R6Pl3uibYXHuWSkN6qpejJc0XGfYFCLam0u71G+kfMyYfnBJjVUdHZTLj wAGv8V2Pt7WWXVRW9gFV1lOZUcwlB/cgc0eFUuUXjeg4GCdbcapJYzD3AESz1E0cVDg1cPAvXgH SGTTc8Cgl0Oy+Ahk53idMS2Cpu2cYcR3IzkPHlKPjmh5hwriKOvVjBiXiLvfhGuEZHejPr33V5I 1nacipyXR X-Received: by 2002:a05:6a20:d81b:b0:1f5:93cd:59b5 with SMTP id adf61e73a8af0-1fe43327edbmr7689397637.28.1742574675870; Fri, 21 Mar 2025 09:31:15 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHiuQMISl1eN9RX+Es821Eblup8CDwjYoGKpMH5CGlq8b1HHOajXsiimxB0ELiPyxoSm0dayA== X-Received: by 2002:a05:6a20:d81b:b0:1f5:93cd:59b5 with SMTP id adf61e73a8af0-1fe43327edbmr7689338637.28.1742574675301; Fri, 21 Mar 2025 09:31:15 -0700 (PDT) Received: from [192.168.1.111] (c-73-202-227-126.hsd1.ca.comcast.net. [73.202.227.126]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-af8a2a4d016sm1690127a12.69.2025.03.21.09.31.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Mar 2025 09:31:14 -0700 (PDT) Message-ID: <89db5e91-2162-4724-bdf1-238f84bca8a6@oss.qualcomm.com> Date: Fri, 21 Mar 2025 09:31:13 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH ath-next] wifi: ath12k: don't put ieee80211_chanctx_conf struct in ath12k_link_vif To: Baochen Qiang , Johannes Berg , Jeff Johnson Cc: linux-wireless@vger.kernel.org, ath12k@lists.infradead.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" References: <20250321-ath12k-dont-put-chanctx-in-arvif-v1-1-c8e93061952b@quicinc.com> From: Jeff Johnson Content-Language: en-US In-Reply-To: <20250321-ath12k-dont-put-chanctx-in-arvif-v1-1-c8e93061952b@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: F1ghb_QiuiqpIu899icZzQ0KyO0l-jF5 X-Proofpoint-ORIG-GUID: F1ghb_QiuiqpIu899icZzQ0KyO0l-jF5 X-Authority-Analysis: v=2.4 cv=NZjm13D4 c=1 sm=1 tr=0 ts=67dd9454 cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=e70TP3dOR9hTogukJ0528Q==:17 a=IkcTkHD0fZMA:10 a=Vs1iUdzkB0EA:10 a=bC-a23v3AAAA:8 a=VwQbUJbxAAAA:8 a=uvMg_fejPkrpZwH_nmEA:9 a=QEXdDO2ut3YA:10 a=-FEs8UIgK8oA:10 a=rl5im9kqc5Lf4LNbBjHf:22 a=FO4_E8m0qiDe52t0p3_H:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1093,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-03-21_05,2025-03-21_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 mlxlogscore=939 priorityscore=1501 impostorscore=0 bulkscore=0 phishscore=0 spamscore=0 mlxscore=0 lowpriorityscore=0 suspectscore=0 malwarescore=0 adultscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2502280000 definitions=main-2503210121 On 3/20/2025 6:45 PM, Baochen Qiang wrote: > ieee80211_chanctx_conf struct is not put at the end of ath12k_link_vif. > Note ieee80211_chanctx_conf has flexible array member inside it, causing > below warning with GCC-14: > > drivers/net/wireless/ath/ath12k/core.h:298:39: warning: structure containing a flexible array member is not at the end of another structure [-Wflex-array-member-not-at-end] > > Although there is no issue for now since the array is not getting used, > this should be fixed to avoid any potential data corruption issue in the > future. > > Remove this struct from ath12k_link_vif, fetch it from ieee80211_bss_conf > instead when needed. > > This change only applies to WCN7850, and should has no impact on other > chipsets. > > This is an alternative to the solution proposed in [1]. > > Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3 > > Reported-by: Gustavo A. R. Silva > Link: https://msgid.link/Z8-Snz86Xfwdlyd7@kspp # [1] I'll change this to Closes: in pending to address checkpatch: WARNING:BAD_REPORTED_BY_LINK: Reported-by: should be immediately followed by Closes: with a URL to the report