From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Stephan Gerhold <stephan@gerhold.net>
Cc: Amit Kucheria <amitk@kernel.org>,
Thara Gopinath <thara.gopinath@gmail.com>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Zhang Rui <rui.zhang@intel.com>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Neil Armstrong <neil.armstrong@linaro.org>
Subject: Re: [PATCH] dt-bindings: thermal: qcom-tsens: simplify if:then: clauses
Date: Thu, 17 Nov 2022 16:31:19 +0100 [thread overview]
Message-ID: <89e0f9b7-e06d-ea26-6e45-d22a74371f4b@linaro.org> (raw)
In-Reply-To: <Y3ZFDRI6ypg18S27@gerhold.net>
On 17/11/2022 15:28, Stephan Gerhold wrote:
> On Thu, Nov 17, 2022 at 02:02:54PM +0100, Krzysztof Kozlowski wrote:
>> Most of the device-specific compatibles have generic fallbacks like
>> qcom,tsens-v1 or qcom,tsens-v2. The if:then: block mentions these
>> fallbacks, so drop redundant entries for specific compatibles.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>
>> ---
>>
>> Cc: Neil Armstrong <neil.armstrong@linaro.org>
>> ---
>> .../devicetree/bindings/thermal/qcom-tsens.yaml | 16 ----------------
>> 1 file changed, 16 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
>> index f0bd4b979e28..c9949713f714 100644
>> --- a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
>> +++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
>> @@ -118,12 +118,7 @@ allOf:
>> contains:
>> enum:
>> - qcom,ipq8064-tsens
>> - - qcom,mdm9607-tsens
>> - - qcom,msm8916-tsens
>> - qcom,msm8960-tsens
>> - - qcom,msm8974-tsens
>> - - qcom,msm8976-tsens
>> - - qcom,qcs404-tsens
>> - qcom,tsens-v0_1
>> - qcom,tsens-v1
>> then:
>
> FWIW: I submitted the same patch for this part a couple of months ago,
> it was never applied for some reason:
> https://lore.kernel.org/linux-arm-msm/20220627131415.2868938-2-stephan.gerhold@kernkonzept.com/
Indeed, somehow Daniel didn't take it. Your patch should go instead, if
you rebase and include new hunks (like my patch).
>
>> @@ -140,17 +135,6 @@ allOf:
>> compatible:
>> contains:
>> enum:
>> - - qcom,msm8953-tsens
>> - - qcom,msm8996-tsens
>> - - qcom,msm8998-tsens
>> - - qcom,sc7180-tsens
>> - - qcom,sc7280-tsens
>> - - qcom,sc8180x-tsens
>> - - qcom,sdm630-tsens
>> - - qcom,sdm845-tsens
>> - - qcom,sm8150-tsens
>> - - qcom,sm8250-tsens
>> - - qcom,sm8350-tsens
>> - qcom,tsens-v2
>> then:
>> properties:
>>
>
> This part was not present back then though. Looks like this was
> introduced recently in "dt-bindings: thermal: tsens: Add ipq8074
> compatible".
>
> I don't mind if you take this patch instead of mine. Feel free to add my
>
> Reviewed-by: Stephan Gerhold <stephan@gerhold.net>
>
> Thanks,
> Stephan
Best regards,
Krzysztof
prev parent reply other threads:[~2022-11-17 15:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-17 13:02 [PATCH] dt-bindings: thermal: qcom-tsens: simplify if:then: clauses Krzysztof Kozlowski
2022-11-17 14:28 ` Stephan Gerhold
2022-11-17 15:31 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89e0f9b7-e06d-ea26-6e45-d22a74371f4b@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=amitk@kernel.org \
--cc=andersson@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
--cc=stephan@gerhold.net \
--cc=thara.gopinath@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox