Re: [PATCH 1/6] dt-bindings: adc: ad7173: add support for ad411x

Ceclan, Dumitru
2024-04-03T10:08:12Z

On 03/04/2024 10:45, Ceclan, Dumitru wrote:
> On 01/04/2024 23:22, David Lechner wrote:
>> On Mon, Apr 1, 2024 at 2:37 PM David Lechner <dlechner@baylibre.com> wrote:
>>>
>>> On Mon, Apr 1, 2024 at 10:10 AM Dumitru Ceclan via B4 Relay
>>> <devnull+dumitru.ceclan.analog.com@kernel.org> wrote:
>
> ...
>
>>
>> Also, I just noticed that AD411x have only one AVDD input instead of
>> AVDD1 and AVDD2. So we need an if statement that says if properties:
>> compatible: enum: - adi,ad411x, then properties: avdd2-supply: false.
>
> Already addressed by this:
> "
> # Only ad7172-4, ad7173-8 and ad7175-8 support vref2
> - if:
> properties:
> compatible:
> not:
> contains:
> enum:
> - adi,ad7172-4
> - adi,ad7173-8
> - adi,ad7175-8
> then:
> properties:
> vref2-supply: false
> patternProperties:
> "^channel@[0-9a-f]$":
> properties:
> adi,reference-select:
> enum:
> - vref
> - refout-avss
> - avdd
> "

Mistaken vref2-supply to avdd2-supply.

But still, the presence of avdd2-supply does not influence anything at all.
Driver does not use it, you cannot select it for channel conversions.
Would a restriction like this really be required?