Re: [PATCH v10 105/108] KVM: TDX: Add methods to ignore accesses to CPU state

Huang, Kai
2022-11-22T01:18:58Z

On Sat, 2022-10-29 at 23:23 -0700, isaku.yamahata@intel.com wrote:
> From: Sean Christopherson <sean.j.christopherson@intel.com>
>
> TDX protects TDX guest state from VMM. Implements to access methods for
> TDX guest state to ignore them or return zero.

IMHO this patch isn't reviewable -- too many things mixed together. And the
logic of whether to use WARN()/KVM_BUG_ON() against TD is hard to tell as they
depends on common x86 code logic. The relative parts (i.e. interrupt related
parts) should be put together as separate patches to make the whole thing
reviewable.

Hi Sean, do you have any comments?