From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 89D4D386C0F for ; Thu, 7 May 2026 14:10:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778163007; cv=none; b=RRoeVYIxGE3VOcMngCKxcKKjZLgFZegK4X8MvMhZQiqVPtni0wghI99HBnJk7fzlyq4RVxRZ4cqOwhuoig4/kyhpIemzHbHCGoJDKPb5TOqeAJPGBrhPKB/kPQMSvUXt6Y5U2IzHwfUnNPJrdhrFcuVD3TubuG/rNoJDWjAsg3Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778163007; c=relaxed/simple; bh=vZcnE/e8LQ9WOIBHibr0IDXRpScsLhebMjSN4wiggfI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=kQkpF8XGNsuOpavEw+FXgPaXe0XT8a8dNo4KXEUwhJNof4wRP5F+DDvnfN82ZhpU4CPFLifvCQSs6F6FhOvMiGtXJ6Eq7c/QwMdTObKjuhCY8NLQZXqExBZHdx6EaExDtq8mGsiFR1j/X8bXXJOfEUYoDgKWW7LtK/HtU/NbESQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=npjLD5L3; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=JAPivs0a; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="npjLD5L3"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="JAPivs0a" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 647BDtqs3924161 for ; Thu, 7 May 2026 14:10:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= n32FPL48jUWDBVk1qxVmjMmAGF0l1K/hWXAEUvGcTKU=; b=npjLD5L3SZAAgp8l buIRqV9iUN9RJe9Nq08o60OQkFcl6vsEIaHtoIETwfVcC+UZc2ohLdbtuns3YQJx 535SWxeJ01+j140Scg7B0nHXotnLlu3f+2tior//teHYDs14phCCFs0aZSqGcBdZ Vb8SHt9V0NEWJEb+tDgn9vo1wShDFQkD7d1OG9MyO+sMUaraJqnBE1dvyqJdksA7 X/1SMITIgKhnH6W5qxytUPuEHVS8SdNJchMS3YUOg73ldQyu6e20zBfY08LHTGEo L8dvuC+YTS52PMG4u8IaOlkk+i/k47s+zDq4yb2wo9kuUwtVa44FGDspBVzTubMY XO86gw== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e0c88bend-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 07 May 2026 14:10:05 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-3662668b825so732421a91.3 for ; Thu, 07 May 2026 07:10:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778163004; x=1778767804; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=n32FPL48jUWDBVk1qxVmjMmAGF0l1K/hWXAEUvGcTKU=; b=JAPivs0afNkrmQRBB63WgPwDeXn8vPloPPFWFW5v9iI7duZ8wEcupCSr/IrHzurN8b tKw8QIbPk99hnjaEcxDcEXd7JmwDE60FVzcbqSejI9kMUMHGmtuZp8HJ59CByrzMx/R5 z851yaYB0h7wluSg9NEu7hK+SkRZ9Qxje4YFgRuTIiTYH/hoZGGl22dykadUrSP65Lw8 p1IfE00CubGBmADs71ATxZVd5NUNDVzaXAHBHRYA/L4SeaBeVIffbWBqK//fPAImt0zP kBf3vvzyHNAfPF3FrzR4BmE9aXEI2+PUXKY9sOW3ndm9CoNT2L46wdO376I/uO9535mv LwSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778163004; x=1778767804; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=n32FPL48jUWDBVk1qxVmjMmAGF0l1K/hWXAEUvGcTKU=; b=Dj0Wkl+MXUHGfvF74Ryak/Prp7+TyOQVzuDW5irmNEfcZIVgot0Hwh4YHWxpjBkM2N Gg+WIS7KYmOfq1cgImXU1Pk/IXy4KEd9T7prC5Rs0pU7r4Z6z4mIznvWdiN1oNxa3kCq MrRYAGaPcDcYiro8Wqh1M7Sl6ewTiS0qYChZE1/ydNbxRusjJcITVPGOBDJpOSZ09veK BvARZZhFUUykAg9bprB+Kv304liQwzGhS+leLpEQc3fdI9JLg69i/6jqDrHl9ApVy7jc U10dV0RpL+6E0wm5BqNu3XoJdjIPVp01RlhGP/DtyO2a8TRtBtysEB4+w2tLrwD55m/G oPSQ== X-Forwarded-Encrypted: i=1; AFNElJ/thjSwB7H4aEzL3L38we9aWBZIN0dDcmmdwyheSR4NUTQ4o7+J9ygaKir/UKDrqBKYJiDnvATWtHHEYjA=@vger.kernel.org X-Gm-Message-State: AOJu0Ywhck0MhG45RprBO6tyjXA+5idz5PfbWI10htUB84hr4iPIOf/r 3TlNevR73aNbRtFGis6Kr68pPTp6irXVBccHyCM1t/dBIfLXoqetPpaA9hkqkS3SOo7Bz6bljDE 1rIXx11c++spfIPoVyW2QI1Eaw4xNfJbR6d74yyPCJa0IFTpjo8rWZ7Cfu+yR0Ep8r4M= X-Gm-Gg: AeBDieu0qHzyxVaiSYdQ3L646m8GumdnUJCTE60jj6fFamIj0SDEVCkSoJ+LeZiL6w3 8H6yBdNh6hySHeLaPe6Wez560E7ZJP/l1KOUaEZ6JNCqw6e2CwlGBjw5vgpuwUbL/FT6WRJRzQM ytek0nD3srbKHSsthSyFpUJYSFZRkdH4xdBjVcHkfbsko0MUfom59hZlZ5ydkx13vrLnWyg0FVk ahYU/tQur0eNppu2LFeahqRLRwdQBjK7yW2j5NrgO7kuuexl+3r9c9qqTQfeIbRazKVZ30ek0cC pnbWd0Y7yFscDJjyzN4a1e0Yyh/3IKcRMvmd4O5U2AJVnc9+nZzFuCiXkyfRiuTvk17Pqlhojg2 P9uAHhEOVfYzHvBeYLhJlwNtbLBzgjVefWak2IrOu92Krj+knnGsxBpE= X-Received: by 2002:a17:90a:1c88:b0:365:d9e2:7511 with SMTP id 98e67ed59e1d1-365d9e27b9emr3785116a91.25.1778163004496; Thu, 07 May 2026 07:10:04 -0700 (PDT) X-Received: by 2002:a17:90a:1c88:b0:365:d9e2:7511 with SMTP id 98e67ed59e1d1-365d9e27b9emr3785084a91.25.1778163004032; Thu, 07 May 2026 07:10:04 -0700 (PDT) Received: from [10.206.103.12] ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-365b4fb5e7esm6536089a91.15.2026.05.07.07.09.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 May 2026 07:10:03 -0700 (PDT) Message-ID: <89fbbbb0-1a0a-4ba5-ae49-7a19aa50e638@oss.qualcomm.com> Date: Thu, 7 May 2026 19:39:56 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 13/29] drm/msm/adreno: use new helper to set ubwc_swizzle To: Dmitry Baryshkov , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Konrad Dybcio References: <20260507-ubwc-rework-v4-0-c19593d20c1d@oss.qualcomm.com> <20260507-ubwc-rework-v4-13-c19593d20c1d@oss.qualcomm.com> From: Akhil P Oommen Content-Language: en-US In-Reply-To: <20260507-ubwc-rework-v4-13-c19593d20c1d@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: Q50xc-J1LfZp2t5WAqWGk55YioeV7jVH X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA3MDE0MSBTYWx0ZWRfX3b0rZ2gyfzCJ r06NwtINcB1CyrKi9PLdpj/pbRQgCD01nsi2pH/wgsNbviXFB1kMllCPIX/6hJRbee7M1TIN2eO 7FrUxq6ZLUG+ppKY9EwjBnHIGLnACdJZwZ4H+ikDpNY7NGfi7MpKuyY6u4xQOXEqzFhvzg0GB8u jom6D3uCdFkyr4f4ReiPcHGP/LlB6wI5vZGP8SCfQefxNL1Zg+CCM6LeSl5Gwns+IuOsYx7IJpt DtJDnySzYXgVYFB7d6zuyAOUNBIZ3ryvih1Hb59zcDC/BszPeb7XSwZoy62i6m2a69Jy7f54Y7J JzyoI/QiwWJ3pBZ2zGpr9EFMcTm1cR8jKKtNK87MgFonxJlpFInt1AirHMIVi3kXgzwd5j9NQQ1 UFipfvZaaOKu6ey1e0sGv3QaPG2XN54xk2C4awe6OmLoPDzHJjVxTzKwREHmayR1Oj029JvnauM r5LHf9v9irfxMguULZw== X-Proofpoint-GUID: Q50xc-J1LfZp2t5WAqWGk55YioeV7jVH X-Authority-Analysis: v=2.4 cv=X8Zi7mTe c=1 sm=1 tr=0 ts=69fc9d3d cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=BTchm6ImzknZz8NDhdQA:9 a=QEXdDO2ut3YA:10 a=mQ_c8vxmzFEMiUWkPHU9:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-07_01,2026-05-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 suspectscore=0 spamscore=0 adultscore=0 malwarescore=0 lowpriorityscore=0 clxscore=1015 phishscore=0 priorityscore=1501 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605070141 On 5/7/2026 6:33 PM, Dmitry Baryshkov wrote: > Use freshly defined helper instead of using the raw value from the > database. > > Reviewed-by: Konrad Dybcio > Signed-off-by: Dmitry Baryshkov Reviewed-by: Akhil P Oommen -Akhil > --- > drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 2 +- > drivers/gpu/drm/msm/adreno/a8xx_gpu.c | 4 ++-- > drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +- > 3 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c > index 76c681614416..5c17565b0499 100644 > --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c > +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c > @@ -745,7 +745,7 @@ static void a6xx_set_ubwc_config(struct msm_gpu *gpu) > BUG_ON(cfg->highest_bank_bit < 13); > u32 hbb = cfg->highest_bank_bit - 13; > bool rgb565_predicator = cfg->ubwc_enc_version >= UBWC_4_0; > - u32 level2_swizzling_dis = !(cfg->ubwc_swizzle & UBWC_SWIZZLE_ENABLE_LVL2); > + u32 level2_swizzling_dis = !(qcom_ubwc_swizzle(cfg) & UBWC_SWIZZLE_ENABLE_LVL2); > bool ubwc_mode = qcom_ubwc_get_ubwc_mode(cfg); > bool amsbc = cfg->ubwc_enc_version >= UBWC_3_0; > bool min_acc_len_64b; > diff --git a/drivers/gpu/drm/msm/adreno/a8xx_gpu.c b/drivers/gpu/drm/msm/adreno/a8xx_gpu.c > index 1923f904d37d..53def136e0fc 100644 > --- a/drivers/gpu/drm/msm/adreno/a8xx_gpu.c > +++ b/drivers/gpu/drm/msm/adreno/a8xx_gpu.c > @@ -275,8 +275,8 @@ static void a8xx_set_ubwc_config(struct msm_gpu *gpu) > { > struct adreno_gpu *adreno_gpu = to_adreno_gpu(gpu); > const struct qcom_ubwc_cfg_data *cfg = adreno_gpu->ubwc_config; > - u32 level2_swizzling_dis = !(cfg->ubwc_swizzle & UBWC_SWIZZLE_ENABLE_LVL2); > - u32 level3_swizzling_dis = !(cfg->ubwc_swizzle & UBWC_SWIZZLE_ENABLE_LVL3); > + u32 level2_swizzling_dis = !(qcom_ubwc_swizzle(cfg) & UBWC_SWIZZLE_ENABLE_LVL2); > + u32 level3_swizzling_dis = !(qcom_ubwc_swizzle(cfg) & UBWC_SWIZZLE_ENABLE_LVL3); > bool rgba8888_lossless = false, fp16compoptdis = false; > bool yuvnotcomptofc = false, min_acc_len_64b = false; > bool rgb565_predicator = false, amsbc = false; > diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c b/drivers/gpu/drm/msm/adreno/adreno_gpu.c > index bf1572156b0b..d26985c88115 100644 > --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.c > +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.c > @@ -430,7 +430,7 @@ int adreno_get_param(struct msm_gpu *gpu, struct msm_context *ctx, > *value = adreno_gpu->has_ray_tracing; > return 0; > case MSM_PARAM_UBWC_SWIZZLE: > - *value = adreno_gpu->ubwc_config->ubwc_swizzle; > + *value = qcom_ubwc_swizzle(adreno_gpu->ubwc_config); > return 0; > case MSM_PARAM_MACROTILE_MODE: > *value = qcom_ubwc_macrotile_mode(adreno_gpu->ubwc_config); >