From: Chris Wilson <chris@chris-wilson.co.uk>
To: Jan Kara <jack@suse.cz>, LKML <linux-kernel@vger.kernel.org>
Cc: dri-devel@lists.sourceforge.net, Jan Kara <jack@suse.cz>
Subject: Re: [PATCH 11/18] i915: Provide config option for enabling tracepoints
Date: Tue, 23 Mar 2010 08:42:34 +0000 [thread overview]
Message-ID: <89kc63$gdp6nr@fmsmga002.fm.intel.com> (raw)
In-Reply-To: <1269304340-25372-12-git-send-email-jack@suse.cz>
Out of curiosity what motivated this patch? When adding the tracepoints,
I found the overhead of compiling in but not enabling them to be
insignificant, i.e. nearly unmeasurable in throughput benchmarks, so
didn't believe it warranted a config option. Especially one that advises
people to turn off what may be a useful aid in desktop systems.
Also is TRACER the right name, that would seem to confuse the option with
a standalone tracer as opposed to simply enabling tracepoints.
-ickle
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2010-03-23 8:42 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-23 0:32 [PATCH 0/18] Allow different tracers to be compiled independently Jan Kara
2010-03-23 0:32 ` [PATCH 01/18] trace: Allow <linux/tracepoint.h> to create empty tracepoints Jan Kara
2010-03-23 1:06 ` Steven Rostedt
2010-03-26 1:30 ` Jan Kara
2010-03-23 0:32 ` [PATCH 02/18] block: Generate blktrace trace points only if blktrace is enabled Jan Kara
2010-03-23 0:32 ` [PATCH 03/18] mm: Generate kmemtrace trace points only if they are enabled Jan Kara
2010-03-23 0:32 ` [PATCH 04/18] mac80211: Generate trace points only if api tracer enabled Jan Kara
2010-03-23 1:11 ` Johannes Berg
2010-03-23 23:54 ` Steven Rostedt
2010-03-23 0:32 ` [PATCH 05/18] workqueue: Generate trace points only when workqueue " Jan Kara
2010-03-23 0:32 ` [PATCH 06/18] sched: Generate trace points only if scheduler tracing is enabled Jan Kara
2010-03-23 1:07 ` Frederic Weisbecker
2010-03-23 23:52 ` Steven Rostedt
2010-03-24 0:31 ` Frederic Weisbecker
2010-03-23 0:32 ` [PATCH 07/18] ext4: Provide config options for enabling ext4 and jbd2 tracing Jan Kara
2010-03-23 0:32 ` [PATCH 08/18] lockdep: Provide config option for enabling lock tracepoints Jan Kara
2010-03-23 0:32 ` [PATCH 09/18] module: Provide config option to enable tracing of module load / unload Jan Kara
2010-03-23 0:32 ` [PATCH 10/18] gfs2: Provide config option for enabling trace points Jan Kara
2010-03-23 12:01 ` [Cluster-devel] " Steven Whitehouse
2010-03-23 23:56 ` Steven Rostedt
2010-03-24 11:20 ` Steven Whitehouse
2010-03-24 12:09 ` Steven Rostedt
2010-03-23 0:32 ` [PATCH 11/18] i915: Provide config option for enabling tracepoints Jan Kara
2010-03-23 8:42 ` Chris Wilson [this message]
2010-03-23 0:32 ` [PATCH 12/18] timer: Provide config option for enabling timer tracepoints Jan Kara
2010-03-23 2:01 ` Thomas Gleixner
2010-03-23 3:01 ` Steven Rostedt
2010-03-23 0:32 ` [PATCH 13/18] acpi: Provide config option to enable power tracepoints Jan Kara
2010-03-23 0:32 ` [PATCH 14/18] net: Provide config option for enabling SKB tracing Jan Kara
2010-03-23 0:32 ` [PATCH 15/18] net: Provide config option for enabling NAPI tracing Jan Kara
2010-03-23 0:32 ` [PATCH 16/18] Generate empty tracepoints if syscall tracing is disabled Jan Kara
2010-03-23 0:32 ` [PATCH 17/18] kvm: Provide config option for enabling KVM trace events Jan Kara
2010-03-23 0:32 ` [PATCH 18/18] Create config option for enabling IRQ tracepoints Jan Kara
2010-03-23 1:04 ` [PATCH 0/18] Allow different tracers to be compiled independently Frederic Weisbecker
2010-03-23 3:34 ` Theodore Tso
2010-03-23 8:05 ` Ingo Molnar
2010-03-23 12:27 ` Mathieu Desnoyers
2010-03-23 13:18 ` Steven Rostedt
2010-03-26 0:20 ` Jan Kara
2010-03-26 19:09 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='89kc63$gdp6nr@fmsmga002.fm.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=dri-devel@lists.sourceforge.net \
--cc=jack@suse.cz \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox