From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 535D5C433FE for ; Tue, 18 Oct 2022 13:19:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230376AbiJRNTk (ORCPT ); Tue, 18 Oct 2022 09:19:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57160 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230369AbiJRNTd (ORCPT ); Tue, 18 Oct 2022 09:19:33 -0400 Received: from aposti.net (aposti.net [89.234.176.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 61E3DB7CB; Tue, 18 Oct 2022 06:19:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=crapouillou.net; s=mail; t=1666099169; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HN6qEph+YykdsQG5bbLmu5Q4ymal6rx7oLABFA4amOY=; b=KKDanF8wUwyf7bcqIa5qwhcaZ/EbzxJtTa0PYmVYyQ0xMFSecaYtvOqkKj91KGh/CVuxpy IvKjHQRD/WMpTbTCcifuRzuAOLWwSRXuvQh5n7ZGVeHz47DOpeAQhy7Sx6cn996I8Vv8jA RDSm+AAtja9p8LWi5s77Die5rk66K84= Date: Tue, 18 Oct 2022 14:19:20 +0100 From: Paul Cercueil Subject: Re: [PATCH v2 2/2] dmaengine: JZ4780: Add support for the JZ4755. To: Siarhei Volkau Cc: Vinod Koul , Rob Herring , Krzysztof Kozlowski , dmaengine@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org Message-Id: <8CAYJR.MSXCGTKEB37V2@crapouillou.net> In-Reply-To: <20221016151256.3021729-3-lis8215@gmail.com> References: <20221016151256.3021729-1-lis8215@gmail.com> <20221016151256.3021729-3-lis8215@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Siarhei, Le dim., oct. 16 2022 at 18:12:56 +0300, Siarhei Volkau=20 a =E9crit : > The JZ4755 has 4 DMA channels per DMA unit, two idential DMA units. >=20 > The JZ4755 has the similar DMA engine to JZ4725b, so I assume it has=20 > the > same bug as JZ4725b, see commit a40c94be2336. >=20 > Signed-off-by: Siarhei Volkau Reviewed-by: Paul Cercueil Cheers, -Paul > --- > drivers/dma/dma-jz4780.c | 8 ++++++++ > 1 file changed, 8 insertions(+) >=20 > diff --git a/drivers/dma/dma-jz4780.c b/drivers/dma/dma-jz4780.c > index 2a483802d..9c1a6e9a9 100644 > --- a/drivers/dma/dma-jz4780.c > +++ b/drivers/dma/dma-jz4780.c > @@ -1038,6 +1038,13 @@ static const struct jz4780_dma_soc_data=20 > jz4725b_dma_soc_data =3D { > JZ_SOC_DATA_BREAK_LINKS, > }; >=20 > +static const struct jz4780_dma_soc_data jz4755_dma_soc_data =3D { > + .nb_channels =3D 4, > + .transfer_ord_max =3D 5, > + .flags =3D JZ_SOC_DATA_PER_CHAN_PM | JZ_SOC_DATA_NO_DCKES_DCKEC | > + JZ_SOC_DATA_BREAK_LINKS, > +}; > + > static const struct jz4780_dma_soc_data jz4760_dma_soc_data =3D { > .nb_channels =3D 5, > .transfer_ord_max =3D 6, > @@ -1101,6 +1108,7 @@ static const struct jz4780_dma_soc_data=20 > x1830_dma_soc_data =3D { > static const struct of_device_id jz4780_dma_dt_match[] =3D { > { .compatible =3D "ingenic,jz4740-dma", .data =3D &jz4740_dma_soc_data=20 > }, > { .compatible =3D "ingenic,jz4725b-dma", .data =3D=20 > &jz4725b_dma_soc_data }, > + { .compatible =3D "ingenic,jz4755-dma", .data =3D &jz4755_dma_soc_data=20 > }, > { .compatible =3D "ingenic,jz4760-dma", .data =3D &jz4760_dma_soc_data=20 > }, > { .compatible =3D "ingenic,jz4760-mdma", .data =3D=20 > &jz4760_mdma_soc_data }, > { .compatible =3D "ingenic,jz4760-bdma", .data =3D=20 > &jz4760_bdma_soc_data }, > -- > 2.36.1 >=20