From: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
To: Shen Lichuan <shenlichuan@vivo.com>, jgg@ziepe.ca, leon@kernel.org
Cc: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
opensource.kernel@vivo.com
Subject: Re: [PATCH v1] IB/qib: Use max() macro
Date: Tue, 27 Aug 2024 11:00:11 -0400 [thread overview]
Message-ID: <8a113fab-d58b-42e2-9c7c-e84dd2f27d99@cornelisnetworks.com> (raw)
In-Reply-To: <20240827082254.72321-1-shenlichuan@vivo.com>
On 8/27/24 4:22 AM, Shen Lichuan wrote:
> Use the max() macro to simplify the function and improve
> its readability.
>
> Signed-off-by: Shen Lichuan <shenlichuan@vivo.com>
> ---
> drivers/infiniband/hw/qib/qib_iba7220.c | 2 +-
> drivers/infiniband/hw/qib/qib_iba7322.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/infiniband/hw/qib/qib_iba7220.c b/drivers/infiniband/hw/qib/qib_iba7220.c
> index 78dfe98ebcf7..4c96b66a93b5 100644
> --- a/drivers/infiniband/hw/qib/qib_iba7220.c
> +++ b/drivers/infiniband/hw/qib/qib_iba7220.c
> @@ -4094,7 +4094,7 @@ static int qib_init_7220_variables(struct qib_devdata *dd)
> updthresh = 8U; /* update threshold */
> if (dd->flags & QIB_HAS_SEND_DMA) {
> dd->cspec->sdmabufcnt = dd->piobcnt4k;
> - sbufs = updthresh > 3 ? updthresh : 3;
> + sbufs = max(updthresh, 3);
> } else {
> dd->cspec->sdmabufcnt = 0;
> sbufs = dd->piobcnt4k;
> diff --git a/drivers/infiniband/hw/qib/qib_iba7322.c b/drivers/infiniband/hw/qib/qib_iba7322.c
> index 9db29916e35a..5a059ec08780 100644
> --- a/drivers/infiniband/hw/qib/qib_iba7322.c
> +++ b/drivers/infiniband/hw/qib/qib_iba7322.c
> @@ -6633,7 +6633,7 @@ static int qib_init_7322_variables(struct qib_devdata *dd)
> */
> if (dd->flags & QIB_HAS_SEND_DMA) {
> dd->cspec->sdmabufcnt = dd->piobcnt4k;
> - sbufs = updthresh > 3 ? updthresh : 3;
> + sbufs = max(updthresh, 3);
> } else {
> dd->cspec->sdmabufcnt = 0;
> sbufs = dd->piobcnt4k;
I don't see how this improves readability or makes the function simpler. I'm not
opposed to it, just don't see it as an improvement.
-Denny
next prev parent reply other threads:[~2024-08-27 15:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-27 8:22 [PATCH v1] IB/qib: Use max() macro Shen Lichuan
2024-08-27 15:00 ` Dennis Dalessandro [this message]
2024-08-29 8:58 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a113fab-d58b-42e2-9c7c-e84dd2f27d99@cornelisnetworks.com \
--to=dennis.dalessandro@cornelisnetworks.com \
--cc=jgg@ziepe.ca \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=opensource.kernel@vivo.com \
--cc=shenlichuan@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox