From: Daniel Bristot de Oliveira <bristot@kernel.org>
To: Petr Mladek <pmladek@suse.com>,
Alessandro Carminati <alessandro.carminati@gmail.com>
Cc: Kris Van Hees <kris.van.hees@oracle.com>,
Masami Hiramatsu <mhiramat@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Josh Poimboeuf <jpoimboe@kernel.org>,
Masahiro Yamada <masahiroy@kernel.org>,
Luis Chamberlain <mcgrof@kernel.org>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Nicolas Schier <nicolas@fjasle.eu>,
Alexander Lobakin <aleksander.lobakin@intel.com>,
Nick Alcock <nick.alcock@oracle.com>,
Eugene Loh <eugene.loh@oracle.com>,
Francis Laniel <flaniel@linux.microsoft.com>,
Viktor Malik <vmalik@redhat.com>,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCH v5] scripts/link-vmlinux.sh: Add alias to duplicate symbols for kallsyms
Date: Mon, 16 Oct 2023 14:42:16 +0200 [thread overview]
Message-ID: <8a1c19dc-0a4f-4079-b2df-704ae647b1f8@kernel.org> (raw)
In-Reply-To: <ZSU2dTTfLqIydSQU@alley>
>> In any case, as you've pointed out, duplicates can arise from names in code
>> that is not intended to be a module.
>> Therefore, relying solely on the module name would not fully address the
>> problem you initially aimed to solve.
>
> From my POV:
>
> The source path and the line number is enough to distinguish duplicate
> symbols even in modules.
>
> The added module name would just add extra complexity into the kernel
> and tools parsing and using the alias. The tracing tools would need to
> handle the source path and line number anyway for symbols duplicated
> within same module/vmlinux.
>
> Adding module name for builtin modules might be misleading. It won't
> be clear which symbols are in vmlinux binary and which are in
> real modules.
+1
-- Daniel
prev parent reply other threads:[~2023-10-16 12:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-27 17:35 [PATCH v5] scripts/link-vmlinux.sh: Add alias to duplicate symbols for kallsyms Alessandro Carminati (Red Hat)
2023-09-29 11:28 ` Masami Hiramatsu
2023-09-29 16:03 ` Alessandro Carminati
2023-10-02 14:27 ` Francis Laniel
2023-10-05 16:24 ` Kris Van Hees
2023-10-06 3:11 ` Kris Van Hees
2023-10-09 13:14 ` Alessandro Carminati
2023-10-10 11:33 ` Petr Mladek
2023-10-10 14:48 ` Kris Van Hees
2023-10-16 12:42 ` Daniel Bristot de Oliveira [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a1c19dc-0a4f-4079-b2df-704ae647b1f8@kernel.org \
--to=bristot@kernel.org \
--cc=aleksander.lobakin@intel.com \
--cc=alessandro.carminati@gmail.com \
--cc=eugene.loh@oracle.com \
--cc=flaniel@linux.microsoft.com \
--cc=jpoimboe@kernel.org \
--cc=kris.van.hees@oracle.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=mcgrof@kernel.org \
--cc=mhiramat@kernel.org \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=nick.alcock@oracle.com \
--cc=nicolas@fjasle.eu \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=vmalik@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox