From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965228AbcHDXg3 (ORCPT ); Thu, 4 Aug 2016 19:36:29 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:55962 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934723AbcHDXg0 (ORCPT ); Thu, 4 Aug 2016 19:36:26 -0400 X-IBM-Helo: d23dlp01.au.ibm.com X-IBM-MailFrom: andrew.donnellan@au1.ibm.com X-IBM-RcptTo: linux-edac@vger.kernel.org;linux-kernel@vger.kernel.org Subject: Re: [Patch v3 01/11] arch/powerpc/pci: Fix compiling error for mpc85xx_edac To: York Sun , linux-edac@vger.kernel.org References: <1470351518-22404-1-git-send-email-york.sun@nxp.com> <1470351518-22404-2-git-send-email-york.sun@nxp.com> Cc: morbidrsa@gmail.com, oss@buserror.net, stuart.yoder@nxp.com, bp@alien8.de, Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Kevin Hao , Yinghai Lu , Bjorn Helgaas , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org From: Andrew Donnellan Date: Fri, 5 Aug 2016 09:36:15 +1000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.1.0 MIME-Version: 1.0 In-Reply-To: <1470351518-22404-2-git-send-email-york.sun@nxp.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16080423-0044-0000-0000-000001CA3A66 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16080423-0045-0000-0000-00000542F4FD Message-Id: <8a1cbb34-1e5a-a7ee-1fc6-e6bd5db34aa1@au1.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-08-04_15:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1608040250 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/08/16 08:58, York Sun wrote: > Two symbols are missing if mpc85xx_edac driver is compiled as module. > > Signed-off-by: York Sun Good catch! One comment below. Reviewed-by: Andrew Donnellan > /* > * Reads the interrupt pin to determine if interrupt is use by card. > @@ -1585,6 +1586,7 @@ int early_find_capability(struct pci_controller *hose, int bus, int devfn, > { > return pci_bus_find_capability(fake_pci_bus(hose, bus), devfn, cap); > } > +EXPORT_SYMBOL(early_find_capability); It'd be nicer for this to be renamed as "pci_early_find_capability" or something like that with a "namespace", I think. Andrew -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnellan@au1.ibm.com IBM Australia Limited