From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B9F9E75435 for ; Tue, 3 Oct 2023 06:56:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239385AbjJCG4e (ORCPT ); Tue, 3 Oct 2023 02:56:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56986 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239363AbjJCG4Y (ORCPT ); Tue, 3 Oct 2023 02:56:24 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9DA31171F for ; Mon, 2 Oct 2023 23:55:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1696316115; x=1727852115; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=eMdkPedttFDR2L5zieOFQ8KsShh5j2eTTclPL8AeZcw=; b=jRPQjBjekhwtWIkT1sEQYEd6NHBdc30jafaivboUbj8JgJjAJ+qjMidn dslxpXBxjOjBiJh3TJcg6VwlLZZC4Dfg/OOhOddDrIgsD/FAtihbOW72W 4Fcp+qoB9iPYmKk7Kz7x60Qn3Zbr+UFb0SwlHJTlWzzZjBxlMxZYYozmY IyyNXt/93q75oBs1LL3QXUy/546y4QWqx8Cs8YAf/v7j15erPRvAOwDR5 jirzKujsf2lQnMmMu/mS9nFyigLJd+shbL5qw8bPNhPcOXsCLcBjftswg e970GjmlNwK6U4bLvhmxivquSjRLtsltIkq39lMf5Dfox0/Rj0kdRXxiP A==; X-IronPort-AV: E=McAfee;i="6600,9927,10851"; a="381689187" X-IronPort-AV: E=Sophos;i="6.03,196,1694761200"; d="scan'208";a="381689187" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Oct 2023 23:55:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10851"; a="874617410" X-IronPort-AV: E=Sophos;i="6.03,196,1694761200"; d="scan'208";a="874617410" Received: from aslawinx-mobl.ger.corp.intel.com (HELO [10.94.0.91]) ([10.94.0.91]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Oct 2023 23:55:10 -0700 Message-ID: <8a506cfa-7274-b760-1fc1-60d0e5b75a8b@linux.intel.com> Date: Tue, 3 Oct 2023 08:55:08 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v5 10/12] ASoC: Intel: Skylake: Move snd_hdac_i915_init to before probe_work. To: Maarten Lankhorst , alsa-devel@alsa-project.org Cc: Mark Brown , Kai Vehmanen , Jaroslav Kysela , Takashi Iwai , Cezary Rojewski , Pierre-Louis Bossart , Liam Girdwood , Peter Ujfalusi , Bard Liao , Ranjani Sridharan , Daniel Baluta , linux-kernel@vger.kernel.org, sound-open-firmware@alsa-project.org References: <20230929145123.233838-1-maarten.lankhorst@linux.intel.com> <20231002165202.17863-1-maarten.lankhorst@linux.intel.com> Content-Language: en-US From: =?UTF-8?Q?Amadeusz_S=c5=82awi=c5=84ski?= In-Reply-To: <20231002165202.17863-1-maarten.lankhorst@linux.intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/2/2023 6:52 PM, Maarten Lankhorst wrote: > Now that we can use -EPROBE_DEFER, it's no longer required to spin off > the snd_hdac_i915_init into a workqueue. It's likely the whole workqueue > can be destroyed, but I don't have the means to test this. > > Removing the workqueue would simplify init even further, but is left > as exercise for the reviewer. > > Signed-off-by: Maarten Lankhorst > Acked-by: Mark Brown > Reviewed-by: Kai Vehmanen > Reviewed-by: Amadeusz Sławiński > --- Isn't the convention that your Signed-off should be last when you are sending the patches? Or does it only apply to Signed-off lines themselves and other lines can be anywhere?