From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
To: Johannes Roith <johannes@gnu-linux.rocks>, jikos@kernel.org
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] hid-mcp2200 - updated hid-id.h
Date: Sun, 11 Jun 2023 21:13:33 +0200 [thread overview]
Message-ID: <8a52595f-085b-3b68-0082-e9f9487dd331@wanadoo.fr> (raw)
In-Reply-To: <20230611164811.1388-2-johannes@gnu-linux.rocks>
Le 11/06/2023 à 18:48, Johannes Roith a écrit :
> Added Product ID for Microchip MCP2200 so the module can be compiled
> correctly.
>
> Signed-off-by: Johannes Roith <johannes@gnu-linux.rocks>
>
> diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
> index 5d29abac2300..b48cb8224e0d 100644
> --- a/drivers/hid/hid-ids.h
> +++ b/drivers/hid/hid-ids.h
> @@ -912,6 +912,7 @@
> #define USB_DEVICE_ID_PICK16F1454_V2 0xf2f7
> #define USB_DEVICE_ID_LUXAFOR 0xf372
> #define USB_DEVICE_ID_MCP2221 0x00dd
> +#define USB_DEVICE_ID_MCP2221 0x00df
2 times USB_DEVICE_ID_MCP2221 with different values?
USB_DEVICE_ID_MCP2200?
Also this one should be merged with patch 1/2 or sent before the other
one, otherwise 1/2 can't compile.
CJ
>
> #define USB_VENDOR_ID_MICROSOFT 0x045e
> #define USB_DEVICE_ID_SIDEWINDER_GV 0x003b
next prev parent reply other threads:[~2023-06-11 19:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-11 16:48 [PATCH 1/2] hid-mcp2200 added driver for MCP2200 GPIOs Johannes Roith
2023-06-11 16:48 ` [PATCH 2/2] hid-mcp2200 - updated hid-id.h Johannes Roith
2023-06-11 18:43 ` kernel test robot
2023-06-11 18:53 ` kernel test robot
2023-06-11 19:13 ` Christophe JAILLET [this message]
2023-06-11 18:43 ` [PATCH 1/2] hid-mcp2200 added driver for MCP2200 GPIOs kernel test robot
2023-06-11 19:02 ` Christophe JAILLET
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a52595f-085b-3b68-0082-e9f9487dd331@wanadoo.fr \
--to=christophe.jaillet@wanadoo.fr \
--cc=jikos@kernel.org \
--cc=johannes@gnu-linux.rocks \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox