From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C73BF285CBC for ; Thu, 26 Feb 2026 15:45:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772120745; cv=none; b=HzOWtQeJvavrM4yOHVkDacXa6ltY5Tqf3U9fEH3qIi9l1Tr3J3xkZfpHB1sxGbCzvWZRwb8lt7qmvcC0BlWr0N+c95ZfVZOg2tjdK3ulpzE52uU7/84605piARQRN1vkwEdD2KdonpzO/PdzehN/Iam/9WTl38io9JeqWhaIWjY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772120745; c=relaxed/simple; bh=xrU8eCDmAt74z4SHgfuBriV+ZahnT3PtEGbapliyWH8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=NNqMNtD44bKnpCMYQJGE7ib/bkhYhZbU7CNsxpetmR9xHnM1/n59nsnBD/tMDsKrBDMxQxMiMcRxdHhTAuyhRURdNQA9nT9SJL+yJndudFqVdYJCPtzfJiMNNauct+e0FVOpQ88CuIsHJN22c63BCWzFCv0gL56Adl2eYKdZgCM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Clbv3rTx; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Clbv3rTx" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E829AC116C6; Thu, 26 Feb 2026 15:45:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772120745; bh=xrU8eCDmAt74z4SHgfuBriV+ZahnT3PtEGbapliyWH8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Clbv3rTxl5B7aDaexrscHTgYx/U/l4RM2L0DhFFS97w8Fg52ZNruvxRJc6o/okHlY k9ZIq2ApyP8nmPRxaRR+SI7bTpU9EFPOQTZ8AIIM+ft+3i+G8qkVZ0f0fsqY1NAzSP H2uOkV9c7yq5atNbOrDak0D8HXltMo8K5IKtMry6QNwYNe64v9hAzy28lu12xs2zRV /7LiOa6TnNAL3/PxPEhQodpn3O7zHxMcd3ax/5y4Zw9Y43OwAhtuAS898jyQkwJY1e nA1aEbBUK5GQJiPko6rC7JaZ17fuIrFMp6/kP/UxYzrFeoLne3Qkc7R3BVnxrHCAh3 Q0rSUTLxnOTfA== Message-ID: <8a5277e0-d70e-4849-9763-ed90e350a118@kernel.org> Date: Thu, 26 Feb 2026 16:45:40 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH mm-new v8 2/4] mm: khugepaged: refine scan progress number To: Vernon Yang , akpm@linux-foundation.org Cc: Wei Yang , lorenzo.stoakes@oracle.com, ziy@nvidia.com, dev.jain@arm.com, baohua@kernel.org, lance.yang@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Vernon Yang References: <20260221093918.1456187-1-vernon2gm@gmail.com> <20260221093918.1456187-3-vernon2gm@gmail.com> <20260224035247.r6mxsfcpiev4wnce@master> <1da56bbb-9211-42d7-9b08-3ee56d2b538d@kernel.org> From: "David Hildenbrand (Arm)" Content-Language: en-US Autocrypt: addr=david@kernel.org; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzS5EYXZpZCBIaWxk ZW5icmFuZCAoQ3VycmVudCkgPGRhdmlkQGtlcm5lbC5vcmc+wsGQBBMBCAA6AhsDBQkmWAik AgsJBBUKCQgCFgICHgUCF4AWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaYJt/AIZAQAKCRBN 3hD3AP+DWriiD/9BLGEKG+N8L2AXhikJg6YmXom9ytRwPqDgpHpVg2xdhopoWdMRXjzOrIKD g4LSnFaKneQD0hZhoArEeamG5tyo32xoRsPwkbpIzL0OKSZ8G6mVbFGpjmyDLQCAxteXCLXz ZI0VbsuJKelYnKcXWOIndOrNRvE5eoOfTt2XfBnAapxMYY2IsV+qaUXlO63GgfIOg8RBaj7x 3NxkI3rV0SHhI4GU9K6jCvGghxeS1QX6L/XI9mfAYaIwGy5B68kF26piAVYv/QZDEVIpo3t7 /fjSpxKT8plJH6rhhR0epy8dWRHk3qT5tk2P85twasdloWtkMZ7FsCJRKWscm1BLpsDn6EQ4 jeMHECiY9kGKKi8dQpv3FRyo2QApZ49NNDbwcR0ZndK0XFo15iH708H5Qja/8TuXCwnPWAcJ DQoNIDFyaxe26Rx3ZwUkRALa3iPcVjE0//TrQ4KnFf+lMBSrS33xDDBfevW9+Dk6IISmDH1R HFq2jpkN+FX/PE8eVhV68B2DsAPZ5rUwyCKUXPTJ/irrCCmAAb5Jpv11S7hUSpqtM/6oVESC 3z/7CzrVtRODzLtNgV4r5EI+wAv/3PgJLlMwgJM90Fb3CB2IgbxhjvmB1WNdvXACVydx55V7 LPPKodSTF29rlnQAf9HLgCphuuSrrPn5VQDaYZl4N/7zc2wcWM7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 2/26/26 15:31, Vernon Yang wrote: > On Wed, Feb 25, 2026 at 03:29:05PM +0100, David Hildenbrand (Arm) wrote: >> On 2/25/26 15:25, Vernon Yang wrote: >>> >>> Thank you for suggestion. >>> >>> Placing it inside "struct collapse_control" makes the overall code >>> simpler, there also coincidentally has a 4-bytes hole, as shown below: >>> >>> struct collapse_control { >>> bool is_khugepaged; /* 0 1 */ >>> >>> /* XXX 3 bytes hole, try to pack */ >>> >>> u32 node_load[64]; /* 4 256 */ >>> >>> /* XXX 4 bytes hole, try to pack */ >>> >>> /* --- cacheline 4 boundary (256 bytes) was 8 bytes ago --- */ >>> nodemask_t alloc_nmask; /* 264 8 */ >>> >>> /* size: 272, cachelines: 5, members: 3 */ >>> /* sum members: 265, holes: 2, sum holes: 7 */ >>> /* last cacheline: 16 bytes */ >>> }; >>> >>> But regardless of khugepaged or madvise(MADV_COLLAPSE), "cur_progress" >>> will be counted, while madvise(MADV_COLLAPSE) actually does not need to >>> be counted. >>> >>> David, do we want to place "cur_progress" inside the "struct collapse_control"? >> >> Might end up looking nicer code-wise. But the reset semantics (within a >> pmd) are a bit weird. >> >>> If Yes, it would be better to rename "cur_progress" to "pmd_progress", >>> as show below: >>> >> >> "pmd_progress" is misleading. "progress_in_pmd" might be clearer. >> >> Play with it to see if it looks better :) > > Hi Andrew, David, > > Based on previous discussions [1], v2 as follow, and testing shows the > same performance benefits. Just make code cleaner, no function changes. > > If David has no further revisions, Andrew, could you please squash the > following clean into this patch? If you prefer a new version, please let > me know. Thanks. Do we also have to update the resulting patch description? Patch itself LGTM. -- Cheers, David