public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: ChenXiaoSong <chenxiaosong.chenxiaosong@linux.dev>
To: sfrench@samba.org, smfrench@gmail.com, linkinjeon@kernel.org,
	linkinjeon@samba.org
Cc: linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org,
	liuzhengyuan@kylinos.cn, huhai@kylinos.cn, liuyun01@kylinos.cn
Subject: Re: [PATCH 00/30] smb: improve search speed of SMB1 maperror
Date: Wed, 10 Dec 2025 12:32:23 +0800	[thread overview]
Message-ID: <8a5f7591-14cf-4dcf-86e6-9684a3e9dcae@linux.dev> (raw)
In-Reply-To: <20251208062100.3268777-1-chenxiaosong.chenxiaosong@linux.dev>

Hi Steve and Namjae,

I have tested all patches using KUnit tests, xfstests, and smbtorture, 
and no additional test failures were observed. The detailed test results 
can be found in: https://chenxiaosong.com/en/smb-test-20251210.html

For more detailed information about the patches to be reviewed, please 
see the link: https://chenxiaosong.com/en/smb-patch.html

Thanks,
ChenXiaoSong.

On 12/8/25 14:20, chenxiaosong.chenxiaosong@linux.dev wrote:
> From: ChenXiaoSong <chenxiaosong@kylinos.cn>
> 
> Before applying this patchset, the patchset ("smb: improve search speed of SMB2 maperror") must
> be applied first, which introduces `CONFIG_SMB_KUNIT_TESTS` and avoids some conflicts in `fs/smb/client/cifsfs.c`:
> https://chenxiaosong.com/lkml-improve-search-speed-of-smb2-maperror.html (Redirect to the LKML link)
> 
> When searching for the last element, the comparison counts are shown in the table below:
> 
> +--------------------+--------+--------+
> |                    |Before  |After   |
> |                    |Patchset|Patchset|
> +--------------------+--------+--------+
> | ntstatus_to_dos_map|   525  |    9   |
> +--------------------+--------+--------+
> |             nt_errs|   516  |    9   |
> +--------------------+--------+--------+
> |mapping_table_ERRDOS|    39  |    5   |
> +--------------------+--------+--------+
> |mapping_table_ERRSRV|    37  |    5   |
> +--------------------+--------+--------+
> 
> ChenXiaoSong (30):
>    smb/client: fix NT_STATUS_NO_DATA_DETECTED value
>    smb/client: fix NT_STATUS_DEVICE_DOOR_OPEN value
>    smb/client: fix NT_STATUS_UNABLE_TO_FREE_VM value
>    smb/server: remove unused nterr.h
>    smb/client: add 4 NT error code definitions
>    smb/client: add parentheses to NT error code definitions containing
>      bitwise OR operator
>    smb/client: introduce DEFINE_CMP_FUNC()
>    smb/client: sort ntstatus_to_dos_map array
>    smb/client: create netmisc_test.c and introduce
>      DEFINE_CHECK_SORT_FUNC()
>    smb/client: introduce KUnit test to check sort result of
>      ntstatus_to_dos_map array
>    smb/client: introduce DEFINE_SEARCH_FUNC()
>    smb/client: use bsearch() to find target in ntstatus_to_dos_map array
>    smb/client: remove useless elements from ntstatus_to_dos_map array
>    smb/client: introduce DEFINE_CHECK_SEARCH_FUNC()
>    smb/client: introduce KUnit test to check search result of
>      ntstatus_to_dos_map array
>    smb/client: sort nt_errs array
>    smb/client: introduce KUnit test to check sort result of nt_errs array
>    smb/client: use bsearch() to find target in nt_errs array
>    smb/client: remove useless elements from nt_errs array
>    smb/client: introduce KUnit test to check search result of nt_errs
>      array
>    smb/client: sort mapping_table_ERRDOS array
>    smb/client: introduce KUnit test to check sort result of
>      mapping_table_ERRDOS array
>    smb/client: use bsearch() to find target in mapping_table_ERRDOS array
>    smb/client: remove useless elements from mapping_table_ERRDOS array
>    smb/client: introduce KUnit test to check search result of
>      mapping_table_ERRDOS array
>    smb/client: sort mapping_table_ERRSRV array
>    smb/client: introduce KUnit test to check sort result of
>      mapping_table_ERRSRV array
>    smb/client: use bsearch() to find target in mapping_table_ERRSRV array
>    smb/client: remove useless elements from mapping_table_ERRSRV array
>    smb/client: introduce KUnit test to check search result of
>      mapping_table_ERRSRV array
> 
>   fs/smb/client/cifsfs.c       |    2 +
>   fs/smb/client/cifsproto.h    |    1 +
>   fs/smb/client/netmisc.c      |  155 ++++--
>   fs/smb/client/netmisc_test.c |  114 ++++
>   fs/smb/client/nterr.c        |   12 +-
>   fs/smb/client/nterr.h        | 1017 +++++++++++++++++-----------------
>   fs/smb/server/nterr.h        |  543 ------------------
>   fs/smb/server/smb2misc.c     |    1 -
>   fs/smb/server/smb_common.h   |    1 -
>   9 files changed, 739 insertions(+), 1107 deletions(-)
>   create mode 100644 fs/smb/client/netmisc_test.c
>   delete mode 100644 fs/smb/server/nterr.h
> 


      parent reply	other threads:[~2025-12-10  4:33 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-08  6:20 [PATCH 00/30] smb: improve search speed of SMB1 maperror chenxiaosong.chenxiaosong
2025-12-08  6:20 ` [PATCH 01/30] smb/client: fix NT_STATUS_NO_DATA_DETECTED value chenxiaosong.chenxiaosong
2025-12-09  0:17   ` ChenXiaoSong
2025-12-09  0:29     ` Steve French
2025-12-09  0:45       ` ChenXiaoSong
2025-12-08  6:20 ` [PATCH 02/30] smb/client: fix NT_STATUS_DEVICE_DOOR_OPEN value chenxiaosong.chenxiaosong
2025-12-08  6:20 ` [PATCH 03/30] smb/client: fix NT_STATUS_UNABLE_TO_FREE_VM value chenxiaosong.chenxiaosong
2025-12-08  6:20 ` [PATCH 04/30] smb/server: remove unused nterr.h chenxiaosong.chenxiaosong
2025-12-08  6:20 ` [PATCH 05/30] smb/client: add 4 NT error code definitions chenxiaosong.chenxiaosong
2025-12-08  6:20 ` [PATCH 06/30] smb/client: add parentheses to NT error code definitions containing bitwise OR operator chenxiaosong.chenxiaosong
2025-12-08  6:20 ` [PATCH 07/30] smb/client: introduce DEFINE_CMP_FUNC() chenxiaosong.chenxiaosong
2025-12-08  6:20 ` [PATCH 08/30] smb/client: sort ntstatus_to_dos_map array chenxiaosong.chenxiaosong
2025-12-08  6:20 ` [PATCH 09/30] smb/client: create netmisc_test.c and introduce DEFINE_CHECK_SORT_FUNC() chenxiaosong.chenxiaosong
2025-12-08  6:20 ` [PATCH 10/30] smb/client: introduce KUnit test to check sort result of ntstatus_to_dos_map array chenxiaosong.chenxiaosong
2025-12-08  6:20 ` [PATCH 11/30] smb/client: introduce DEFINE_SEARCH_FUNC() chenxiaosong.chenxiaosong
2025-12-08  6:20 ` [PATCH 12/30] smb/client: use bsearch() to find target in ntstatus_to_dos_map array chenxiaosong.chenxiaosong
2025-12-08  6:20 ` [PATCH 13/30] smb/client: remove useless elements from " chenxiaosong.chenxiaosong
2025-12-08  6:20 ` [PATCH 14/30] smb/client: introduce DEFINE_CHECK_SEARCH_FUNC() chenxiaosong.chenxiaosong
2025-12-08  6:20 ` [PATCH 15/30] smb/client: introduce KUnit test to check search result of ntstatus_to_dos_map array chenxiaosong.chenxiaosong
2025-12-08  6:20 ` [PATCH 16/30] smb/client: sort nt_errs array chenxiaosong.chenxiaosong
2025-12-08  6:20 ` [PATCH 17/30] smb/client: introduce KUnit test to check sort result of " chenxiaosong.chenxiaosong
2025-12-08  6:20 ` [PATCH 18/30] smb/client: use bsearch() to find target in " chenxiaosong.chenxiaosong
2025-12-08  6:20 ` [PATCH 19/30] smb/client: remove useless elements from " chenxiaosong.chenxiaosong
2025-12-08  6:20 ` [PATCH 20/30] smb/client: introduce KUnit test to check search result of " chenxiaosong.chenxiaosong
2025-12-08  6:20 ` [PATCH 21/30] smb/client: sort mapping_table_ERRDOS array chenxiaosong.chenxiaosong
2025-12-08  6:20 ` [PATCH 22/30] smb/client: introduce KUnit test to check sort result of " chenxiaosong.chenxiaosong
2025-12-08  6:20 ` [PATCH 23/30] smb/client: use bsearch() to find target in " chenxiaosong.chenxiaosong
2025-12-08  6:20 ` [PATCH 24/30] smb/client: remove useless elements from " chenxiaosong.chenxiaosong
2025-12-08  6:20 ` [PATCH 25/30] smb/client: introduce KUnit test to check search result of " chenxiaosong.chenxiaosong
2025-12-08  6:20 ` [PATCH 26/30] smb/client: sort mapping_table_ERRSRV array chenxiaosong.chenxiaosong
2025-12-08  6:20 ` [PATCH 27/30] smb/client: introduce KUnit test to check sort result of " chenxiaosong.chenxiaosong
2025-12-08  6:20 ` [PATCH 28/30] smb/client: use bsearch() to find target in " chenxiaosong.chenxiaosong
2025-12-08  6:20 ` [PATCH 29/30] smb/client: remove useless elements from " chenxiaosong.chenxiaosong
2025-12-08  6:21 ` [PATCH 30/30] smb/client: introduce KUnit test to check search result of " chenxiaosong.chenxiaosong
2025-12-09 23:41 ` [PATCH 00/30] smb: improve search speed of SMB1 maperror Steve French
2025-12-10  2:48   ` ChenXiaoSong
2025-12-10  4:32 ` ChenXiaoSong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8a5f7591-14cf-4dcf-86e6-9684a3e9dcae@linux.dev \
    --to=chenxiaosong.chenxiaosong@linux.dev \
    --cc=huhai@kylinos.cn \
    --cc=linkinjeon@kernel.org \
    --cc=linkinjeon@samba.org \
    --cc=linux-cifs@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=liuyun01@kylinos.cn \
    --cc=liuzhengyuan@kylinos.cn \
    --cc=sfrench@samba.org \
    --cc=smfrench@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox