From: Chris Goldsworthy <cgoldswo@codeaurora.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
linux-kernel@vger.kernel.org,
Vinayak Menon <vinmenon@codeaurora.org>,
linux-kernel-owner@vger.kernel.org
Subject: Re: [PATCH v2] mm: cma: indefinitely retry allocations in cma_alloc
Date: Mon, 14 Sep 2020 11:45:26 -0700 [thread overview]
Message-ID: <8a736e7e213531c1894e17552152becb@codeaurora.org> (raw)
In-Reply-To: <60e99abb-7f69-c585-ff9f-76ebe6a81de6@infradead.org>
On 2020-09-11 14:42, Randy Dunlap wrote:
> On 9/11/20 2:37 PM, Florian Fainelli wrote:
>>
>> I am by no means an authoritative CMA person but this behavior does
>> not seem acceptable, there is no doubt the existing one is sub-optimal
>> under specific circumstances, but an indefinite retry, as well as a
>> 100ms sleep appear to be arbitrary at best. How about you introduce a
>> parameter that allows the tuning of the number of retries and/or delay
>> between retries?
>
> Also:
>
> You should send your patch to linux-mm@kvack.org -- that's where
> most memory management type patches are reviewed.
>
> You should also send your patch to someone who could actually merge
> it into the kernel source tree -- assuming that's what you want to
> happen.
>
> Try scripts/get_mainttainer.pl on your patch to see what it says.
>
> And if you are going to use a "cover letter" or "introductory email"
> before
> the actual patch, the second (patch(es)) should be sent chained to the
> first email. git send-email should do this for you.
Hi Randy,
git send-email was not using the correct ID to generate a response to
the cover letter, and I'm not able to fathom why. This e-mail was
actually just sent out as a test to LKML as a test so I could figure out
how to resolve the issue, I wasn't actually expecting anyone to read
this. The actual e-mail, with the correct maintainer (Andrew Morton)
and mailing lists, as well as the summary of the discussion on the
patches so far, may be found here: https://lkml.org/lkml/2020/8/11/893
Thanks,
Chris.
--
The Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2020-09-14 18:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1599857630-23714-1-git-send-email-cgoldswo@codeaurora.org>
2020-09-11 20:54 ` [PATCH v2] mm: cma: indefinitely retry allocations in cma_alloc Chris Goldsworthy
2020-09-11 21:37 ` Florian Fainelli
2020-09-11 21:42 ` Randy Dunlap
2020-09-14 18:45 ` Chris Goldsworthy [this message]
2020-09-14 18:39 ` Chris Goldsworthy
[not found] <1599855850-11337-1-git-send-email-cgoldswo@codeaurora.org>
2020-09-11 20:24 ` Chris Goldsworthy
[not found] <06489716814387e7f147cf53d1b185a8@codeaurora.org>
[not found] ` <1599851809-4342-1-git-send-email-cgoldswo@codeaurora.org>
2020-09-11 19:17 ` Chris Goldsworthy
[not found] ` <010101747e998731-e49f209f-8232-4496-a9fc-2465334e70d7-000000@us-west-2.amazonses.com>
2020-09-14 9:31 ` David Hildenbrand
2020-09-14 18:33 ` Chris Goldsworthy
2020-09-14 21:52 ` Chris Goldsworthy
2020-09-15 7:53 ` David Hildenbrand
2020-09-17 17:26 ` Chris Goldsworthy
2020-09-17 17:54 ` Chris Goldsworthy
2020-09-24 5:13 ` Chris Goldsworthy
2020-09-28 7:39 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a736e7e213531c1894e17552152becb@codeaurora.org \
--to=cgoldswo@codeaurora.org \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel-owner@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=vinmenon@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox