From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A5DFC4167B for ; Fri, 1 Dec 2023 13:08:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378930AbjLANIc (ORCPT ); Fri, 1 Dec 2023 08:08:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39798 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1378918AbjLANIa (ORCPT ); Fri, 1 Dec 2023 08:08:30 -0500 Received: from mxout70.expurgate.net (mxout70.expurgate.net [194.37.255.70]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4689410D; Fri, 1 Dec 2023 05:08:37 -0800 (PST) Received: from [127.0.0.1] (helo=localhost) by relay.expurgate.net with smtp (Exim 4.92) (envelope-from ) id 1r93Fq-00E2ie-5o; Fri, 01 Dec 2023 14:08:26 +0100 Received: from [195.243.126.94] (helo=securemail.tdt.de) by relay.expurgate.net with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r93Fp-003jU8-5c; Fri, 01 Dec 2023 14:08:25 +0100 Received: from securemail.tdt.de (localhost [127.0.0.1]) by securemail.tdt.de (Postfix) with ESMTP id C5ECE240049; Fri, 1 Dec 2023 14:08:24 +0100 (CET) Received: from mail.dev.tdt.de (unknown [10.2.4.42]) by securemail.tdt.de (Postfix) with ESMTP id 2660F240040; Fri, 1 Dec 2023 14:08:24 +0100 (CET) Received: from mail.dev.tdt.de (localhost [IPv6:::1]) by mail.dev.tdt.de (Postfix) with ESMTP id 94C0821439; Fri, 1 Dec 2023 14:08:23 +0100 (CET) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 01 Dec 2023 14:08:23 +0100 From: Florian Eckert To: Lee Jones Cc: Eckert.Florian@googlemail.com, gregkh@linuxfoundation.org, jirislaby@kernel.org, pavel@ucw.cz, kabel@kernel.org, u.kleine-koenig@pengutronix.de, m.brock@vanmierlo.com, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, linux-leds@vger.kernel.org Subject: Re: [Patch v8 0/6] ledtrig-tty: add additional tty state evaluation In-Reply-To: <170142723852.3350831.6373465907279189004.b4-ty@kernel.org> References: <20231109085038.371977-1-fe@dev.tdt.de> <170142723852.3350831.6373465907279189004.b4-ty@kernel.org> Message-ID: <8acd2694429af4f7205db7d7bb39eab6@dev.tdt.de> X-Sender: fe@dev.tdt.de User-Agent: Roundcube Webmail/1.3.17 X-purgate-type: clean X-purgate: clean X-purgate-ID: 151534::1701436105-9B435DE9-7E10A24A/0/0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023-12-01 11:40, Lee Jones wrote: > On Thu, 09 Nov 2023 09:50:32 +0100, Florian Eckert wrote: >> Changes in v8: >> ============== >> - As requested by greg k-h [6], I have send the patch 2/7 of this >> series >> about the memory leak also to stable.vger.kernel.org [7]. This has >> already received a 'Reviewed-by' from Uwe [8]. >> - As requested by Maarten, I have adopted his suggestion to invert the >> LED >> blink, so that I do not have to save the 'state' in the tty data >> struct [9]. >> >> [...] > > Applied, thanks! > > [1/6] tty: add new helper function tty_get_tiocm > commit: 5d11a4709f552fa139c2439fead05daeb064a6f4 > [2/6] leds: ledtrig-tty: free allocated ttyname buffer on deactivate > (no commit info) > [3/6] leds: ledtrig-tty: change logging if get icount failed > (no commit info) > [4/6] leds: ledtrig-tty: replace mutex with completion > (no commit info) > [5/6] leds: ledtrig-tty: make rx tx activitate configurable > (no commit info) > [6/6] leds: ledtrig-tty: add additional line state evaluation > (no commit info) I think that was a mistake? Patchset v9 is the correct patchset [1]? Thanks for applying v9 [1] Best regards Florian Links: [1] https://lore.kernel.org/all/170142724145.3350831.5316050550655479371.b4-ty@kernel.org/