From: "Zhu, Lingshan" <lingshan.zhu@intel.com>
To: Leon Romanovsky <leon@kernel.org>
Cc: jasowang@redhat.com, mst@redhat.com, lulu@redhat.com,
virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] vDPA/ifcvf: bump version string to 1.0
Date: Mon, 8 Mar 2021 10:40:38 +0800 [thread overview]
Message-ID: <8b327a23-1d91-ecc0-d890-45aba52e2030@intel.com> (raw)
In-Reply-To: <YESWZ0Sjj1YMKETG@unreal>
Hi Leon,
Thanks for point this out, will send a V2 patchset delete it.
Thanks
Zhu Lingshan
On 3/7/2021 5:01 PM, Leon Romanovsky wrote:
> On Fri, Mar 05, 2021 at 10:20:00PM +0800, Zhu Lingshan wrote:
>> This commit bumps ifcvf driver version string to 1.0
>>
>> Signed-off-by: Zhu Lingshan <lingshan.zhu@intel.com>
>> ---
>> drivers/vdpa/ifcvf/ifcvf_main.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/vdpa/ifcvf/ifcvf_main.c b/drivers/vdpa/ifcvf/ifcvf_main.c
>> index fd5befc5cbcc..56a0974cf93c 100644
>> --- a/drivers/vdpa/ifcvf/ifcvf_main.c
>> +++ b/drivers/vdpa/ifcvf/ifcvf_main.c
>> @@ -14,7 +14,7 @@
>> #include <linux/sysfs.h>
>> #include "ifcvf_base.h"
>>
>> -#define VERSION_STRING "0.1"
>> +#define VERSION_STRING "1.0"
> Please delete it instead of bumping it.
> We are not supposed to use in-kernel version for years already.
> https://lore.kernel.org/ksummit-discuss/20170625072423.GR1248@mtr-leonro.local/
>
> Thanks
prev parent reply other threads:[~2021-03-08 2:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-05 14:19 [PATCH 0/3] vDPA/ifcvf: enables Intel C5000X-PL virtio-net Zhu Lingshan
2021-03-05 14:19 ` [PATCH 1/3] vDPA/ifcvf: get_vendor_id returns a device specific vendor id Zhu Lingshan
2021-03-08 2:51 ` Jason Wang
2021-03-05 14:19 ` [PATCH 2/3] vDPA/ifcvf: enable Intel C5000X-PL virtio-net for vDPA Zhu Lingshan
2021-03-08 2:53 ` Jason Wang
2021-03-05 14:20 ` [PATCH 3/3] vDPA/ifcvf: bump version string to 1.0 Zhu Lingshan
2021-03-07 9:01 ` Leon Romanovsky
2021-03-08 2:40 ` Zhu, Lingshan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b327a23-1d91-ecc0-d890-45aba52e2030@intel.com \
--to=lingshan.zhu@intel.com \
--cc=jasowang@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lulu@redhat.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox