The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Zhou Yanjie <zhouyanjie@wanyeetech.com>
To: Alexander Lobakin <alobakin@pm.me>,
	Kishon Vijay Abraham I <kishon@ti.com>,
	Vinod Koul <vkoul@kernel.org>
Cc: 漆鹏振 <aric.pzqi@ingenic.com>,
	"Paul Cercueil" <paul@crapouillou.net>,
	"Linus Torvalds" <torvalds@linux-foundation.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH phy] PHY: Ingenic: fix unconditional build of phy-ingenic-usb
Date: Wed, 23 Dec 2020 22:18:07 +0800	[thread overview]
Message-ID: <8b34319d-b085-853a-c2f8-384bd60f50ff@wanyeetech.com> (raw)
In-Reply-To: <20201222131021.4751-1-alobakin@pm.me>

Hi Alexander,

On 2020/12/22 下午9:10, Alexander Lobakin wrote:
> Currently drivers/phy/ingenic/Makefile adds phy-ingenic-usb to targets
> not depending on actual Kconfig symbol CONFIG_PHY_INGENIC_USB, so this
> driver always gets built[-in] on every system.
> Add missing dependency.
>
> Fixes: 31de313dfdcf ("PHY: Ingenic: Add USB PHY driver using generic PHY framework.")
> Signed-off-by: Alexander Lobakin <alobakin@pm.me>
> ---
>   drivers/phy/ingenic/Makefile | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)


Apologize for my carelessness, and

Tested-by: 周琰杰 (Zhou Yanjie) <zhouyanjie@wanyeetech.com>


Thanks and best regards!


> diff --git a/drivers/phy/ingenic/Makefile b/drivers/phy/ingenic/Makefile
> index 65d5ea00fc9d..1cb158d7233f 100644
> --- a/drivers/phy/ingenic/Makefile
> +++ b/drivers/phy/ingenic/Makefile
> @@ -1,2 +1,2 @@
>   # SPDX-License-Identifier: GPL-2.0
> -obj-y		+= phy-ingenic-usb.o
> +obj-$(CONFIG_PHY_INGENIC_USB)		+= phy-ingenic-usb.o

      parent reply	other threads:[~2020-12-23 14:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-22 13:10 [PATCH phy] PHY: Ingenic: fix unconditional build of phy-ingenic-usb Alexander Lobakin
2020-12-23  4:29 ` Vinod Koul
2020-12-23 14:18 ` Zhou Yanjie [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8b34319d-b085-853a-c2f8-384bd60f50ff@wanyeetech.com \
    --to=zhouyanjie@wanyeetech.com \
    --cc=alobakin@pm.me \
    --cc=aric.pzqi@ingenic.com \
    --cc=kishon@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paul@crapouillou.net \
    --cc=torvalds@linux-foundation.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox