Re: [PATCH v7 1/7] fs/resctrl: Tidy up the error path in resctrl_mkdir_event_configs()

["Moger, Babu" <bmoger@amd.com>]

Hi Ben,

On 5/6/2026 3:28 AM, Ben Horgan wrote:
> The error path in resctrl_mkdir_event_configs() is unnecessarily
> complicated. Simplify it to just return directly on error.
> 
> Signed-off-by: Ben Horgan <ben.horgan@arm.com>
> Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>
> ---
> Changes since v5:
> Correct order of the tags
> 
> Changes since v6:
> Add missing commit message separator,---
> ---
>   fs/resctrl/rdtgroup.c | 9 ++++-----
>   1 file changed, 4 insertions(+), 5 deletions(-)
> 
> diff --git a/fs/resctrl/rdtgroup.c b/fs/resctrl/rdtgroup.c
> index 5dfdaa6f9d8f..fb6999178fe2 100644
> --- a/fs/resctrl/rdtgroup.c
> +++ b/fs/resctrl/rdtgroup.c
> @@ -2333,20 +2333,19 @@ static int resctrl_mkdir_event_configs(struct rdt_resource *r, struct kernfs_nod
>   		kn_subdir2 = kernfs_create_dir(kn_subdir, mevt->name, kn_subdir->mode, mevt);
>   		if (IS_ERR(kn_subdir2)) {
>   			ret = PTR_ERR(kn_subdir2);
> -			goto out;
> +			return ret;

Minor nit. You can directly return like below.

return PTR_ERR(kn_subdir2);

Optional, only if there is another version.

Thanks
Babu