From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762499AbXHPNVA (ORCPT ); Thu, 16 Aug 2007 09:21:00 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758925AbXHPNTz (ORCPT ); Thu, 16 Aug 2007 09:19:55 -0400 Received: from hellhawk.shadowen.org ([80.68.90.175]:1276 "EHLO hellhawk.shadowen.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761970AbXHPNTx (ORCPT ); Thu, 16 Aug 2007 09:19:53 -0400 From: Andy Whitcroft To: linux-kernel@vger.kernel.org Cc: Randy Dunlap , Andrew Morton , Andy Whitcroft , Andy Whitcroft , Paul Mackerras , linuxppc-dev@ozlabs.org Subject: [PATCH 2/6] powerpc: hash_preload fails to preload under CONFIG_PPC_MM_SLICES References: InReply-To: Message-ID: <8b4c69b92d61b5a840468f07e0ec1320@pinky> Date: Thu, 16 Aug 2007 14:18:51 +0100 X-SPF-Guess: neutral Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Seems that a trailing ';' has slipped onto the end of the get_slice_psize checks under CONFIG_PPC_MM_SLICES causing us to return unconditionally and never preload. Signed-off-by: Andy Whitcroft Cc: Paul Mackerras Cc: linuxppc-dev@ozlabs.org --- arch/powerpc/mm/hash_utils_64.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/powerpc/mm/hash_utils_64.c b/arch/powerpc/mm/hash_utils_64.c index f178957..a47151e 100644 --- a/arch/powerpc/mm/hash_utils_64.c +++ b/arch/powerpc/mm/hash_utils_64.c @@ -795,7 +795,7 @@ void hash_preload(struct mm_struct *mm, unsigned long ea, #ifdef CONFIG_PPC_MM_SLICES /* We only prefault standard pages for now */ - if (unlikely(get_slice_psize(mm, ea) != mm->context.user_psize)); + if (unlikely(get_slice_psize(mm, ea) != mm->context.user_psize)) return; #endif