From: Martin KaFai Lau <martin.lau@linux.dev>
To: Tejun Heo <tj@kernel.org>
Cc: bpf@vger.kernel.org, David Vernet <void@manifault.com>,
Martin KaFai Lau <martin.lau@kernel.org>,
Alexei Starovoitov <ast@kernel.org>,
kernel-team@meta.com, sched-ext@meta.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH sched_ext/for-6.13 2/2] sched_ext: Replace set_arg_maybe_null() with __nullable CFI stub tags
Date: Thu, 24 Oct 2024 09:19:47 -0700 [thread overview]
Message-ID: <8b4fbfec-8315-426c-8c7b-9280726558cc@linux.dev> (raw)
In-Reply-To: <Zxma-ZFPKYZDqCGu@slm.duckdns.org>
On 10/23/24 5:55 PM, Tejun Heo wrote:
> ops.dispatch() and ops.yield() may be fed a NULL task_struct pointer.
> set_arg_maybe_null() is used to tell the verifier that they should be NULL
> checked before being dereferenced. BPF now has an a lot prettier way to
> express this - tagging arguments in CFI stubs with __nullable. Replace
> set_arg_maybe_null() with __nullable CFI stub tags.
Acked-by: Martin KaFai Lau <martin.lau@kernel.org>
next prev parent reply other threads:[~2024-10-24 16:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-24 0:54 [PATCH sched_ext/for-6.13 1/2] sched_ext: Rename CFI stubs to names that are recognized by BPF Tejun Heo
2024-10-24 0:55 ` [PATCH sched_ext/for-6.13 2/2] sched_ext: Replace set_arg_maybe_null() with __nullable CFI stub tags Tejun Heo
2024-10-24 1:04 ` Alexei Starovoitov
2024-10-24 16:19 ` Martin KaFai Lau [this message]
2024-10-24 15:28 ` [PATCH sched_ext/for-6.13 1/2] sched_ext: Rename CFI stubs to names that are recognized by BPF David Vernet
2024-10-24 16:19 ` Martin KaFai Lau
2024-10-24 16:59 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b4fbfec-8315-426c-8c7b-9280726558cc@linux.dev \
--to=martin.lau@linux.dev \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.lau@kernel.org \
--cc=sched-ext@meta.com \
--cc=tj@kernel.org \
--cc=void@manifault.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox