From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-174.mta1.migadu.com (out-174.mta1.migadu.com [95.215.58.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 25B481EF085 for ; Thu, 24 Oct 2024 16:20:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729786806; cv=none; b=lHuD45C9msCsmpUQ+dHBIqYydPhPBfxqn0yZ8njYCqfd87dXNQ/LBI9dvxlga18rdbcLjVu2Z0cTYLWKA5vepDSl71v+ru/BVtgmRaUQ1YDot844Xfl46d+Dy46agmmgjMfXcKP5GnoXhjnLPXs02/AGcUpgzrNEUBK+6dPby48= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729786806; c=relaxed/simple; bh=Zm1jVU2tfw8vmS2m5TOFDEtxXSeEP7qw2Q0PtzxL9Xs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=nqwC2KcYUCes0sTahYfXUv37KekBRpT1jQ0fNk6U6xicAJ/xitKOPm1B/uT2Rzl4Mday47xbC+0pUQc+1aeOaQMxA2JPw/tTSnsvewRSpy4JGlND+BvNHYTZB5QUlYp+CY+j/kUnxeeLloCYXxflnOZaZ826t2Hfuy4oOLz6XGk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=aLLZzL1S; arc=none smtp.client-ip=95.215.58.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="aLLZzL1S" Message-ID: <8b4fbfec-8315-426c-8c7b-9280726558cc@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1729786796; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Zm1jVU2tfw8vmS2m5TOFDEtxXSeEP7qw2Q0PtzxL9Xs=; b=aLLZzL1S6L0jyZAy8jW1OikUAXqYDxR9d/VW8+6uiC5nvj5enWf48yI4qt2SfEJ3rpEctk TwDwcuFT/DTYufCmrE9BvlWJzqxWITEJXFM+WLBVY+ZEOf69ZR3sVFRgLxyGCKOuQS2bh2 LvVrA7CNXY4+7yjGPRpmJVyQm3Uk+xM= Date: Thu, 24 Oct 2024 09:19:47 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH sched_ext/for-6.13 2/2] sched_ext: Replace set_arg_maybe_null() with __nullable CFI stub tags To: Tejun Heo Cc: bpf@vger.kernel.org, David Vernet , Martin KaFai Lau , Alexei Starovoitov , kernel-team@meta.com, sched-ext@meta.com, linux-kernel@vger.kernel.org References: Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Martin KaFai Lau In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 10/23/24 5:55 PM, Tejun Heo wrote: > ops.dispatch() and ops.yield() may be fed a NULL task_struct pointer. > set_arg_maybe_null() is used to tell the verifier that they should be NULL > checked before being dereferenced. BPF now has an a lot prettier way to > express this - tagging arguments in CFI stubs with __nullable. Replace > set_arg_maybe_null() with __nullable CFI stub tags. Acked-by: Martin KaFai Lau