From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from DM1PR04CU001.outbound.protection.outlook.com (mail-centralusazon11010032.outbound.protection.outlook.com [52.101.61.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7139E194C96 for ; Wed, 6 May 2026 06:15:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.61.32 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778048131; cv=fail; b=lYYPZD2+IgAFJuNDE5ybB9fNSW0JmoctVYxZKqJZsM9ktCCVBFl+iQ9oTXocz9DnRJxjTXMcwont06ExivBoRK12whoF/unWl+9E+NrNU0Yj59+nVq7xlm63aaf8GeRBfdqo5iOIDAL9W115eo8sE/hBRpH6Z/aXwolIv/F/mR0= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778048131; c=relaxed/simple; bh=J6+27FWFZT38cRZfpqieMgdWJxzwvF4eRSmwo9Sc0To=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=dOE6/2CF9AifGFPXzQNj+SqSedRPd7ozEv0q0GFxBBAyD8oworrzl7wThB3Y3A+tR6VzeD24GxK+r2T8FME3WfLrfvRAvgFy9DowW205wpwP1dPX3cWJ58LB/YnNO/V/p2v890AHbAYUcuy0NHgXWPE7ISluyeyn6YPP/GRATUs= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=gEZQDRQJ; arc=fail smtp.client-ip=52.101.61.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="gEZQDRQJ" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=hltjOnY5Whm9I1nd8fAMuLGdKpu/CLptiPwgEp80WqoQr1Wmu8Ni4hNH4gY83q9zJctnsFESPL9v8Kqzk5mBbVjUzcwNDOCpJIRv71y9C+ncBJZX7WHvvNG2kswEN1/YngMocy0gkl326Iu6nBK7Vr/DftK5DMWHgfXIkyCKklTOOgG9EILW7NwdEY+N74HaTHh5YRYI7ysu5kdQcSGRj1yRdUfwR14z9LfbQbvt0+LARfi1KbzVvBkUnSC3Fifqj8mfuDLcHJTIaM06wGaRg8DZe0NjjjSyaI51V9pNjqCCDmGSEZ/yV3C01M0c590UyTLfi8SHuD5QJvp9uEQRVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8U/LY9gREQWRfFkQEOrwQq6h1rS8Y+J6yUK856jDwYs=; b=RAyA6pcHPODv5Zg667GvjHkkfGGCkMevmbAflRA8m9ZB0gHln5fESkjQSI8C9gHla0XnhcozodVAIO5UB6YBq1anjaAK/xDsAu6+Ns+F4yV8WWIbL5CmI5yUX/QDxw5T1C4xEkiYnUeIFiDqwlfcrjX3NgazaibDzMHK6VCKFI0/wmQa89oj2LAnSwQjNxVnvTRSqKaL2ZcWMB2bx72AaTt0EHs/2zSoQmpYLdYa0M7jXEksDuCgRr8HtBhc7SuE9ePdCtXAt93U2BNi3q3Cx1hdzhl1z9ByFQCte63DlUfvz7P8Zdv2eE4zVmXAfwImbscc8OMVHvHFk4dZxUsviA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=linux.ibm.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8U/LY9gREQWRfFkQEOrwQq6h1rS8Y+J6yUK856jDwYs=; b=gEZQDRQJT9ZTA0HxzL+86CRlXWePlWnXvTFzjNDBd4ieB0XQp42NDATHQFRbaTRdD6D6afZtgOqlLE+qb99WKn2Vn7d3KaRJGQJqvth4USkBYx1ix9bdvhhLC/oLCcq8WfZOMcz3p8co7zUJ2T44v1AcbFiBegTlth6c1l8+eRo= Received: from BN9PR03CA0709.namprd03.prod.outlook.com (2603:10b6:408:ef::24) by SN7PR12MB7252.namprd12.prod.outlook.com (2603:10b6:806:2ac::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9870.27; Wed, 6 May 2026 06:15:24 +0000 Received: from BN1PEPF00005FFF.namprd05.prod.outlook.com (2603:10b6:408:ef:cafe::27) by BN9PR03CA0709.outlook.office365.com (2603:10b6:408:ef::24) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9891.15 via Frontend Transport; Wed, 6 May 2026 06:15:24 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb08.amd.com; pr=C Received: from satlexmb08.amd.com (165.204.84.17) by BN1PEPF00005FFF.mail.protection.outlook.com (10.167.243.231) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9891.9 via Frontend Transport; Wed, 6 May 2026 06:15:24 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.2.2562.17; Wed, 6 May 2026 01:15:24 -0500 Received: from satlexmb07.amd.com (10.181.42.216) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 6 May 2026 01:15:24 -0500 Received: from [10.252.223.214] (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server id 15.2.2562.17 via Frontend Transport; Wed, 6 May 2026 01:15:17 -0500 Message-ID: <8b515b2b-e37c-47a5-86f7-da4f3c644c60@amd.com> Date: Wed, 6 May 2026 11:45:16 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 2/7] mm: migrate: Add promote_misplaced_memcg_folios() To: Donet Tom , , CC: , , , , , , , , , , , , , , , , , , , , , , , , , , References: <20260504060924.344313-1-bharata@amd.com> <20260504060924.344313-3-bharata@amd.com> <2fd0aca2-4be3-4cab-aee4-b513ba67103e@linux.ibm.com> Content-Language: en-US From: Bharata B Rao In-Reply-To: <2fd0aca2-4be3-4cab-aee4-b513ba67103e@linux.ibm.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Received-SPF: None (SATLEXMB04.amd.com: bharata@amd.com does not designate permitted sender hosts) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN1PEPF00005FFF:EE_|SN7PR12MB7252:EE_ X-MS-Office365-Filtering-Correlation-Id: d4e861b1-92ba-4b03-57e6-08deab36dc54 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700016|376014|7416014|1800799024|82310400026|56012099003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: gVApPl904JpW3/l6zbYrLOWJrxUen5rD3AUCVEFc+TgGz2ICiG0A8T69nlhPin8+UbBPyzEzaHvo/ssnIOILTDxubocRUlY3qUZT8s5BHCpnZbqDdYCTrPh2xUwIU1h+gzL89XqNaZZcT1rbx1mrrBy/liipQrlhgiFHh9J8DdIiCEoMGMTWWZuKBu3VY4tXPOxQVeXuBt/4jxcxuTlV4caU4s2xNXFklR6NUWKAM6WhRbI0TM+siFo9CcA1X8aFa/WWCf3gsUUFFGok+OWmi2aM0h1sdEOU1JcEBclgyCeI0NUs/fdWQ+fWh3m9e4MJXNekhzxSGSvmb4Ax8D/3AMkvcZe7VfSKN79RZ2QOPDeDji8oF4JzUF7cbyjtXbbpeLic8GOyydpCLWao4PIhRsqmGW91wldZnU/VXxnVHwz+eHU2H5/hz6oT3cImAukuApT5U4jbdL4QtQQ7vT2fkvf9iqsqIv4McWfndwfZelXpq2gz10/6MMOD4HrlULU7iH9E++famm7DwG7AayAv28j9sJWmkd8b4VTEzgsT+OCf8a7MsG1eiPewV3da32sa9AyQyMq9pdN01ISvRn1YFYALV0RBKIE4oseT5vVvXiUWDvAHA7SoqIZBtDYGwc3YNl+jNwSD8uwdBlO/jMZU/crhwytxwdNgJXOSHkjwHQtafmFuvfgP39wjPyo7KwlBLUEKahvGicPwedJ3J92byZtBrH4xwg4HcSwcSiEX45E= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb08.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700016)(376014)(7416014)(1800799024)(82310400026)(56012099003)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: X9vPRN10tetIo7Cs8aBLWdkKbrIe3ZpYH5nwwnb83Ki15+M0fQcNl1g/qRvEOYe7U21l9PGqhQpD3+xFs3mCXxtV03SOqmTV+ube1Oaa2eFsSATITyjRyqyDnUfsCWB1hdV0Gy82PR4Eb+b7F3bfDHB/W56W46SCXahlzb5fxG8L9lk0I3bqWz+v1IF0TB1wS92AamdvyirQ2POSLiGN4wb4hZdy7WDjY54fXZpxImP+zJ5NgFXLzDDaPOM47xD4eaNRhWOZQ5oi+Q8UDblnd5Ax/fcLJLz/6nHzz/DphKdM4QcT9ZrsUeCI840obJxYMmh1Cn8f/mSy2EGXmpv30BpUIyQ9yESHyYm3LNDrcxIGshI0ytd/dQj6sTwJe7dpXHBW3LtdLTRa59y5pY520iYtZ2hLcsMjeZIbmHC5y2keP1un9Y0D0vpPRK1M5Kc8 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2026 06:15:24.5905 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d4e861b1-92ba-4b03-57e6-08deab36dc54 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb08.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN1PEPF00005FFF.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7252 On 04-May-26 11:44 PM, Donet Tom wrote: > Hi Bharata > > On 5/4/26 11:39 AM, Bharata B Rao wrote: >> +int promote_misplaced_memcg_folios(struct list_head *folio_list, int node) >> +{ >> +    struct mem_cgroup *memcg = NULL; >> +    unsigned int nr_succeeded = 0; >> +    struct folio *first; >> +    int nr_remaining; >> + >> +    if (list_empty(folio_list)) >> +        return 0; >> + >> +    first = list_first_entry(folio_list, struct folio, lru); >> +#ifdef CONFIG_DEBUG_VM >> +    { >> +        struct folio *f; >> +        list_for_each_entry(f, folio_list, lru) >> +        VM_WARN_ON_ONCE(folio_memcg(f) != folio_memcg(first)); > > > It looks like the indentation might be off here. Yeah looks like. Will fix. Regards, Bharata.