Re: [PATCH] RDMA/rds: remove unused struct 'rds_ib_dereg_odp_mr'

Dr. David Alan Gilbert
2024-07-21T11:00:03Z

* Zhu Yanjun (yanjun.zhu@linux.dev) wrote:
> 在 2024/6/1 1:33, linux@treblig.org 写道:
> > From: "Dr. David Alan Gilbert" <linux@treblig.org>
> >
> > 'rds_ib_dereg_odp_mr' has been unused since the original
> > commit 2eafa1746f17 ("net/rds: Handle ODP mr
> > registration/unregistration").
> >
> > Remove it.
> >
> Need Fixes?
>
> Fixes: 2eafa1746f17 ("net/rds: Handle ODP mr
> registration/unregistration")

I've not been using Fixes on these, because they
have no actual consequence - there's no need
for stable or downstream to pick them up, which is
what Fixes is often used for.

> Reviewed-by: Zhu Yanjun <yanjun.zhu@linux.dev>

Thanks,

Dave

> Zhu Yanjun
> > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> > ---
> > net/rds/ib_rdma.c | 4 ----
> > 1 file changed, 4 deletions(-)
> >
> > diff --git a/net/rds/ib_rdma.c b/net/rds/ib_rdma.c
> > index 8f070ee7e742..d1cfceeff133 100644
> > --- a/net/rds/ib_rdma.c
> > +++ b/net/rds/ib_rdma.c
> > @@ -40,10 +40,6 @@
> > #include "rds.h"
> > struct workqueue_struct *rds_ib_mr_wq;
> > -struct rds_ib_dereg_odp_mr {
> > - struct work_struct work;
> > - struct ib_mr *mr;
> > -};
> > static void rds_ib_odp_mr_worker(struct work_struct *work);
>
>
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ dave @ treblig.org | | In Hex /
\ _________________________|_____ http://www.treblig.org |_______/