From: Markus Elfring <Markus.Elfring@web.de>
To: Zhang Qiang <qiang.zhang@windriver.com>,
Tejun Heo <tj@kernel.org>, Lai Jiangshan <jiangshanlai@gmail.com>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [v2] workqueue: Fix double kfree for rescuer
Date: Mon, 25 May 2020 12:40:29 +0200 [thread overview]
Message-ID: <8b67c327-e70c-1e96-6a99-a5fd2667f666@web.de> (raw)
In-Reply-To: <bee86d19-6c14-1fd9-eead-24e63af6cf8e@windriver.com>
> I see, kfree does nothing with null pointers and direct return.
> but again kfree is not a good suggestion.
I have got the impression that the implementation detail is important here
if non-null pointers (according to valid rescuer objects) are occasionally
passed by the corresponding data structure member for the callback
function “rcu_free_wq”.
Can another clarification attempt reduce unwanted confusion for this patch review?
Regards,
Markus
next prev parent reply other threads:[~2020-05-25 10:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-25 7:59 [PATCH] workqueue: Fix double kfree for rescuer qiang.zhang
2020-05-25 8:20 ` [PATCH v2] workqueue: Delete duplicate kfree() call for “rescuer” from rcu_free_wq() Markus Elfring
2020-05-25 9:50 ` [PATCH v2] workqueue: Fix double kfree for rescuer Markus Elfring
2020-05-25 9:55 ` Markus Elfring
2020-05-25 10:19 ` qzhang2
2020-05-25 10:40 ` Markus Elfring [this message]
2020-05-26 2:05 ` [v2] " qzhang2
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b67c327-e70c-1e96-6a99-a5fd2667f666@web.de \
--to=markus.elfring@web.de \
--cc=jiangshanlai@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=qiang.zhang@windriver.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox