From: Stephen Boyd <sboyd@kernel.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>, Rob Herring <robh@kernel.org>
Cc: Saravana Kannan <saravanak@google.com>,
linux-kernel@vger.kernel.org, patches@lists.linux.dev,
devicetree@vger.kernel.org, kunit-dev@googlegroups.com
Subject: Re: [PATCH] of: Allow overlay kunit tests to run CONFIG_OF_OVERLAY=n
Date: Tue, 12 Nov 2024 11:50:48 -0800 [thread overview]
Message-ID: <8b6d74e31161c8fadad926fe1c20ce1d.sboyd@kernel.org> (raw)
In-Reply-To: <20241108165532.GA2411452-robh@kernel.org>
Quoting Rob Herring (2024-11-08 08:55:32)
> On Fri, Nov 08, 2024 at 09:56:15AM +0100, Geert Uytterhoeven wrote:
> > > > > Fixes: 5c9dd72d8385 ("of: Add a KUnit test for overlays and test managed APIs")
> > > >
> > > > Doesn't really seem like a fix.
> > >
> > > Ok. Feel free to drop the tag.
> > >
> > > > Does this need to go into 6.12?
> > >
> > > It's only important for 6.12 if kernel configurators want to build the
> > > kernel with OF_OVERLAY_KUNIT_TEST enabled and not be forced to enable
> > > CONFIG_OF_OVERLAY. I don't mind if it waits a while.
> >
> > I'd say it's a fix, so please keep at last the Fixes tag. Merely
> > enabling kunit tests (which can be modular) should not increase the
> > possible attack vector on a product by enabling extra unneeded code.
>
> Not sure I buy that that is an actual problem. However, not worth
> arguing over. I only really care because if there's a Fixes, then this
> really should go to Linus for 6.12 rather than eventually get
> auto-selected from 6.13 to go to stable. So I moved it to send to Linus,
> but I found that CONFIG_OF_OVERLAY is still selected with this patch.
> That's because the clock kunit tests also select CONFIG_OF_OVERLAY.
> That's fixed in next, but it's not queued up for 6.12.
>
I was planning to send the clk patch in the next merge window. Are you
sending the fix now? If you want you can also send the clk side patch
and I can drop it from the clk tree.
prev parent reply other threads:[~2024-11-12 19:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-16 21:20 [PATCH] of: Allow overlay kunit tests to run CONFIG_OF_OVERLAY=n Stephen Boyd
2024-10-17 20:38 ` Rob Herring
2024-10-18 22:21 ` Stephen Boyd
2024-11-08 8:56 ` Geert Uytterhoeven
2024-11-08 16:55 ` Rob Herring
2024-11-12 19:50 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b6d74e31161c8fadad926fe1c20ce1d.sboyd@kernel.org \
--to=sboyd@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@lists.linux.dev \
--cc=robh@kernel.org \
--cc=saravanak@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox