Re: [PATCH net-next v4 04/12] net: ethernet: oa_tc6: implement software reset

Andrew Lunn
2024-04-23T23:26:29Z

> +static int oa_tc6_read_status0(struct oa_tc6 *tc6)
> +{
> + u32 regval;
> + int ret;
> +
> + ret = oa_tc6_read_register(tc6, OA_TC6_REG_STATUS0, &regval);
> + if (ret)
> + return 0;

If there is an error, your throw the error code away?

It is a bit messy, since you are using this inside
readx_poll_timeout(). I would probably do a netdev_warn() or similar,
since it should not happen, and then return 0? I _think_ this is
probably the first bus transaction we do, so if it fails, knowing the
error code will help figuring out what is wrong with the SPI bus
configuration.

Andrew