Re: [PATCH net-next v4 11/12] microchip: lan865x: add driver support for Microchip's LAN865X MAC-PHY

Andrew Lunn
2024-04-29T12:09:36Z

> Looks like, the below changes needed to work correctly,
>
> lan865x.c:
> - compatible string to be changed like below as it is a fallback for all
> variants,
> .compatible = "microchip,lan8650"
> - DRV_NAME to be changed like below,
> #define DRV_NAME "lan8650"
>
> microchip,lan865x.example.dts for lan8650:
> - compatible string to be changed like below,
> .compatible = "microchip,lan8650";
> OR
> microchip,lan865x.example.dts for lan8651:
> - compatible string to be changed like below,
> compatible = "microchip,lan8651", "microchip,lan8650";
>
> I tested with the above changes and there was no issues observed. Any
> comments on this? Otherwise we can stick with these changes for the next
> version.

As Conor said, this is probably relying on the fallback
mechanism. Please look at other SPI devices, e.g. hwmon, and see how
they probe for multiple different devices.

Andrew