Re: [PATCH net-next v4 08/12] net: ethernet: oa_tc6: implement transmit path to transfer tx ethernet frames

Parthiban.Veerasooran
2024-04-26T13:19:50Z

Hi Andrew,

On 24/04/24 5:32 am, Andrew Lunn wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
>> +static int oa_tc6_process_extended_status(struct oa_tc6 *tc6)
>> +{
>> + u32 value;
>> + int ret;
>> +
>> + ret = oa_tc6_read_register(tc6, OA_TC6_REG_STATUS0, &value);
>> + if (ret) {
>> + netdev_err(tc6->netdev, "STATUS0 register read failed: %d\n",
>> + ret);
>> + return -ENODEV;
>> + }
>> +
>> + /* Clear the error interrupts status */
>> + ret = oa_tc6_write_register(tc6, OA_TC6_REG_STATUS0, value);
>> + if (ret) {
>> + netdev_err(tc6->netdev, "STATUS0 register write failed: %d\n",
>> + ret);
>> + return -ENODEV;
>
> More examples where you replace one error code with a different one.
Yes I noted. Somehow I messed up with all the -ENODEV. I will take of
this in all the places in the next version.

Best regards,
Parthiban V
>
> Andrew
>