From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D9018286A7 for ; Wed, 24 Dec 2025 00:12:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766535171; cv=none; b=kDJXOPLGAM9ef4xCpBIaO7oK43JS3E7DLNv9IOExfZ52SyYX535rpW0Vc2sy8dXI1gjVqkYOLrSIB+NaKpDD5Dspdtj+fz2BWonft5Lf0FLqQY/hQ06BEgTdGzFLtlaM+ZbSkSIjgQsLIFPx2m6pfVNlvQLe1feSNBVuIP9FnZk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766535171; c=relaxed/simple; bh=EBmZmCdIjhmTwNIGsddrXweg27XCEIU28L5u4v1hj3Y=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ggy+E9SiyhGjXlCA9q+16ocssFibFiF3bVZTXVqMulmXKCTNIN5efQeVM2Ma8ED4t1tJ3oTxMgjYjBa806aaPBJNe8sygvgxKK45/Kaz3pEsP94ZGr8dPq6MiM5wAkzUJ6Fwm9QKIZplrRfl7QXKHQmNnLv7YHxHHqysV1GX5tc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=RP6Egrwh; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=FFfz7/yo; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="RP6Egrwh"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="FFfz7/yo" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BNGOG5A1018267 for ; Wed, 24 Dec 2025 00:12:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= EBmZmCdIjhmTwNIGsddrXweg27XCEIU28L5u4v1hj3Y=; b=RP6EgrwhfQBdzJOz euPLu5eCb8Q5riTXdLigsdZ+Tn666b6ymhcdyW1SCFNYIUZ4YE72RPS13lxToprg eKA+3v8QGitCkdXayqWXyscuwhHfScmm2PT0LS2KRMuV+NsQHrfCoPn9kXdUW70l mUUxnFjOKuQUSMsJOHUz/yeMRcZlWsnTGQeySs+x+IdyzqTciXtLxZv0fFsFJ2M6 LtYmjMK/x28zblEX+AIqwM2FaD/+RQPoM1yf2RgKRLzjcqTYGWZSQ5Pm57eatcyA dt5LUQNhrCP9i4bNEnAiN8bYvF76V5VLuEqt3JKhMnM/VHjhBpPeijty9cB6hxgu Xhdg5A== Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b7xjs97r7-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 24 Dec 2025 00:12:48 +0000 (GMT) Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-7f21951c317so4555103b3a.2 for ; Tue, 23 Dec 2025 16:12:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766535167; x=1767139967; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=EBmZmCdIjhmTwNIGsddrXweg27XCEIU28L5u4v1hj3Y=; b=FFfz7/yoVMKh/5fOSs6bwLmnV1tuA9ofw6pzb72BSrK2wc8WdL2FxMH6m8oKB0a/Ds NHTIaZTGfXigHIHSpUK4vXGU48Htj99krAD1YjVr49zxXQxmtFRTyN5XtjQ0PUMVdNpn MN/hBEiO9/95zq3cCo3mzerHvpeeOGHoVReWRSV97THwFy2onjbCYn5ZhNUG06F6CXJA Sg/cBw8cYVwlo7IoYDeedVvYL2zgVWAMOA+iHaFDqu4yEBMTSXl+n7qP4ZPlaKaq7hNB 8+aZbJxc413s6MaPg6Hy77LOOXpUxJWiZN5lFPdik2hIPtTeN1JOs3F/6a+fALnkSb1j jVDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766535167; x=1767139967; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=EBmZmCdIjhmTwNIGsddrXweg27XCEIU28L5u4v1hj3Y=; b=rdFmgc0U1zABmXKpTkhddpwSjBzNKIxigmYXHxUTSeeQxHNvG49cFCRWxWCEXvax36 GJbqvcjON/yMUts3CpHDi1jhF24+eNQi/7lVWdfCtJ/MjfxnSY6DbztDRx22BRD5dY2W xIqN+9mwZcWNs4aafg4rFt5csFRcp5CSaDYUYMdyKhtrzMsPmyH+xO2nmRwacneXnFiL PWP/IPqz0GfREGRvZbhNVcgR8c7T9VeU+5o1J0yxegTdXXoe4zhl7rRj0n5KaZ6Dibcl BVoY6wqfp6kLgCt2AJCztQi5zfbAUpzarwb+X0Y7dOoosnmbIsedh8/DJ6p5JTcoDUJl cW2Q== X-Forwarded-Encrypted: i=1; AJvYcCVZWG8aojpqGlcZ401xTKfL378150oFAvdZARHM5rbBFB8mtl6BvbTSamf0tq36WsJlb737JUj4MQTsM4I=@vger.kernel.org X-Gm-Message-State: AOJu0Yw/C2SRshXzRq0dZMupZhQ3E7GOmcQ+wV4rsBQ3dJyntjwSd7yw RJnNG519ARidB9N3XPc9veZi04TAz4VRdfJmpQwiH9cglUXzVOB465xyuGzlbj9CJZArILfJPfE 0xmiLzPMGOs2WhnrylHxO870jVUGuf0pDxGMDjpJI+P/6nAtmHdjkVVx2QqyOoikN8yevNl0NtB s= X-Gm-Gg: AY/fxX6bmPrWzBBap+7S2ww++vYwMkAQIGc8mKbP2WBtty7h0AwIUcUySyRXlnWB5iD c1oFeB3wmDqZZPf5FgCUbiiOyv2p8zZJeHQ0KBZTSGOt06SOtY3kf6tG+cNedk11fI1gW3rbaaa kaX2w2KqEoPHDmQItsXzP4Ua8GbGA3Xg0qN0QkDIpO6caBV29s6Q2+i/LOXCiU8GPZZZF4EMTxB Z92And74qCaxHApm8ktqMi4y7tRNoAIOdE8P0LVGPLmHUFQbA8GWBsAc3tCe7ObygCCTNu2NLBd a0IYq7mxtnucjru1apyKH5f2vfSEe+QWYO10Sm9krbjYs0jXwF/FRTtDIzE2tyrirm/JNH06Hiy Dkjj/wsDp7SKAf/Tx61GhFPteqcrAVzoOMubM96WfEe3AX8PTgwCxt6oYm0PLGXJv2+fz26HjNV TCCeq/hA== X-Received: by 2002:a05:6a20:748e:b0:366:1a00:2dab with SMTP id adf61e73a8af0-376a77f10bcmr13573284637.3.1766535167520; Tue, 23 Dec 2025 16:12:47 -0800 (PST) X-Google-Smtp-Source: AGHT+IHLEksbODQp1xcBoYDTeUyro4Zzh9VJ6vvaGe6Cc544hEo4hwwF8bceDPDrRRVskRp9kcFHrA== X-Received: by 2002:a05:6a20:748e:b0:366:1a00:2dab with SMTP id adf61e73a8af0-376a77f10bcmr13573269637.3.1766535167046; Tue, 23 Dec 2025 16:12:47 -0800 (PST) Received: from [10.133.33.219] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c1e79620bd3sm12752588a12.4.2025.12.23.16.12.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Dec 2025 16:12:46 -0800 (PST) Message-ID: <8bcf058f-5bf9-46ce-a188-e94954101f2f@oss.qualcomm.com> Date: Wed, 24 Dec 2025 08:12:42 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/4] arm64: dts: qcom: Commonize IQ-X-IOT DTSI To: Krzysztof Kozlowski , YijieYang Cc: andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20251222-purwa-v1-0-14ab9316e5ff@oss.qualcomm.com> <20251222060335.3485729-3-yijie.yang@oss.qualcomm.com> <20251222-fluorescent-turkey-of-gallantry-df0906@quoll> <6421f044-2b07-4518-9edc-b9b2ef49f4fb@kernel.org> Content-Language: en-US From: Tingwei Zhang In-Reply-To: <6421f044-2b07-4518-9edc-b9b2ef49f4fb@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjIzMDIwNSBTYWx0ZWRfXzButBuJUvxYq z9x5ShjJZzCzetyTY2zCxsDlelz8xScbtK5kYYj68ZnOC0m9dMJ/56+xkcNCUlGgTCrVPwXgLnJ oKBSoWEQPv5Fyo9Hrm+kTtCLdiunrm8d7HH02KVs8CK5vVTrFhv5kQQZzPssoSMGuNhCNgU6nJ9 PimZ0+RE0ro6kzdh/FMxMiNtRJcjDMnHJ+wFo2TJYejYZwHCnLGb9wDxf5dxolA2Zc18qW3Y+L0 fLMbf2aI9/+c5sr0t8GetdAfeOaNT3bvGfHDrPQjFZ5754+yUgd2+U88Em//4y2m7yoUODKVZuC ZOHR0DtsnFE8xPbRj4+1+iJnWkzC6SnKMPDFgqjewfhfdH1n5SaZY2Toi1X5CqJbsMrYY+1YLxg F5CA0+JJDAFvloVrqu7Z6+aFhu4JZL+zzvzpXOAf9/4i7nyFcfoNIFhdeMveeE5uEoUXzB1bIFU VcV449vqYO70uv7nB7g== X-Proofpoint-ORIG-GUID: K4hom-hgiBt56uF78sAVquppK3Mt2xj0 X-Authority-Analysis: v=2.4 cv=YcqwJgRf c=1 sm=1 tr=0 ts=694b3000 cx=c_pps a=WW5sKcV1LcKqjgzy2JUPuA==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=6y73sl-2QnXYpYKhnwwA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=OpyuDcXvxspvyRM73sMx:22 X-Proofpoint-GUID: K4hom-hgiBt56uF78sAVquppK3Mt2xj0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-23_05,2025-12-22_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 malwarescore=0 priorityscore=1501 impostorscore=0 lowpriorityscore=0 adultscore=0 phishscore=0 clxscore=1015 bulkscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512230205 On 12/23/2025 9:41 PM, Krzysztof Kozlowski wrote: > On 23/12/2025 04:38, Tingwei Zhang wrote: >> >> On 12/22/2025 5:11 PM, Krzysztof Kozlowski wrote: >>> On Mon, Dec 22, 2025 at 02:03:28PM +0800, YijieYang wrote: >>>> From: Yijie Yang >>>> >>>> HAMOA-IOT-EVK and PURWA-IOT-EVK share a similar board design. Extract >>>> the common components into separate files for better maintainability. >>> SoMs do not share actual hardware. DTSI does not represent what looks >>> similar to you, but actually common parts. >> Purwa SOM board and Hamoa SOM board share same design. They share same PCB. >> The difference is only on chip. Purwa SOM board has Purwa and Hamoa SOM board >> has Hamoa on it.  > I do not speak about boards. Read carefully feedback and respond to the > actual feedback, not some other arguments. > > NAK In this change, the SoM hardware except SoC is described by iq-x-iot-som.dtsi since it's common between Hamoa and Purwa. Hamoa and Purwa SoC hardware is described in hamoa.dtsi and purwa.dtsi. Hamoa-iot-som.dtsi includes iq-x-iot-som.dtsi and hamoa.dtsi. This change could reduce the duplicate code and review effort on a totally new purwa-iot-som.dtsi. If we found any bug, it can be fixed in one common file instead of two separate files. Same idea is used in x1-crd.dtsi. X1e80100-crd.dts include x1-crd.dtsi and hamoa.dtsi. > Best regards, > Krzysztof