From: "Mike Frysinger" <vapier.adi@gmail.com>
To: "Daniel Barkalow" <barkalow@iabervon.org>
Cc: "richard kennedy" <richard@rsk.demon.co.uk>,
bryan.wu@analog.com,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Bryan Wu" <cooloney.lkml@gmail.com>
Subject: Re: [rfc] exposing MMR's of on-chip peripherals for debugging purposes
Date: Mon, 28 Jan 2008 19:15:01 -0500 [thread overview]
Message-ID: <8bd0f97a0801281615w6fbdd77aifda714685f56cc41@mail.gmail.com> (raw)
In-Reply-To: <alpine.LNX.1.00.0801281901130.13593@iabervon.org>
On Jan 28, 2008 7:08 PM, Daniel Barkalow <barkalow@iabervon.org> wrote:
> On Mon, 28 Jan 2008, Mike Frysinger wrote:
> > On Jan 28, 2008 8:04 AM, richard kennedy <richard@rsk.demon.co.uk> wrote:
> > > there is a lot of duplication in your file, but you could slim it down a
> > > bit if thats the only objection.
> >
> > i imagine there's a ton of duplication ... the file is auto-generated
> > from XML files, so i could take a look at the autogeneration producing
> > unified code.
>
> Could you submit the XML files and the autogeneration code? The C file
> isn't really source. Not only is it big, it'll probably change around a
> whole lot when you make small changes to your process, be hard to review,
> etc.
that would require the build system to have xml tools installed ...
that doesnt sound pleasant.
that said, the XML files in question are probably 10x+ the size of the
C file. swapping 1 meg for 10+ megs ? :)
-mike
next prev parent reply other threads:[~2008-01-29 0:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-28 10:16 [rfc] exposing MMR's of on-chip peripherals for debugging purposes Mike Frysinger
2008-01-28 10:19 ` Mike Frysinger
2008-01-28 10:40 ` Bryan Wu
2008-01-28 11:06 ` Mike Frysinger
2008-01-28 13:04 ` richard kennedy
2008-01-28 13:10 ` Mike Frysinger
2008-01-29 0:08 ` Daniel Barkalow
2008-01-29 0:15 ` Mike Frysinger [this message]
2008-01-29 0:30 ` Daniel Barkalow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8bd0f97a0801281615w6fbdd77aifda714685f56cc41@mail.gmail.com \
--to=vapier.adi@gmail.com \
--cc=barkalow@iabervon.org \
--cc=bryan.wu@analog.com \
--cc=cooloney.lkml@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=richard@rsk.demon.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox