From: Mike Frysinger <vapier.adi@gmail.com>
To: uClinux development list <uclinux-dev@uclinux.org>
Cc: linux-kernel@vger.kernel.org, Greg Ungerer <gerg@uclinux.org>,
uclinux-dist-devel@blackfin.uclinux.org,
David McCullough <davidm@snapgear.com>
Subject: Re: [uClinux-dev] Re: [PATCH] NOMMU: add [stack] label to per-process maps output
Date: Wed, 16 Dec 2009 14:36:32 -0500 [thread overview]
Message-ID: <8bd0f97a0912161136g19fdc4eeif977b56c98464f8b@mail.gmail.com> (raw)
In-Reply-To: <20419.1260982769@redhat.com>
On Wed, Dec 16, 2009 at 11:59, David Howells wrote:
> Mike Frysinger wrote:
>
>> + if (vma->vm_start <= mm->start_brk &&
>> + vma->vm_end >= mm->brk) {
>
> Hmmm... That ought to involve mm->start_stack somewhere... (Or, more
> probably, task->stack_start:-/)
in practice, it's probably always the same result, but you're right of
course. when i looked through the elf_fdpic code, i looked at the
start_brk mmap() and missed the later start_stack assignment later on.
-mike
next prev parent reply other threads:[~2009-12-16 19:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-15 23:55 [PATCH] NOMMU: add [stack] label to per-process maps output Mike Frysinger
2009-12-16 8:54 ` David Howells
2009-12-16 16:59 ` David Howells
2009-12-16 19:36 ` Mike Frysinger [this message]
2009-12-17 22:49 ` [uClinux-dev] " Mike Frysinger
2009-12-17 23:27 ` David Howells
2009-12-21 14:35 ` [PATCH v2] " Mike Frysinger
2009-12-22 15:58 ` David Howells
2010-05-24 5:35 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8bd0f97a0912161136g19fdc4eeif977b56c98464f8b@mail.gmail.com \
--to=vapier.adi@gmail.com \
--cc=davidm@snapgear.com \
--cc=gerg@uclinux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=uclinux-dev@uclinux.org \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).