Re: [PATCH 1/2] Blackfin: initial tracehook support

[Mike Frysinger <vapier.adi@gmail.com>]

On Sat, Feb 13, 2010 at 04:41, Mike Frysinger wrote:
> On Fri, Feb 12, 2010 at 15:44, Roland McGrath wrote:
>> Moreover, the usual cleanup is to make your arch_ptrace() use
>> copy_regset_from_user() and copy_regset_to_user() to implement existing
>> calls ike PTRACE_GETREGS.  That way, existing ptrace users (strace, gdb)
>> become tests of the user_regset paths (some of them).

unfortunately the Blackfin ports of both gdb and strace do not use the
PTRAGE_{G,S}ETREGS interfaces.  so i had to port both in order to test
out the new code.

> OK, this should be doable.  are there any guidelines for what should
> be in a specific regset ?  the Blackfin processor does not have a FPU,
> so the only set i have defined atm is the "general" set and that is
> exactly the same as the current set of ptrace registers.  this is also
> what the current PTRACE_{G,S}ETREGS operates on (struct pt_regs).

going by the gdb code, all i really need to worry about is the
"general" set and have that be the same as pt_regs today

i have one or two small things to check out, but i think we should be
all set now thanks to your help
-mike