Re: [PATCH net-next v4 05/12] net: ethernet: oa_tc6: implement error interrupts unmasking

Andrew Lunn
2024-05-06T01:21:39Z

> [ 285.482275] LAN865X Rev.B0 Internal Phy spi0.0:00: attached PHY
> driver (mii_bus:phy_addr=spi0.0:00, irq=POLL)
> [ 285.534760] lan865x spi0.0 eth1: Link is Up - 10Mbps/Half - flow
> control off
> [ 341.466221] eth1: Receive buffer overflow error
> [ 345.730222] eth1: Receive buffer overflow error
> [ 345.891126] eth1: Receive buffer overflow error
> [ 346.074220] eth1: Receive buffer overflow error

Generally we only log real errors. Is a receive buffer overflow a real
error? I would say not. But it would be good to count it.

There was also the open question, what exactly does a receive buffer
overflow mean?

The spec says:

9.2.8.11 RXBOE

Receive Buffer Overflow Error. When set, this bit indicates that the
receive buffer (from the network) has overflowed and receive frame
data was lost.

Which is a bit ambiguous. I would hope it means the receiver has
dropped the packet. It will not be passed to the host. But other than
maybe count it, i don't think there is anything to do. But Ramón was
suggesting you actually drop the frame currently be transferred over
the SPI bus?

Andrew