From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EADEC43463 for ; Fri, 18 Sep 2020 18:18:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3EA6520DD4 for ; Fri, 18 Sep 2020 18:18:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="PKCVUz27" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726269AbgIRSS4 (ORCPT ); Fri, 18 Sep 2020 14:18:56 -0400 Received: from fllv0015.ext.ti.com ([198.47.19.141]:35286 "EHLO fllv0015.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726199AbgIRSSz (ORCPT ); Fri, 18 Sep 2020 14:18:55 -0400 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 08IIIjBs071479; Fri, 18 Sep 2020 13:18:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1600453125; bh=cFGQg+1KZ4pDx/j/j43AbBotFhKCYoUkrHxGwcXbl9A=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=PKCVUz27D3PoAfNXE7rtm2L1nq7bPsZDlB4vsdff/DFAAwOR0iESG/7QDK7rCjFrT TOxxlctXXtWlgF5YKb7jRDTWtrqRQ++h+hKUynBv5Gqo4HKao6Pc2Rz/armkI7+Kbf KBut5vPJFiB6MCJE/EZW+6KArZ8XVujiJ0S6TK5o= Received: from DLEE102.ent.ti.com (dlee102.ent.ti.com [157.170.170.32]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 08IIIjvf110052 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 18 Sep 2020 13:18:45 -0500 Received: from DLEE115.ent.ti.com (157.170.170.26) by DLEE102.ent.ti.com (157.170.170.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Fri, 18 Sep 2020 13:18:44 -0500 Received: from fllv0040.itg.ti.com (10.64.41.20) by DLEE115.ent.ti.com (157.170.170.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Fri, 18 Sep 2020 13:18:44 -0500 Received: from [10.250.35.164] (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 08IIIice000609; Fri, 18 Sep 2020 13:18:44 -0500 Subject: Re: [PATCH 1/2] ASoC: tas2770: Fix calling reset in probe To: , , CC: , References: <20200918161842.4451-1-dmurphy@ti.com> From: Dan Murphy Message-ID: <8bf4ae51-6cf7-aa43-e00b-c875ea5a0548@ti.com> Date: Fri, 18 Sep 2020 13:18:39 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200918161842.4451-1-dmurphy@ti.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org All On 9/18/20 11:18 AM, Dan Murphy wrote: > tas2770_reset is called during i2c probe. The reset calls the > snd_soc_component_write which depends on the tas2770->component being > available. The component pointer is not set until codec_probe so move > the reset to the codec_probe after the pointer is set. I have been updating the tas2770 to add another device to the driver and I have quite a few unexpected patches on top of these. I am not even sure how this driver is even working at the moment. I will re-submit the complete set of patches as Mark pointed out in another email chain. So please ignore these patches for now plus the DT binding patch. Dan