Re: [GIT PULL] clk: samsung: drivers for v6.10

Krzysztof Kozlowski
2024-05-08T06:24:49Z

On 07/05/2024 22:43, Stephen Boyd wrote:
> Quoting Krzysztof Kozlowski (2024-05-06 22:54:10)
>> On 07/05/2024 01:44, Stephen Boyd wrote:
>>> Quoting Krzysztof Kozlowski (2024-05-04 05:06:22)
>>>> The following changes since commit 4cece764965020c22cff7665b18a012006359095:
>>>>
>>>> Linux 6.9-rc1 (2024-03-24 14:10:05 -0700)
>>>>
>>>> are available in the Git repository at:
>>>>
>>>> https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux.git tags/samsung-clk-6.10
>>>
>>> I'm getting compile warnings. Is there a pending fix? Also, why is GS101
>>
>> I don't see any of these warnings. Neither local (W=1), nor on my CI,
>> nor reported by LKP (which reported build successes for this branch).
>> How can I reproduce it?
>
> I ran this command
>
> make W=1 ARCH=arm CROSS_COMPILE=arm-linux-gnueabi- drivers/clk/samsung/clk-gs101.o
>
> and I see the warnings. They're actually upgraded to errors.

So regular W=1 build... weird.

>
>>
>>
>>> describing clk parents with strings instead of using clk_parent_data?
>>
>> GS101 uses existing Samsuung clock framework, so that's how it is done
>> there. There is nothing odd here, comparing to other Samsung clocks.
>
> Ok. Is anyone working on migrating Samsung clk drivers to the non-string
> way?

I am not aware of it. There was no serious development for Samsung SoC
in total for years.

>
>>
>>>
>>> In file included from drivers/clk/samsung/clk-gs101.c:16:
>>> drivers/clk/samsung/clk-gs101.c:2616:7: error: ‘mout_hsi2_mmc_card_p’
>>> defined but not used [-Werror=unused-const-variable=]
>>> 2616 | PNAME(mout_hsi2_mmc_card_p) = { "fout_shared2_pll", "fout_shared3_pll",
>>
>> I see indeed some unused variables and I will drop them but your
>> warnings are not reproducible.
>
> Weird! I use gcc-12.2 if that helps. I've been meaning to upgrade but I
> also don't see much urgency.
>
> I'll wait for the next PR.

Yes, patch is already in linux-next, so I'll wait a bit and send today.

Best regards,
Krzysztof