Re: [PATCH 02/11] dts: hisilicon: Update coresight bindings for hardware ports

Suzuki K Poulose
2018-09-12T12:42:15Z

Hi Leo,

On 12/09/18 11:47, leo.yan@linaro.org wrote:
> On Tue, Sep 11, 2018 at 11:17:03AM +0100, Suzuki K Poulose wrote:
>> Switch to updated coresight bindings for hw ports.
>
> As Shawn suggested, please change subject as "arm64: dts: hi6220:
> ...."
>

Sure, will do.

>> Cc: xuwei5@hisilicon.com
>> Cc: lipengcheng8@huawei.com
>> Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
>> Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
>> ---
>> .../arm64/boot/dts/hisilicon/hi6220-coresight.dtsi | 147 ++++++++++++---------
>> 1 file changed, 85 insertions(+), 62 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/hisilicon/hi6220-coresight.dtsi b/arch/arm64/boot/dts/hisilicon/hi6220-coresight.dtsi
>> index 7afee5d..2202816 100644
>> --- a/arch/arm64/boot/dts/hisilicon/hi6220-coresight.dtsi
>> +++ b/arch/arm64/boot/dts/hisilicon/hi6220-coresight.dtsi
>
> [...]
>
>> @@ -302,10 +315,12 @@
>>
>> cpu = <&cpu3>;
>>
>> - port {
>> - etm3_out: endpoint {
>> - remote-endpoint =
>> - <&acpu_funnel_in3>;
>> + out-ports {
>> + port {
>> + etm3_out: endpoint {
>> + remote-endpoint =
>> + <&acpu_funnel_in3>;
>> + };
>> };
>> };
>> };
>> @@ -319,10 +334,12 @@
>>
>> cpu = <&cpu4>;
>>
>> - port {
>> + out-ports {
>> + port {
>> etm4_out: endpoint {
>
> Indent?

Yes, I have fixed this locally for v2.

>
> After applied this patch and tested on Hikey board; FWIW:
>
> Tested-by: Leo Yan <leo.yan@linaro.org>

Thanks for the testing !

Cheers
Suzuki